From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16637C27C53 for ; Wed, 19 Jun 2024 12:19:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJuGZ-0003Qf-LC; Wed, 19 Jun 2024 08:18:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJuGY-0003Q6-Oo for qemu-devel@nongnu.org; Wed, 19 Jun 2024 08:18:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJuGW-0002w7-4l for qemu-devel@nongnu.org; Wed, 19 Jun 2024 08:18:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718799494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5/tpZLFHW5fC72/PpNhTShzyHE8C4DDxd2fiB1BIWVM=; b=JbwWRpOLc67rJBNEDHADNXbCFif3j0MdBXfw52lEX51GxhH0OrxgEryPVhW0tfIv/z2zBN h1uRe1CgmsNtLhUwx/15xJnfYAVadF7Wa5fLuE/NNSCNVuAUAravMIpA/ctSHNp5VUIVWy oPH/Fc87aaljfc7BN39N+CQxc8+Zv2k= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-duVv-PFQPBS8hUkY5MCU2g-1; Wed, 19 Jun 2024 08:18:09 -0400 X-MC-Unique: duVv-PFQPBS8hUkY5MCU2g-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EC77D1956083; Wed, 19 Jun 2024 12:18:06 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.93]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 59D9419560AE; Wed, 19 Jun 2024 12:18:06 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id CA39221E6687; Wed, 19 Jun 2024 14:18:03 +0200 (CEST) From: Markus Armbruster To: John Snow Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Hanna Reitz , Michael Roth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Victor Toso de Carvalho , "Michael S. Tsirkin" , Konstantin Kostiuk , Yanan Wang , Pavel Dovgalyuk , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Marcel Apfelbaum , Fabiano Rosas , Lukas Straub , Eduardo Habkost , Mads Ynddal , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Gerd Hoffmann , Stefan Berger , Peter Xu , Igor Mammedov , =?utf-8?Q?C=C3=A9dric?= Le Goater , Jason Wang , Ani Sinha , Paolo Bonzini , Peter Maydell , qemu-block@nongnu.org, Jiri Pirko , Alex Williamson , Kevin Wolf , Eric Blake Subject: Re: [PATCH 10/13] qapi: update prose in note blocks In-Reply-To: <20240619003012.1753577-11-jsnow@redhat.com> (John Snow's message of "Tue, 18 Jun 2024 20:30:09 -0400") References: <20240619003012.1753577-1-jsnow@redhat.com> <20240619003012.1753577-11-jsnow@redhat.com> Date: Wed, 19 Jun 2024 14:18:03 +0200 Message-ID: <87le3115z8.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 11 X-Spam_score: 1.1 X-Spam_bar: + X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.144, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org John Snow writes: > Where I've noticed, rephrase the note to read more fluently. > > Signed-off-by: John Snow > --- > qapi/block-core.json | 4 ++-- > qga/qapi-schema.json | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index cacedfb771c..9ef23ec02ae 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -6048,9 +6048,9 @@ > # > # @name: the name of the internal snapshot to be created > # > -# .. note:: In transaction, if @name is empty, or any snapshot matching > +# .. note:: In a transaction, if @name is empty or any snapshot matching > # @name exists, the operation will fail. Only some image formats > -# support it, for example, qcow2, and rbd. > +# support it; for example, qcow2, and rbd. > # > # Since: 1.7 > ## > diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json > index 57598331c5c..1273d85bb5f 100644 > --- a/qga/qapi-schema.json > +++ b/qga/qapi-schema.json > @@ -480,7 +480,7 @@ > # > # Returns: Number of file systems thawed by this call > # > -# .. note:: If return value does not match the previous call to > +# .. note:: If the return value does not match the previous call to > # guest-fsfreeze-freeze, this likely means some freezable filesystems > # were unfrozen before this call, and that the filesystem state may > # have changed before issuing this command. Reviewed-by: Markus Armbruster