All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: <linux-sound@vger.kernel.org>, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v3 2/2] ALSA: pcm: optimize and clarify stream sychronization ID API
Date: Tue, 07 May 2024 14:38:45 +0200	[thread overview]
Message-ID: <87le4leqzu.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240507083142.557299-3-perex@perex.cz>

On Tue, 07 May 2024 10:26:19 +0200,
Jaroslav Kysela wrote:
> 
> +static inline void snd_pcm_set_sync(struct snd_pcm_substream *substream)
> +{
> +	substream->runtime->sync_flag = true;
> +}

This function deserves for a proper comment.  The kerndoc comment is
lost by this patch.

> @@ -1811,10 +1829,12 @@ static int snd_pcm_lib_ioctl_fifo_size(struct snd_pcm_substream *substream,
>  static int snd_pcm_lib_ioctl_sync_id(struct snd_pcm_substream *substream,
>  				     void *arg)
>  {
> -	struct snd_pcm_hw_params *params = arg;
> +	static unsigned char id[12] = { 0xff, 0xff, 0xff, 0xff,
> +					0xff, 0xff, 0xff, 0xff,
> +					0xff, 0xff, 0xff, 0xff };

This can be const.


thanks,

Takashi

  reply	other threads:[~2024-05-07 12:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-07  8:26 [PATCH v3 0/2] ALSA: pcm: reinvent the stream synchronization ID API Jaroslav Kysela
2024-05-07  8:26 ` [PATCH v3 1/2] " Jaroslav Kysela
2024-05-07 12:33   ` Takashi Iwai
2024-05-07  8:26 ` [PATCH v3 2/2] ALSA: pcm: optimize and clarify stream sychronization " Jaroslav Kysela
2024-05-07 12:38   ` Takashi Iwai [this message]
2024-05-07 12:40 ` [PATCH v3 0/2] ALSA: pcm: reinvent the stream synchronization " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le4leqzu.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.