From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C35DC48BF8 for ; Mon, 19 Feb 2024 15:44:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rc5nx-0007sz-EV; Mon, 19 Feb 2024 10:43:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc5nw-0007sr-O7 for qemu-devel@nongnu.org; Mon, 19 Feb 2024 10:43:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc5nv-0000bT-D8 for qemu-devel@nongnu.org; Mon, 19 Feb 2024 10:43:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708357418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uPQmf6RkLVz1bFxZaEzFpYkz1rBLvb8p35TCevhtNnE=; b=bs7VKscv4LpqAzGvMQW/52OblzAug0KLRBEwXQ1uiqCBVqp1LZJBaJ64GLH+vLTmGNpwPq JkNSh5FjgSnIaSxBA7LWUthU0lDyWgUiO+ciZwj4+VVc5ERYPtbfCvxlACo4VLJaR3kti8 pkVxbmLtDyFtntgnyE4vzwFZWk5rLeA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-jzMAIeTdMXqsSSmdwYR3nw-1; Mon, 19 Feb 2024 10:43:36 -0500 X-MC-Unique: jzMAIeTdMXqsSSmdwYR3nw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DFDCA101A52A; Mon, 19 Feb 2024 15:43:35 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE1B6C185C0; Mon, 19 Feb 2024 15:43:35 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9547F21E6740; Mon, 19 Feb 2024 16:43:33 +0100 (CET) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: yong.huang@smartx.com, qemu-devel@nongnu.org, Eric Blake , Hanna Reitz , Kevin Wolf Subject: Re: [PATCH v4 4/7] block: Support detached LUKS header creation using blockdev-create In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Mon, 19 Feb 2024 14:57:13 +0000") References: <9e35e621f12478822072e5c740ed65beb77f1238.1706586786.git.yong.huang@smartx.com> <87v86kjzwb.fsf@pond.sub.org> <87ttm4ik5h.fsf@pond.sub.org> Date: Mon, 19 Feb 2024 16:43:33 +0100 Message-ID: <87le7gh32y.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.072, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: [...] > TL;DR: the @detached-header field needs to go, as that's supposed to > be internal only. The mgmt app should only care about 'header' in the > BlockdevCreateOptionsLUKS struct. > > FYI, this whole series is already merged last week. So this will need > a fixup. I'll look into it now. Glad I neglected to check for a merge, because if I had, I wouldn't have looked at the schema :) My apologies for looking so late! [...]