From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: Xinliang Liu <xinliang.liu@linaro.org>,
John Stultz <jstultz@google.com>,
Xinwei Kong <kong.kongxinwei@hisilicon.com>,
Yongqin Liu <yongqin.liu@linaro.org>,
Tian Tao <tiantao6@hisilicon.com>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [PATCH] drm/hisilicon: include drm/drm_edid.h only where needed
Date: Tue, 19 Dec 2023 14:13:40 +0200 [thread overview]
Message-ID: <87le9qtmob.fsf@intel.com> (raw)
In-Reply-To: <20231212142530.3826692-1-jani.nikula@intel.com>
On Tue, 12 Dec 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> Reduce the need for rebuilds when drm_edid.h is modified by including it
> only where needed.
Ping?
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 -
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
> index f957552c6c50..207aa3f660b0 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
> @@ -18,7 +18,6 @@
> #include <linux/i2c-algo-bit.h>
> #include <linux/i2c.h>
>
> -#include <drm/drm_edid.h>
> #include <drm/drm_framebuffer.h>
>
> struct hibmc_connector {
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> index 8c6d2ea2a472..94e2c573a7af 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> @@ -14,6 +14,7 @@
> #include <linux/io.h>
>
> #include <drm/drm_atomic_helper.h>
> +#include <drm/drm_edid.h>
> #include <drm/drm_probe_helper.h>
> #include <drm/drm_print.h>
> #include <drm/drm_simple_kms_helper.h>
--
Jani Nikula, Intel
prev parent reply other threads:[~2023-12-19 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 14:25 [PATCH] drm/hisilicon: include drm/drm_edid.h only where needed Jani Nikula
2023-12-19 12:13 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le9qtmob.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jstultz@google.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=sumit.semwal@linaro.org \
--cc=tiantao6@hisilicon.com \
--cc=xinliang.liu@linaro.org \
--cc=yongqin.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.