From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 100F5C4167B for ; Mon, 4 Dec 2023 07:38:37 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F404B843; Mon, 4 Dec 2023 08:38:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F404B843 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1701675516; bh=O1mau4JypPyy1TAttZ7psnBfiDM76Cr97cR93Yo8pDs=; h=References:From:To:Cc:Subject:Date:In-reply-to:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=aNxeIKjJ/loM/joYbZlm0fRa3E20NN3W1T7f0LmIFlUa0w60WNUGMmoHd31qM4xCk HsbfjE4g/GROcKqoOFCbGa+70+2IbYn5FQmt6FwVEt3QetEjyAekA/gcSk+49CDLeq rprbqXORrCGrOceqWNVL2C+Adm7ctxZU+usbETIY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id B38D2F805AA; Mon, 4 Dec 2023 08:37:46 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id C6BE2F805D2; Mon, 4 Dec 2023 08:37:45 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9FA4CF80104; Mon, 27 Nov 2023 16:23:38 +0100 (CET) Received: from smtp.livemail.co.uk (smtp-out-60.livemail.co.uk [213.171.216.60]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BD611F80104 for ; Mon, 27 Nov 2023 16:23:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BD611F80104 Received: from laptop (host-78-146-56-151.as13285.net [78.146.56.151]) (Authenticated sender: malcolm@5harts.com) by smtp.livemail.co.uk (Postfix) with ESMTPSA id C6E1BC5A22; Mon, 27 Nov 2023 15:23:30 +0000 (GMT) References: User-agent: mu4e 1.8.15; emacs 29.1 From: Malcolm Hart To: Mark Brown Cc: Sven Frotscher , git@augustwikerfors.se, alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, mario.limonciello@amd.com, regressions@lists.linux.dev, stable@vger.kernel.org Subject: Re: ASoC: amd: yc: Fix non-functional mic on ASUS E1504FA Date: Mon, 27 Nov 2023 15:23:08 +0000 In-reply-to: Message-ID: <87leajgqz1.fsf@5harts.com> MIME-Version: 1.0 Content-Type: text/plain X-MailFrom: malcolm@5harts.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: W7OIN2YRQV6R7Q7NJTEM7U4ZHY3OJHKT X-Message-ID-Hash: W7OIN2YRQV6R7Q7NJTEM7U4ZHY3OJHKT X-Mailman-Approved-At: Mon, 04 Dec 2023 07:34:26 +0000 X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: >>From da1e023a39987c1bc2d5b27ecf659d61d9a4724c Mon Sep 17 00:00:00 2001 From: foolishhart <62256078+foolishhart@users.noreply.github.com> Date: Mon, 27 Nov 2023 11:51:04 +0000 Subject: [PATCH] Update acp6x-mach.c Added ASUSTeK COMPUTER INC "E1504FA" to quirks file to enable microphone array on ASUS Vivobook GO 15. --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 15a864dcd7bd3a..3babb17a56bb55 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "E1504FA"), + } + }, { .driver_data = &acp6x_card, .matches = { Mark Brown writes: > [[PGP Signed Part:Undecided]] > On Mon, Nov 27, 2023 at 12:24:59PM +0000, Malcolm Hart wrote: >> Like other ASUS models the Asus Vivobook E1504FA requires an entry in >> the quirk list to enable the internal microphone. >> >> Showing >> with 7 additions and 0 deletions. >> 7 changes: 7 additions & 0 deletions 7 >> sound/soc/amd/yc/acp6x-mach.c >> @@ -283,6 +283,13 @@ static const struct dmi_system_id >> yc_acp_quirk_table[] = { > > The patch appears to have been unusably corrupted by your e-mail > software and is also missing a Signed-off-by. See email-cleints.rst for > some suggestions on configuring things, or it might be worth looking > into b4 and it's web submission endpoint: > > https://b4.docs.kernel.org/en/latest/ > > [[End of PGP Signed Part]] From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.livemail.co.uk (smtp-out-60.livemail.co.uk [213.171.216.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 436DE31A8E for ; Mon, 27 Nov 2023 15:23:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=5harts.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=5harts.com Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from laptop (host-78-146-56-151.as13285.net [78.146.56.151]) (Authenticated sender: malcolm@5harts.com) by smtp.livemail.co.uk (Postfix) with ESMTPSA id C6E1BC5A22; Mon, 27 Nov 2023 15:23:30 +0000 (GMT) References: User-agent: mu4e 1.8.15; emacs 29.1 From: Malcolm Hart To: Mark Brown Cc: Sven Frotscher , git@augustwikerfors.se, alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, mario.limonciello@amd.com, regressions@lists.linux.dev, stable@vger.kernel.org Subject: Re: ASoC: amd: yc: Fix non-functional mic on ASUS E1504FA Date: Mon, 27 Nov 2023 15:23:08 +0000 In-reply-to: Message-ID: <87leajgqz1.fsf@5harts.com> Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain >From da1e023a39987c1bc2d5b27ecf659d61d9a4724c Mon Sep 17 00:00:00 2001 From: foolishhart <62256078+foolishhart@users.noreply.github.com> Date: Mon, 27 Nov 2023 11:51:04 +0000 Subject: [PATCH] Update acp6x-mach.c Added ASUSTeK COMPUTER INC "E1504FA" to quirks file to enable microphone array on ASUS Vivobook GO 15. --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 15a864dcd7bd3a..3babb17a56bb55 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "E1504FA"), + } + }, { .driver_data = &acp6x_card, .matches = { Mark Brown writes: > [[PGP Signed Part:Undecided]] > On Mon, Nov 27, 2023 at 12:24:59PM +0000, Malcolm Hart wrote: >> Like other ASUS models the Asus Vivobook E1504FA requires an entry in >> the quirk list to enable the internal microphone. >> >> Showing >> with 7 additions and 0 deletions. >> 7 changes: 7 additions & 0 deletions 7 >> sound/soc/amd/yc/acp6x-mach.c >> @@ -283,6 +283,13 @@ static const struct dmi_system_id >> yc_acp_quirk_table[] = { > > The patch appears to have been unusably corrupted by your e-mail > software and is also missing a Signed-off-by. See email-cleints.rst for > some suggestions on configuring things, or it might be worth looking > into b4 and it's web submission endpoint: > > https://b4.docs.kernel.org/en/latest/ > > [[End of PGP Signed Part]]