From: "Toke Høiland-Jørgensen" <toke@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>, bpf@vger.kernel.org
Cc: netdev@vger.kernel.org, martin.lau@linux.dev,
razor@blackwall.org, ast@kernel.org, andrii@kernel.org,
john.fastabend@gmail.com, sdf@google.com,
Daniel Borkmann <daniel@iogearbox.net>,
Quentin Monnet <quentin@isovalent.com>
Subject: Re: [PATCH bpf-next v2 4/7] bpftool: Implement link show support for netkit
Date: Mon, 23 Oct 2023 16:26:37 +0200 [thread overview]
Message-ID: <87lebtqusi.fsf@toke.dk> (raw)
In-Reply-To: <20231019204919.4203-5-daniel@iogearbox.net>
Daniel Borkmann <daniel@iogearbox.net> writes:
> Add support to dump netkit link information to bpftool in similar way as
> we have for XDP. The netkit link info only exposes the ifindex.
>
> Below shows an example link dump output, and a cgroup link is included for
> comparison, too:
>
> # bpftool link
> [...]
> 10: cgroup prog 2466
> cgroup_id 1 attach_type cgroup_inet6_post_bind
> [...]
> 8: netkit prog 35
> ifindex nk1(18)
> [...]
Couldn't we make this show whether the program is attached as
primary/peer as well? Seems like that would be useful (like in the
cgroup output above)?
-Toke
next prev parent reply other threads:[~2023-10-23 14:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 20:49 [PATCH bpf-next v2 0/7] Add bpf programmable net device Daniel Borkmann
2023-10-19 20:49 ` [PATCH bpf-next v2 1/7] netkit, bpf: " Daniel Borkmann
2023-10-20 22:18 ` Andrew Lunn
2023-10-20 22:38 ` Daniel Borkmann
2023-10-21 1:43 ` Jakub Kicinski
2023-10-21 1:41 ` Jakub Kicinski
2023-10-19 20:49 ` [PATCH bpf-next v2 2/7] tools: Sync if_link uapi header Daniel Borkmann
2023-10-19 20:49 ` [PATCH bpf-next v2 3/7] libbpf: Add link-based API for netkit Daniel Borkmann
2023-10-19 20:49 ` [PATCH bpf-next v2 4/7] bpftool: Implement link show support " Daniel Borkmann
2023-10-23 14:26 ` Toke Høiland-Jørgensen [this message]
2023-10-23 14:46 ` Daniel Borkmann
2023-10-19 20:49 ` [PATCH bpf-next v2 5/7] bpftool: Extend net dump with netkit progs Daniel Borkmann
2023-10-19 20:49 ` [PATCH bpf-next v2 6/7] selftests/bpf: Add netlink helper library Daniel Borkmann
2023-10-19 20:49 ` [PATCH bpf-next v2 7/7] selftests/bpf: Add selftests for netkit Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lebtqusi.fsf@toke.dk \
--to=toke@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=razor@blackwall.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.