From: Jani Nikula <jani.nikula@intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [RFC PATCH 0/4] Framework for display parameters
Date: Thu, 05 Oct 2023 15:52:51 +0300 [thread overview]
Message-ID: <87lechcjto.fsf@intel.com> (raw)
In-Reply-To: <20231005054500.2053070-1-jouni.hogander@intel.com>
On Thu, 05 Oct 2023, Jouni Högander <jouni.hogander@intel.com> wrote:
> Currently all module parameters are handled by i915_param.c/h. This
> is a problem for display parameters when Xe driver is used.
>
> This patch set adds a mechanism to add parameters specific to the
> display. This is mainly copied from existing i915 parameters
> implementation with some naming changes and taking into account
> varying driver name.
>
> Also fbc and psr related parameter are moved as an example.
Added some more Cc's as FYI.
It's not perfect, but I'm okay with the general approach. I've hoped for
a beautiful solution to the problem, but hopes don't turn into code.
I'll reply with some bikeshedding comments to the individual patches.
BR,
Jani.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Jouni Högander (4):
> drm/i915/display: Add framework to add parameters specific to display
> drm/i915/display: Dump also display parameters into GPU error dump
> drm/i915/display: Move enable_fbc module parameter under display
> drm/i915/display: Move psr related module parameters under display
>
> drivers/gpu/drm/i915/Makefile | 2 +
> drivers/gpu/drm/i915/display/i9xx_wm.c | 2 +-
> .../gpu/drm/i915/display/intel_display_core.h | 2 +
> .../drm/i915/display/intel_display_debugfs.c | 2 +
> .../display/intel_display_debugfs_params.c | 239 ++++++++++++++++++
> .../display/intel_display_debugfs_params.h | 14 +
> .../drm/i915/display/intel_display_device.c | 8 +
> .../drm/i915/display/intel_display_device.h | 1 +
> .../drm/i915/display/intel_display_params.c | 166 ++++++++++++
> .../drm/i915/display/intel_display_params.h | 65 +++++
> drivers/gpu/drm/i915/display/intel_fbc.c | 10 +-
> drivers/gpu/drm/i915/display/intel_psr.c | 14 +-
> drivers/gpu/drm/i915/i915_driver.c | 2 +
> drivers/gpu/drm/i915/i915_gpu_error.c | 3 +
> drivers/gpu/drm/i915/i915_gpu_error.h | 2 +
> drivers/gpu/drm/i915/i915_params.c | 19 --
> drivers/gpu/drm/i915/i915_params.h | 4 -
> 17 files changed, 519 insertions(+), 36 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/display/intel_display_debugfs_params.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_display_debugfs_params.h
> create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.h
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-10-05 12:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 5:44 [Intel-gfx] [RFC PATCH 0/4] Framework for display parameters Jouni Högander
2023-10-05 5:44 ` [Intel-gfx] [RFC PATCH 1/4] drm/i915/display: Add framework to add parameters specific to display Jouni Högander
2023-10-05 13:03 ` Jani Nikula
2023-10-05 5:44 ` [Intel-gfx] [RFC PATCH 2/4] drm/i915/display: Dump also display parameters into GPU error dump Jouni Högander
2023-10-05 5:44 ` [Intel-gfx] [RFC PATCH 3/4] drm/i915/display: Move enable_fbc module parameter under display Jouni Högander
2023-10-05 5:45 ` [Intel-gfx] [RFC PATCH 4/4] drm/i915/display: Move psr related module parameters " Jouni Högander
2023-10-05 6:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Framework for display parameters Patchwork
2023-10-05 6:17 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-05 6:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-05 12:52 ` Jani Nikula [this message]
2023-10-05 13:53 ` [Intel-gfx] [RFC PATCH 0/4] " Tvrtko Ursulin
2023-10-05 16:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lechcjto.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.