From: Petr Machata <me@pmachata.org>
To: Zahari Doychev <zahari.doychev@linux.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com,
stephen@networkplumber.org, hmehrtens@maxlinear.com,
aleksander.lobakin@intel.com, simon.horman@corigine.com,
idosch@idosch.org, Zahari Doychev <zdoychev@maxlinear.com>
Subject: Re: [PATCH iproute2-next] f_flower: simplify cfm dump function
Date: Fri, 30 Jun 2023 13:22:45 +0200 [thread overview]
Message-ID: <87leg1xkax.fsf@nvidia.com> (raw)
In-Reply-To: <20230629195736.675018-1-zahari.doychev@linux.com>
Zahari Doychev <zahari.doychev@linux.com> writes:
> From: Zahari Doychev <zdoychev@maxlinear.com>
>
> The standard print function can be used to print the cfm attributes in
> both standard and json use cases. In this way no string buffer is needed
> which simplifies the code.
This looks correct, but please make sure that the diff between the old
and the new way is empty in both JSON and FP mode.
> Signed-off-by: Zahari Doychev <zdoychev@maxlinear.com>
Reviewed-by: Petr Machata <me@pmachata.org>
next prev parent reply other threads:[~2023-06-30 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 19:57 [PATCH iproute2-next] f_flower: simplify cfm dump function Zahari Doychev
2023-06-30 11:22 ` Petr Machata [this message]
2023-06-30 19:37 ` Zahari Doychev
2023-06-30 21:17 ` Stephen Hemminger
2023-07-03 8:01 ` Ido Schimmel
2023-07-03 16:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leg1xkax.fsf@nvidia.com \
--to=me@pmachata.org \
--cc=aleksander.lobakin@intel.com \
--cc=dsahern@gmail.com \
--cc=hmehrtens@maxlinear.com \
--cc=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
--cc=stephen@networkplumber.org \
--cc=zahari.doychev@linux.com \
--cc=zdoychev@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.