From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] HID: shield: Initial driver implementation with Thunderstrike support
Date: Thu, 13 Apr 2023 23:47:26 -0700 [thread overview]
Message-ID: <87leivhse9.fsf@nvidia.com> (raw)
In-Reply-To: <20230413151621.py34io57wcrfofo2@mail.corp.redhat.com> (Benjamin Tissoires's message of "Thu, 13 Apr 2023 17:16:21 +0200")
On Thu, 13 Apr, 2023 17:16:21 +0200 Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote:
> Hi,
>
> On Apr 10 2023, Rahul Rameshbabu wrote:
>> Supports the Thunderstrike (SHIELD 2017) controller. Implements support for
>> the Thunderstrike HOSTCMD firmware interface. Adds sysfs attributes about a
>> SHIELD device and introduces haptics support for controllers.
>>
>> Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
>> ---
>> MAINTAINERS | 6 +
>> drivers/hid/Kconfig | 18 ++
>> drivers/hid/Makefile | 1 +
>> drivers/hid/hid-ids.h | 3 +
>> drivers/hid/hid-shield.c | 587 +++++++++++++++++++++++++++++++++++++++
>
> In addition to what Jiri said, would you mind changing the name to
> hid-nvidia-shield.c or just hid-nvidia.c?
> The "normal" naming scheme in the hid tree is to group devices by
> vendors, and TBH, knowing that the "shield" is from Nvidia is not
> necessarily obvious.
Ack. I will make the change to hid-nvidia.c in my next submission of
this patch.
>
> Cheers,
> Benjamin
>
prev parent reply other threads:[~2023-04-14 6:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 17:08 [PATCH v2 0/1] HID: shield Rahul Rameshbabu
2023-04-10 17:08 ` [PATCH v2 1/1] HID: shield: Initial driver implementation with Thunderstrike support Rahul Rameshbabu
2023-04-13 15:07 ` Jiri Kosina
2023-04-14 7:09 ` Rahul Rameshbabu
2023-04-14 14:12 ` Jiri Kosina
2023-04-13 15:16 ` Benjamin Tissoires
2023-04-14 6:47 ` Rahul Rameshbabu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leivhse9.fsf@nvidia.com \
--to=rrameshbabu@nvidia.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.