From: Fabiano Rosas <farosas@suse.de>
To: "Nicholas Piggin" <npiggin@gmail.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Cc: danielhb413@gmail.com, david@gibson.dropbear.id.au,
groug@kaod.org, qemu-ppc@nongnu.org,
Anton Johansson <anjo@rev.ng>
Subject: Re: [PATCH for-8.0 v2] target/ppc: Fix temp usage in gen_op_arith_modw
Date: Mon, 10 Apr 2023 09:50:28 -0300 [thread overview]
Message-ID: <87leizkijv.fsf@suse.de> (raw)
In-Reply-To: <CRRV3SRW7H2U.14JIRTJFPXRSU@wheely>
"Nicholas Piggin" <npiggin@gmail.com> writes:
> On Sun Apr 9, 2023 at 7:24 AM AEST, Cédric Le Goater wrote:
>> On 4/8/23 09:05, Richard Henderson wrote:
>> > Fix a crash writing to 't3', which is now a constant.
>> > Instead, write the result of the remu to 't1'.
>> >
>> > Fixes: 7058ff5231a ("target/ppc: Avoid tcg_const_* in translate.c")
>> > Reported-by: Nicholas Piggin <npiggin@gmail.com>
>> > Reviewed-by: Anton Johansson <anjo@rev.ng>
>> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>>
>> Looks good:
>>
>> https://gitlab.com/legoater/qemu/-/pipelines/831847446
>>
>> I have a PR ready for this same branch. If you want to me send,
>> just tell.
>
> Thanks Richard and Cedric. LGTM.
>
>> I don't think we have tcg tests for the prefix or mma instructions
>> introduced in P10. That would be good to have.
>
> I agree, we need to do a bit better on ppc.
>
> I'm trying to get a handle on all the tests we have for these things,
> I haven't looked too closely before. kvm-unit-tests actually works
> well for TCG and I did find some (system level) prefix issues with it.
> I don't know if that's the right place to focus on instruction level
> testing though. QEMU's tcg tests sounds like a better place for it,
> but is it only for userspace tests?
Last time we looked at adding softmmu to the tests:
https://lore.kernel.org/all/20220324190854.156898-1-leandro.lupori@eldorado.org.br/
next prev parent reply other threads:[~2023-04-10 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 7:05 [PATCH for-8.0 v2] target/ppc: Fix temp usage in gen_op_arith_modw Richard Henderson
2023-04-08 21:24 ` Cédric Le Goater
2023-04-09 2:16 ` Nicholas Piggin
2023-04-10 12:50 ` Fabiano Rosas [this message]
2023-04-09 16:21 ` Richard Henderson
2023-04-09 17:29 ` Cédric Le Goater
2023-04-09 18:08 ` Richard Henderson
2023-04-10 11:30 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leizkijv.fsf@suse.de \
--to=farosas@suse.de \
--cc=anjo@rev.ng \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.