All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Martin Kaistra <martin.kaistra@linutronix.de>,
	"linux-wireless\@vger.kernel.org"
	<linux-wireless@vger.kernel.org>,
	Jes Sorensen <Jes.Sorensen@gmail.com>,
	Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [RFC PATCH 07/14] wifi: rtl8xxxu: Add parameter macid to update_rate_mask
Date: Mon, 27 Mar 2023 11:41:32 +0300	[thread overview]
Message-ID: <87lejitwlf.fsf@kernel.org> (raw)
In-Reply-To: <b48af4c2e9ef4555997b4a6388fdd270@realtek.com> (Ping-Ke Shih's message of "Mon, 27 Mar 2023 01:48:06 +0000")

Ping-Ke Shih <pkshih@realtek.com> writes:

>> -----Original Message-----
>> From: Martin Kaistra <martin.kaistra@linutronix.de>
>> Sent: Thursday, March 23, 2023 1:19 AM
>> To: linux-wireless@vger.kernel.org
>> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Kalle Valo <kvalo@kernel.org>; Ping-Ke Shih
>> <pkshih@realtek.com>; Bitterblue Smith <rtl8821cerfe2@gmail.com>; Sebastian Andrzej Siewior
>> <bigeasy@linutronix.de>
>> Subject: [RFC PATCH 07/14] wifi: rtl8xxxu: Add parameter macid to update_rate_mask
>> 
>> The HW maintains a rate_mask for each connection, referenced by the
>> macid. Add a parameter to update_rate_mask and add the macid to the
>> h2c call in the gen2 implementation.
>> 
>> Also extend refresh_rate_mask to generate the macid in AP mode from
>> sta->aid.
>
> Firmware can support 32 mac_id (station instance) at most, so it will be a
> problem if hostapd assigns aid more than 32. Though I'm not clear how
> hostpad assigns the aid, it would be always safe that rtl8xxxu maintains
> mac_id by a bitmap in driver.

Does rtlw8xxxu set struct wiphy::max_ap_assoc_sta? It would be good to
advertise the user space the maximum number of stations.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-03-27  8:46 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 17:18 [RFC PATCH 00/14] wifi: rtl8xxxu: Add AP mode support for 8188f Martin Kaistra
2023-03-22 17:18 ` [RFC PATCH 01/14] wifi: rtl8xxxu: Add start_ap() callback Martin Kaistra
2023-03-27  0:46   ` Ping-Ke Shih
2023-03-27 13:10   ` Bitterblue Smith
2023-03-27 16:08     ` Martin Kaistra
2023-03-27 18:29       ` Bitterblue Smith
2023-03-29  0:18         ` Ping-Ke Shih
2023-03-22 17:18 ` [RFC PATCH 02/14] wifi: rtl8xxxu: Select correct queue for beacon frames Martin Kaistra
2023-03-27  0:51   ` Ping-Ke Shih
2023-03-22 17:18 ` [RFC PATCH 03/14] wifi: rtl8xxxu: Add beacon functions Martin Kaistra
2023-03-27  1:19   ` Ping-Ke Shih
2023-03-27 13:10   ` Bitterblue Smith
2023-03-22 17:18 ` [RFC PATCH 04/14] wifi: rtl8xxxu: Add set_tim() callback Martin Kaistra
2023-03-27  1:20   ` Ping-Ke Shih
2023-03-22 17:18 ` [RFC PATCH 05/14] wifi: rtl8xxxu: Allow setting rts threshold to -1 Martin Kaistra
2023-03-27  1:21   ` Ping-Ke Shih
2023-03-22 17:18 ` [RFC PATCH 06/14] wifi: rtl8xxxu: Allow creating interface in AP mode Martin Kaistra
2023-03-27  1:39   ` Ping-Ke Shih
2023-03-27 13:15     ` Martin Kaistra
2023-03-22 17:18 ` [RFC PATCH 07/14] wifi: rtl8xxxu: Add parameter macid to update_rate_mask Martin Kaistra
2023-03-27  1:48   ` Ping-Ke Shih
2023-03-27  8:41     ` Kalle Valo [this message]
2023-03-27  9:19       ` Ping-Ke Shih
2023-03-27 13:12         ` Bitterblue Smith
2023-03-22 17:18 ` [RFC PATCH 08/14] wifi: rtl8xxxu: Actually use macid in rtl8xxxu_gen2_report_connect Martin Kaistra
2023-03-27  1:48   ` Ping-Ke Shih
2023-03-22 17:19 ` [RFC PATCH 09/14] wifi: rtl8xxxu: Add parameter role to report_connect Martin Kaistra
2023-03-27  1:54   ` Ping-Ke Shih
2023-03-27 13:11   ` Bitterblue Smith
2023-03-22 17:19 ` [RFC PATCH 10/14] wifi: rtl8xxxu: Add sta_add() callback Martin Kaistra
2023-03-27  1:56   ` Ping-Ke Shih
2023-03-22 17:19 ` [RFC PATCH 11/14] wifi: rtl8xxxu: Put the macid in txdesc Martin Kaistra
2023-03-27  1:58   ` Ping-Ke Shih
2023-03-27 13:11   ` Bitterblue Smith
2023-03-22 17:19 ` [RFC PATCH 12/14] wifi: rtl8xxxu: Enable hw seq for all non-qos frames Martin Kaistra
2023-03-27  2:01   ` Ping-Ke Shih
2023-03-22 17:19 ` [RFC PATCH 13/14] wifi: rtl8xxxu: Clean up filter configuration Martin Kaistra
2023-03-27  2:06   ` Ping-Ke Shih
2023-03-28 14:47     ` Martin Kaistra
2023-03-29  0:27       ` Ping-Ke Shih
2023-03-22 17:19 ` [RFC PATCH 14/14] wifi: rtl8xxxu: Declare AP mode support for 8188f Martin Kaistra
2023-03-27  2:06   ` Ping-Ke Shih
2023-03-23 17:12 ` [RFC PATCH 00/14] wifi: rtl8xxxu: Add " Bitterblue Smith
2023-03-27  7:58   ` Martin Kaistra
2023-04-05 15:31   ` Martin Kaistra
2023-04-06  0:42     ` Ping-Ke Shih
2023-04-06 15:09       ` Martin Kaistra
2023-04-09 12:41         ` Bitterblue Smith
2023-04-12 10:02           ` Martin Kaistra
2023-04-14 21:49             ` Bitterblue Smith
2023-04-07  1:18     ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lejitwlf.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=Jes.Sorensen@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=martin.kaistra@linutronix.de \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.