From: Juan Quintela <quintela@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Peter Xu <peterx@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Michal Privoznik <mprivozn@redhat.com>
Subject: Re: [PATCH v5 6/8] virtio-mem: Fail if a memory backend with "prealloc=on" is specified
Date: Thu, 02 Feb 2023 12:52:37 +0100 [thread overview]
Message-ID: <87lelgnv22.fsf@secure.mitica> (raw)
In-Reply-To: <20230117112249.244096-7-david@redhat.com> (David Hildenbrand's message of "Tue, 17 Jan 2023 12:22:47 +0100")
David Hildenbrand <david@redhat.com> wrote:
> "prealloc=on" for the memory backend does not work as expected, as
> virtio-mem will simply discard all preallocated memory immediately again.
> In the best case, it's an expensive NOP. In the worst case, it's an
> unexpected allocation error.
>
> Instead, "prealloc=on" should be specified for the virtio-mem device only,
> such that virtio-mem will try preallocating memory before plugging
> memory dynamically to the guest. Fail if such a memory backend is
> provided.
>
> Tested-by: Michal Privoznik <mprivozn@redhat.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2023-02-02 11:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 11:22 [PATCH v5 0/8] virtio-mem: Handle preallocation with migration David Hildenbrand
2023-01-17 11:22 ` [PATCH v5 1/8] migration/savevm: Move more savevm handling into vmstate_save() David Hildenbrand
2023-02-02 11:46 ` Juan Quintela
2023-01-17 11:22 ` [PATCH v5 2/8] migration/savevm: Prepare vmdesc json writer in qemu_savevm_state_setup() David Hildenbrand
2023-02-02 11:48 ` Juan Quintela
2023-01-17 11:22 ` [PATCH v5 3/8] migration/savevm: Allow immutable device state to be migrated early (i.e., before RAM) David Hildenbrand
2023-02-02 11:49 ` Juan Quintela
2023-01-17 11:22 ` [PATCH v5 4/8] migration/vmstate: Introduce VMSTATE_WITH_TMP_TEST() and VMSTATE_BITMAP_TEST() David Hildenbrand
2023-02-02 11:50 ` Juan Quintela
2023-01-17 11:22 ` [PATCH v5 5/8] migration/ram: Factor out check for advised postcopy David Hildenbrand
2023-02-02 11:51 ` Juan Quintela
2023-01-17 11:22 ` [PATCH v5 6/8] virtio-mem: Fail if a memory backend with "prealloc=on" is specified David Hildenbrand
2023-02-02 11:52 ` Juan Quintela [this message]
2023-01-17 11:22 ` [PATCH v5 7/8] virtio-mem: Migrate immutable properties early David Hildenbrand
2023-02-02 11:54 ` Juan Quintela
2023-01-17 11:22 ` [PATCH v5 8/8] virtio-mem: Proper support for preallocation with migration David Hildenbrand
2023-02-02 11:56 ` Juan Quintela
2023-01-17 15:40 ` [PATCH v5 0/8] virtio-mem: Handle " Peter Xu
2023-01-23 14:27 ` David Hildenbrand
2023-02-02 11:04 ` Juan Quintela
2023-02-02 12:58 ` David Hildenbrand
2023-02-02 11:11 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lelgnv22.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mprivozn@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.