From: "Alex Bennée" <alex.bennee@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] tests/tcg/s390x: Use -nostdlib for softmmu tests
Date: Tue, 31 Jan 2023 18:41:51 +0000 [thread overview]
Message-ID: <87lelitukj.fsf@linaro.org> (raw)
In-Reply-To: <20230131182057.2261614-1-iii@linux.ibm.com>
Ilya Leoshkevich <iii@linux.ibm.com> writes:
> The code currently uses -nostartfiles, but this does not prevent
> linking with libc. On Fedora there is no cross-libc, so the linking
> step fails.
>
> Fix by using the more comprehensive -nostdlib (that's also what
> probe_target_compiler() checks for as well).
>
> Fixes: 503e549e441e ("tests/tcg/s390x: Test unaligned accesses to lowcore")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> tests/tcg/s390x/Makefile.softmmu-target | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tcg/s390x/Makefile.softmmu-target b/tests/tcg/s390x/Makefile.softmmu-target
> index a34fa68473e..50c1b88065d 100644
> --- a/tests/tcg/s390x/Makefile.softmmu-target
> +++ b/tests/tcg/s390x/Makefile.softmmu-target
> @@ -3,7 +3,7 @@ VPATH+=$(S390X_SRC)
> QEMU_OPTS=-action panic=exit-failure -kernel
>
> %: %.S
> - $(CC) -march=z13 -m64 -nostartfiles -static -Wl,-Ttext=0 \
> + $(CC) -march=z13 -m64 -nostdlib -static -Wl,-Ttext=0 \
> -Wl,--build-id=none $< -o $@
>
> TESTS += unaligned-lowcore
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
I take it this will go via the s390x tree?
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-01-31 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 18:20 [PATCH] tests/tcg/s390x: Use -nostdlib for softmmu tests Ilya Leoshkevich
2023-01-31 18:28 ` Richard Henderson
2023-01-31 18:41 ` Alex Bennée [this message]
2023-02-01 11:06 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lelitukj.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.