From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65D00C25B4E for ; Tue, 24 Jan 2023 11:50:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232656AbjAXLuT (ORCPT ); Tue, 24 Jan 2023 06:50:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233205AbjAXLuL (ORCPT ); Tue, 24 Jan 2023 06:50:11 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 397E63B674 for ; Tue, 24 Jan 2023 03:49:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674560968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E+8CpAUiEMzDSueeZ/CcPXedjzkC+Vhi6CdGhcnqLlw=; b=gIm/tTjxeV8ig/L29V/ibTyQWLlQtGj9H6Z6PpehbYDPdm6eMAGJy/0CGy96zXij03PA0R 1EwSgWyy/TEGTfSOv6ChvdbIk0T88G0DB4I9iDPwqYC4noc3aDSAVs3E+aGmAXSwI/1hjm UYd2OHfFQkzH7px8HshaDWUiZG9kcEw= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-25-wteCR9rcNf-3J8grbmzy1Q-1; Tue, 24 Jan 2023 06:49:27 -0500 X-MC-Unique: wteCR9rcNf-3J8grbmzy1Q-1 Received: by mail-ed1-f70.google.com with SMTP id v8-20020a056402348800b0049e1913bd43so10691546edc.20 for ; Tue, 24 Jan 2023 03:49:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E+8CpAUiEMzDSueeZ/CcPXedjzkC+Vhi6CdGhcnqLlw=; b=6aekZlJW4Sxj5twL9BrDIkPKFtV0m8d2m+cGFbMb5L7sY+iLoQjp58FxBCzPI9Rh11 gCROqdZcV/wW3Ychesmskb1bRXx8auVPWZhzjTg5eLle1A20AcD7I5pWIlZnrKIpYGTJ 1WotOvpl7yAXY6YknUYOZC9NbpUNz0GupdB/1zUd17kP8pFfTCobFcqkC5wLLtPc1VD3 gyS7r0hUsSWn6s9k4dMQgEwUmuBpRidsmTnkUvlcQy630V74iExWRW6Yo8GoHXFlhkde kdn5qe15LFWz6BrbNYXvICh+4NeScmmHXJA8wBfu6SLIZpkjIbPi8+BFWYfMH5HyQqqn BRVg== X-Gm-Message-State: AFqh2krc5tJbrx0ak9qEQC0SBSkNWBHn1UsdzUI7IOlf+PRFIdyBb6Nz qBsdJCres4cdnfF696/L5NucFzv7QxHazN/AO8VLzuYuDbe7RGJnwGd2Ynend1yz0s2wwGcKWsj WtkePSrBBuXWR X-Received: by 2002:a17:906:4e09:b0:86f:2cc2:7029 with SMTP id z9-20020a1709064e0900b0086f2cc27029mr28409515eju.38.1674560965314; Tue, 24 Jan 2023 03:49:25 -0800 (PST) X-Google-Smtp-Source: AMrXdXuFW42pOrJS5TdgBDaQkg1EwxDSUf3jHUle3aR/jouGbhcEhzEDRCQA583LajKdODxHNXcZZQ== X-Received: by 2002:a17:906:4e09:b0:86f:2cc2:7029 with SMTP id z9-20020a1709064e0900b0086f2cc27029mr28409417eju.38.1674560964159; Tue, 24 Jan 2023 03:49:24 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id vt4-20020a170907a60400b007e0e2e35205sm810924ejc.143.2023.01.24.03.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 03:49:23 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id E30DB942AEF; Tue, 24 Jan 2023 12:49:22 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Alexander Lobakin , Stanislav Fomichev Cc: Martin KaFai Lau , ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [xdp-hints] Re: [PATCH bpf-next v8 00/17] xdp: hints via kfuncs In-Reply-To: <5b757a2a-86a7-346c-4493-9ab903de19e4@intel.com> References: <20230119221536.3349901-1-sdf@google.com> <901e1a7a-bb86-8d62-4bd7-512a1257d3b0@linux.dev> <5b757a2a-86a7-346c-4493-9ab903de19e4@intel.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 24 Jan 2023 12:49:22 +0100 Message-ID: <87lelsp2yl.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Alexander Lobakin writes: > From: Stanislav Fomichev > Date: Mon, 23 Jan 2023 10:55:52 -0800 > >> On Mon, Jan 23, 2023 at 10:53 AM Martin KaFai Lau wrote: >>> >>> On 1/19/23 2:15 PM, Stanislav Fomichev wrote: >>>> Please see the first patch in the series for the overall >>>> design and use-cases. >>>> >>>> See the following email from Toke for the per-packet metadata overhead: >>>> https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798 >>>> >>>> Recent changes: >>>> - Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops' (Tariq) >>>> >>>> - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq) >>>> >>>> - Clarify xdp_buff vs 'XDP frame' (Jesper) >>>> >>>> - Explicitly mention that AF_XDP RX descriptor lacks metadata size (Jesper) >>>> >>>> - Drop libbpf_flags/xdp_flags from selftests and use ifindex instead >>>> of ifname (due to recent xsk.h refactoring) >>> >>> Applied with the minor changes in the selftests discussed in patch 11 and 17. >>> Thanks! >> >> Awesome, thanks! I was gonna resend around Wed, but thank you for >> taking care of that! > Great stuff, congrats! :) Yeah! Thanks for carrying this forward, Stanislav! :) -Toke