All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
	Petr Mladek <pmladek@suse.com>,
	Joe Lawrence <joe.lawrence@redhat.com>,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
	Masahiro Yamada <masahiroy@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	linux-modules@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	David Laight <David.Laight@aculab.com>,
	linux-m68k <linux-m68k@lists.linux-m68k.org>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: Re: [PATCH v9] kallsyms: Add self-test facility
Date: Fri, 16 Dec 2022 12:44:16 +0100	[thread overview]
Message-ID: <87len7k1yn.fsf@igel.home> (raw)
In-Reply-To: <CAMuHMdWPSeieR-sGuozd3kWGjVw85EV40irqM9aErXufifzFNA@mail.gmail.com> (Geert Uytterhoeven's message of "Thu, 15 Dec 2022 14:24:51 +0100")

On Dez 15 2022, Geert Uytterhoeven wrote:

> Changing:
>
>     --- a/arch/m68k/include/asm/string.h
>     +++ b/arch/m68k/include/asm/string.h
>     @@ -42,7 +42,7 @@ static inline char *strncpy(char *dest, const
> char *src, size_t n)
>      #define __HAVE_ARCH_STRCMP
>      static inline int strcmp(const char *cs, const char *ct)
>      {
>     -       char res;
>     +       signed char res;
>
>             asm ("\n"
>                     "1:     move.b  (%0)+,%2\n"     /* get *cs */

Note that strcmp needs to compute the return value from the difference
of the _unsigned_ characters.  That does not explain the error, though,
since symbol names don't have characters with the high bit set.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

  parent reply	other threads:[~2022-12-16 11:53 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15  8:33 [PATCH v9] kallsyms: Add self-test facility Zhen Lei
2022-11-15  8:42 ` Luis Chamberlain
2022-11-15  8:43 ` Leizhen (ThunderTown)
2022-11-22 12:29 ` kernel test robot
2022-11-22 13:24   ` Leizhen (ThunderTown)
2022-11-22 15:31 ` kernel test robot
2022-12-15  8:50 ` Geert Uytterhoeven
2022-12-15  9:16   ` Leizhen (ThunderTown)
2022-12-15  9:39     ` Geert Uytterhoeven
2022-12-15 12:33       ` Leizhen (ThunderTown)
2022-12-15 13:24         ` Geert Uytterhoeven
2022-12-15 13:58           ` Leizhen (ThunderTown)
2022-12-15 14:40             ` Leizhen (ThunderTown)
2022-12-15 14:51               ` Geert Uytterhoeven
2022-12-16  7:42                 ` Leizhen (ThunderTown)
2022-12-16  9:36                   ` Leizhen (ThunderTown)
2022-12-16 11:28                     ` Geert Uytterhoeven
2022-12-16 12:01                       ` Leizhen (ThunderTown)
2022-12-16 13:29                         ` David Laight
2022-12-16 14:44                           ` David Laight
2022-12-16 15:19                             ` Andreas Schwab
2022-12-16 15:25                               ` David Laight
2022-12-16 15:54                                 ` Andreas Schwab
2022-12-16 16:09                                   ` David Laight
2022-12-16 16:11                                     ` Andreas Schwab
2022-12-16 16:32                                       ` David Laight
2022-12-16 16:53                                         ` Steven Rostedt
2022-12-16 16:57                                           ` David Laight
2022-12-16 17:19                                             ` Steven Rostedt
2022-12-16 17:38                                               ` Steven Rostedt
2022-12-16 19:27                                                 ` David Laight
2022-12-17  7:31                                                   ` Leizhen (ThunderTown)
2022-12-17 13:37                                                     ` Geert Uytterhoeven
2022-12-17 17:37                                                       ` David Laight
2022-12-16 11:57                     ` Andreas Schwab
2022-12-16 13:31                       ` Leizhen (ThunderTown)
2022-12-16 13:47                         ` Andreas Schwab
2022-12-15 14:43             ` Geert Uytterhoeven
2022-12-15 14:51               ` Andreas Schwab
2022-12-16 10:40           ` David Laight
2022-12-16 11:40             ` Leizhen (ThunderTown)
2022-12-16 11:44           ` Andreas Schwab [this message]
2022-12-16 11:57             ` Leizhen (ThunderTown)
2022-12-16 12:39               ` Andreas Schwab
2022-12-16 13:31                 ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87len7k1yn.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=David.Laight@aculab.com \
    --cc=Jason@zx2c4.com \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mcgrof@kernel.org \
    --cc=mingo@redhat.com \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.