From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 709A7C4332F for ; Wed, 30 Nov 2022 15:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229779AbiK3PeX (ORCPT ); Wed, 30 Nov 2022 10:34:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229718AbiK3PeW (ORCPT ); Wed, 30 Nov 2022 10:34:22 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 424901C921 for ; Wed, 30 Nov 2022 07:34:21 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id bg10so541973wmb.1 for ; Wed, 30 Nov 2022 07:34:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=s9l5W+++EB6NlTNQ2XeW/aJwLvMG4kwDS8FzLeXyfuw=; b=OODKmXJ6crJMlLhh/+vdhA3F4o5MwqA9QOCEg8PrNXZTQAd6n0YodJdRLPkktAA/LR IkRXQjOlFg2XlI/qqufD6xExRdXNDx5cX8Vz/eStqmwfx7wQSbStkDbFNPinHyFpO7fg sD16RdndosM4pWCCIcK3mU7LpNx6CemfLSGP//QW+7MndIjsaqXJm6mg844kP0UQMyGA BxLF+rFPs+K02ivqGesCLhUBmXJRgHQZYNYxtoPSFGsjASuT9ajNQfT3ytLeWxsHWsal ZK7j7jlqB1OlNq/YRMzC11GBtZWlmVg2V+K9+3AGsmzjLj2fZgWT14iNT8byeiqZjYB3 ry2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s9l5W+++EB6NlTNQ2XeW/aJwLvMG4kwDS8FzLeXyfuw=; b=ZsmQdeowFYiGV5r0biQ1/0hIrEmQxOvZMvp7nwmz/qggnYRP+N2NN6H5DZ+h7E3+TM QkKu7zjuo+LOXu34k7t+YvCAdxn2/XjjyMOsmYzwkyEIUTbboWt67H+vuxEfkk7eQyRR 3kcOYI3ABweZCEE7Ec2k9gwkP2Kadu1w6uo0smdf2HWtVoEEUSDLY2PNJFOMIRTC91Is uRmxVNHdrQCzC/NNkJMLWJ0d8MwjwA1lmtZOzueKxfLj8gzuYJy5jJbzpfvowGJLnQ6e jLEy8YWa+m/OtwEy+P35GmcSBqLv/RC1brn5tiDgplLSBjD0VUeAmt0X8A6FmUsQ46r1 bniw== X-Gm-Message-State: ANoB5pnv++Db9YV5CpqofcdvNvHOlK6HjBwlM3E8ZcQJEuY8zbrwkBPF Hs1PzGVkKggpa8fULfL0uS4yOA== X-Google-Smtp-Source: AA0mqf5De6caILdEu8rZPYKkWFUtjt/TYmdGaIIF1tA4kqQIvg9paWBjvYYs6P5O6HNMXBV4NN3wkQ== X-Received: by 2002:a05:600c:1d9c:b0:3c6:e369:e856 with SMTP id p28-20020a05600c1d9c00b003c6e369e856mr45158316wms.35.1669822459732; Wed, 30 Nov 2022 07:34:19 -0800 (PST) Received: from localhost ([2a01:cb19:85e6:1900:2bf7:7388:731d:c4e1]) by smtp.gmail.com with ESMTPSA id l9-20020a05600c2cc900b003cf9bf5208esm5138684wmc.19.2022.11.30.07.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 07:34:19 -0800 (PST) From: Mattijs Korpershoek To: "Lin, Meng-Bo" , linux-kernel@vger.kernel.org Cc: Markuss Broks , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Henrik Rydberg , Stephan Gerhold , Nikita Travkin , linux-input@vger.kernel.org, devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v2 2/3] input/touchscreen: imagis: Correct the maximum touch area value In-Reply-To: <20221118182103.3405-3-linmengbo0689@protonmail.com> References: <20221118182103.3405-1-linmengbo0689@protonmail.com> <20221118182103.3405-3-linmengbo0689@protonmail.com> Date: Wed, 30 Nov 2022 16:34:18 +0100 Message-ID: <87lenssbgl.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Fri, Nov 18, 2022 at 18:21, "Lin, Meng-Bo" wrote: > From: Markuss Broks > > As specified in downstream IST3038 driver and proved by testing, > the correct maximum reported value of touch area is 16. > > Signed-off-by: Markuss Broks > [Change from IST3038B to IST3038] > Signed-off-by: Lin, Meng-Bo Reviewed-by: Mattijs Korpershoek > --- > drivers/input/touchscreen/imagis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/imagis.c b/drivers/input/touchscreen/imagis.c > index e2697e6c6d2a..b667914a44f1 100644 > --- a/drivers/input/touchscreen/imagis.c > +++ b/drivers/input/touchscreen/imagis.c > @@ -210,7 +210,7 @@ static int imagis_init_input_dev(struct imagis_ts *ts) > > input_set_capability(input_dev, EV_ABS, ABS_MT_POSITION_X); > input_set_capability(input_dev, EV_ABS, ABS_MT_POSITION_Y); > - input_set_abs_params(input_dev, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0); > + input_set_abs_params(input_dev, ABS_MT_TOUCH_MAJOR, 0, 16, 0, 0); > > touchscreen_parse_properties(input_dev, true, &ts->prop); > if (!ts->prop.max_x || !ts->prop.max_y) { > -- > 2.30.2