From: Marc Zyngier <maz@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] pinctrl: nomadik: Dereference gpio_chip properly
Date: Sun, 18 Sep 2022 09:43:49 +0100 [thread overview]
Message-ID: <87leqhkr7e.wl-maz@kernel.org> (raw)
In-Reply-To: <20220917203036.167607-1-linus.walleij@linaro.org>
On Sat, 17 Sep 2022 21:30:35 +0100,
Linus Walleij <linus.walleij@linaro.org> wrote:
>
> The irq data passed to irc_chip handlers i the struct gpio_chip
s/i/is/ ?
> and nothing else. We are just lucky that the nomadik chip
> pointer is first in the struct. Use the proper dereferencing
> and helpers.
>
> Reported-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - New patch for a bug identified by Marc.
> ---
> drivers/pinctrl/nomadik/pinctrl-nomadik.c | 30 +++++++++--------------
> 1 file changed, 12 insertions(+), 18 deletions(-)
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2022-09-18 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 20:30 [PATCH 1/2 v2] pinctrl: nomadik: Dereference gpio_chip properly Linus Walleij
2022-09-17 20:30 ` [PATCH 2/2 v2] pinctrl: nomadik: Make gpio irqchip immutable Linus Walleij
2022-09-18 8:44 ` Marc Zyngier
2022-09-18 8:43 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leqhkr7e.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.