All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: cgel.zte@gmail.com
Cc: aspriel@gmail.com, franky.lin@broadcom.com,
	hante.meuleman@broadcom.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	johannes.berg@intel.com, a.fatoum@pengutronix.de,
	quic_vjakkam@quicinc.com, loic.poulain@linaro.org,
	hzamani.cs91@gmail.com, hdegoede@redhat.com, smoch@web.de,
	prestwoj@gmail.com, cui.jinpeng2@zte.com.cn,
	linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] wifi: cfg80211: remove redundant err variable
Date: Mon, 29 Aug 2022 19:13:45 +0300	[thread overview]
Message-ID: <87ler7c9ja.fsf@kernel.org> (raw)
In-Reply-To: <20220829115516.267647-1-cui.jinpeng2@zte.com.cn> (cgel zte's message of "Mon, 29 Aug 2022 11:55:16 +0000")

cgel.zte@gmail.com writes:

> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
>
> Return value from brcmf_fil_iovar_data_set() and
> brcmf_config_ap_mgmt_ie() directly instead of
> taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
> ---
>  .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c    | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

The title should be:

wifi: brcmfmac: remove redundant err variable

Please read our documentation:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

      parent reply	other threads:[~2022-08-29 16:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29 11:55 [PATCH linux-next] wifi: cfg80211: remove redundant err variable cgel.zte
2022-08-29 12:27 ` Ammar Faizi
2022-08-29 16:13 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ler7c9ja.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=SHA-cyfmac-dev-list@infineon.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=aspriel@gmail.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=cgel.zte@gmail.com \
    --cc=cui.jinpeng2@zte.com.cn \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=hdegoede@redhat.com \
    --cc=hzamani.cs91@gmail.com \
    --cc=johannes.berg@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=prestwoj@gmail.com \
    --cc=quic_vjakkam@quicinc.com \
    --cc=smoch@web.de \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.