From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D29C25B0C for ; Thu, 11 Aug 2022 12:56:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 305C04E4C9; Thu, 11 Aug 2022 08:56:29 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DHeX-TXiyitR; Thu, 11 Aug 2022 08:56:27 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DEC534E4CC; Thu, 11 Aug 2022 08:56:27 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6661A4E4CC for ; Thu, 11 Aug 2022 08:56:26 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l+OszDy95gRa for ; Thu, 11 Aug 2022 08:56:25 -0400 (EDT) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 077824E4C9 for ; Thu, 11 Aug 2022 08:56:24 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4878861480; Thu, 11 Aug 2022 12:56:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5D9CC433C1; Thu, 11 Aug 2022 12:56:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660222583; bh=BG0EIiB0G/2fnhVV42nQWkp6CJVQTQC8ZIJ8vLyaPYs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UZFsNSvUvlt4QQphm8bTQrlb6gUnTbmaewplUS9QqX7KcPa0EGGYIKFX5gFzwCOdt G+zzEeuqsjTr6MEkjg0aK0hAG+nEp6wmyT6NXwwBPjnOCmsjgQMG1L6B7MBL+lS2FF SJoS5mN7edBxOClxqjO2eL3maQOuG7rwofgGJG5PG1IJCHU8PFWIxvf5csDLtqjF6C SmZkq1dxGUIrTq0yJAhV27gLiQBAFheuryrt3oX7ZnqVlT7Ew/dS6EuDD931wPIAjQ B44EkWf4x+sCMKIZUSf6KuLmrai3mLCmjzqT9AmwnsDwZKsj1c8/dc77Kc2Qn/y8h3 EREDXpWk1fUwQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oM7jZ-002LKU-Kz; Thu, 11 Aug 2022 13:56:21 +0100 Date: Thu, 11 Aug 2022 13:56:21 +0100 Message-ID: <87lervuefe.wl-maz@kernel.org> From: Marc Zyngier To: Ricardo Koller Subject: Re: [PATCH 0/9] KVM: arm64: PMU: Fixing chained events, and PMUv3p5 support In-Reply-To: References: <20220805135813.2102034-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ricarkol@google.com, oliver.upton@linux.dev, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, alexandru.elisei@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gV2VkLCAxMCBBdWcgMjAyMiAyMjo1NTowMyArMDEwMCwKUmljYXJkbyBLb2xsZXIgPHJpY2Fy a29sQGdvb2dsZS5jb20+IHdyb3RlOgo+IAo+IE9uIFdlZCwgQXVnIDEwLCAyMDIyIGF0IDAyOjMz OjUzUE0gLTA1MDAsIE9saXZlciBVcHRvbiB3cm90ZToKPiA+IEhpIFJpY2FyZG8sCj4gPiAKPiA+ IE9uIFdlZCwgQXVnIDEwLCAyMDIyIGF0IDExOjQ2OjIyQU0gLTA3MDAsIFJpY2FyZG8gS29sbGVy IHdyb3RlOgo+ID4gPiBPbiBGcmksIEF1ZyAwNSwgMjAyMiBhdCAwMjo1ODowNFBNICswMTAwLCBN YXJjIFp5bmdpZXIgd3JvdGU6Cj4gPiA+ID4gUmljYXJkbyByZWNlbnRseSByZXBvcnRlZFsxXSB0 aGF0IG91ciBQTVUgZW11bGF0aW9uIHdhcyBidXN0ZWQgd2hlbiBpdAo+ID4gPiA+IGNvbWVzIHRv IGNoYWluZWQgZXZlbnRzLCBhcyB3ZSBjYW5ub3QgZXhwb3NlIHRoZSBvdmVyZmxvdyBvbiBhIDMy Yml0Cj4gPiA+ID4gYm91bmRhcnkgKHdoaWNoIHRoZSBhcmNoaXRlY3R1cmUgcmVxdWlyZXMpLgo+ ID4gPiA+IAo+ID4gPiA+IFRoaXMgc2VyaWVzIGFpbXMgYXQgZml4aW5nIHRoaXMgKGJ5IGRlbGV0 aW5nIGEgbG90IG9mIGNvZGUpLCBhbmQgYXMgYQo+ID4gPiA+IGJvbnVzIGFkZHMgc3VwcG9ydCBm b3IgUE1VdjNwNSwgYXMgdGhpcyByZXF1aXJlcyB1cyB0byBmaXggYSBmZXcgbW9yZQo+ID4gPiA+ IHRoaW5ncy4KPiA+ID4gPiAKPiA+ID4gPiBUZXN0ZWQgb24gQTUzIChQTVV2MykgYW5kIEZWUCAo UE1VdjNwNSkuCj4gPiA+ID4gCj4gPiA+ID4gWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3Iv MjAyMjA4MDUwMDQxMzkuOTkwNTMxLTEtcmljYXJrb2xAZ29vZ2xlLmNvbQo+ID4gPiA+IAo+ID4g PiA+IE1hcmMgWnluZ2llciAoOSk6Cj4gPiA+ID4gICBLVk06IGFybTY0OiBQTVU6IEFsaWduIGNo YWluZWQgY291bnRlciBpbXBsZW1lbnRhdGlvbiB3aXRoCj4gPiA+ID4gICAgIGFyY2hpdGVjdHVy ZSBwc2V1ZG9jb2RlCj4gPiA+ID4gICBLVk06IGFybTY0OiBQTVU6IERpc3Rpbmd1aXNoIGJldHdl ZW4gNjRiaXQgY291bnRlciBhbmQgNjRiaXQgb3ZlcmZsb3cKPiA+ID4gPiAgIEtWTTogYXJtNjQ6 IFBNVTogT25seSBuYXJyb3cgY291bnRlcnMgdGhhdCBhcmUgbm90IDY0Yml0IHdpZGUKPiA+ID4g PiAgIEtWTTogYXJtNjQ6IFBNVTogQWRkIGNvdW50ZXJfaW5kZXhfdG9fKnJlZygpIGhlbHBlcnMK PiA+ID4gPiAgIEtWTTogYXJtNjQ6IFBNVTogU2ltcGxpZnkgc2V0dGluZyBhIGNvdW50ZXIgdG8g YSBzcGVjaWZpYyB2YWx1ZQo+ID4gPiA+ICAgS1ZNOiBhcm02NDogUE1VOiBNb3ZlIHRoZSBJRF9B QTY0REZSMF9FTDEuUE1VdmVyIGxpbWl0IHRvIFZNIGNyZWF0aW9uCj4gPiA+ID4gICBLVk06IGFy bTY0OiBQTVU6IEFsZXZlbiBJRF9BQTY0REZSMF9FTDEuUE1VdmVyIHRvIGJlIHNldCBmcm9tIHVz ZXJzcGFjZQo+ID4gPiA+ICAgS1ZNOiBhcm02NDogUE1VOiBJbXBsZW1lbnQgUE1VdjNwNSBsb25n IGNvdW50ZXIgc3VwcG9ydAo+ID4gPiA+ICAgS1ZNOiBhcm02NDogUE1VOiBBbGV2ZW4gUE1VdjNw NSB0byBiZSBleHBvc2VkIHRvIHRoZSBndWVzdAo+ID4gPiA+IAo+ID4gPiA+ICBhcmNoL2FybTY0 L2luY2x1ZGUvYXNtL2t2bV9ob3N0LmggfCAgIDEgKwo+ID4gPiA+ICBhcmNoL2FybTY0L2t2bS9h cm0uYyAgICAgICAgICAgICAgfCAgIDYgKwo+ID4gPiA+ICBhcmNoL2FybTY0L2t2bS9wbXUtZW11 bC5jICAgICAgICAgfCAzNzIgKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiA+ID4g IGFyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmMgICAgICAgICB8ICA2NSArKysrKy0KPiA+ID4gPiAg aW5jbHVkZS9rdm0vYXJtX3BtdS5oICAgICAgICAgICAgIHwgIDE2ICstCj4gPiA+ID4gIDUgZmls ZXMgY2hhbmdlZCwgMjA4IGluc2VydGlvbnMoKyksIDI1MiBkZWxldGlvbnMoLSkKPiA+ID4gPiAK PiA+ID4gPiAtLSAKPiA+ID4gPiAyLjM0LjEKPiA+ID4gPiAKPiA+ID4gCj4gPiA+IEhpIE1hcmMs Cj4gPiA+IAo+ID4gPiBUaGVyZSBpcyBvbmUgZXh0cmEgcG90ZW50aWFsIGlzc3VlIHdpdGggZXhw b3NpbmcgUE1VdjNwNS4gSSBzZWUgdGhpcwo+ID4gPiB3ZWlyZCBiZWhhdmlvciB3aGVuIGRvaW5n IHBhc3N0aHJvdWdoICgiYmFyZSBtZXRhbCIpIG9uIHRoZSBmYXN0LW1vZGVsCj4gPiA+IGNvbmZp Z3VyZWQgdG8gZW11bGF0ZSBQTVV2M3A1OiB0aGUgWzYzOjMyXSBoYWxmIG9mIHRoZSBjb3VudGVy cwo+ID4gPiBvdmVyZmxvd2luZyBhdCAzMi1iaXRzIGlzIHN0aWxsIGluY3JlbWVudGVkLgo+ID4g PiAKPiA+ID4gICBGYXN0IG1vZGVsIC0gQVJNdjguNToKPiA+ID4gICAgCj4gPiA+IAlBc3N1bWlu ZyB0aGUgaW5pdGlhbCBzdGF0ZSBpcyBldmVuPTB4RkZGRkZGRkYgYW5kIG9kZD0weDAsCj4gPiA+ IAlpbmNyZW1lbnRpbmcgdGhlIGV2ZW4gY291bnRlciBsZWFkcyB0bzoKPiA+ID4gCj4gPiA+IAkw eDAwMDAwMDAxXzAwMDAwMDAwCTB4MDAwMDAwMDBfMDAwMDAwMDEJCTB4MQo+ID4gPiAJZXZlbiBj b3VudGVyCQlvZGQgY291bnRlcgkJCVBNT1ZTRVQKPiA+ID4gCj4gPiA+IAlBc3N1bWluZyB0aGUg aW5pdGlhbCBzdGF0ZSBpcyBldmVuPTB4RkZGRkZGRkYgYW5kIG9kZD0weEZGRkZGRkZGLAo+ID4g PiAJaW5jcmVtZW50aW5nIHRoZSBldmVuIGNvdW50ZXIgbGVhZHMgdG86Cj4gPiA+IAo+ID4gPiAJ MHgwMDAwMDAwMV8wMDAwMDAwMAkweDAwMDAwMDAxXzAwMDAwMDAwCQkweDMKPiA+ID4gCWV2ZW4g Y291bnRlcgkJb2RkIGNvdW50ZXIJCQlQTU9WU0VUCj4gPiAKPiA+IFRoaXMgaXMgdG8gYmUgZXhw ZWN0ZWQsIGFjdHVhbGx5LiBQTVV2OHA1IGNvdW50ZXJzIGFyZSBhbHdheXMgNjQgYml0LAo+ID4g cmVnYXJkbGVzcyBvZiB0aGUgY29uZmlndXJlZCBvdmVyZmxvdy4KPiA+IAo+ID4gRERJIDA0ODdI IEQ4LjMgQmVoYXZpb3Igb24gb3ZlcmZsb3cKPiA+IAo+ID4gICBJZiBGRUFUX1BNVXYzcDUgaXMg aW1wbGVtZW50ZWQsIDY0LWJpdCBldmVudCBjb3VudGVycyBhcmUgaW1wbGVtZW50ZWQsCj4gPiAg IEhEQ1IuSFBNTiBpcyBub3QgMCwgYW5kIGVpdGhlciBuIGlzIGluIHRoZSByYW5nZSBbMCAuLiAo SERDUi5IUE1OLTEpXQo+ID4gICBvciBFTDIgaXMgbm90IGltcGxlbWVudGVkLCB0aGVuIGV2ZW50 IGNvdW50ZXIgb3ZlcmZsb3cgaXMgY29uZmlndXJlZAo+ID4gICBieSBQTUNSLkxQOgo+ID4gCj4g PiAgIOKAlCBXaGVuIFBNQ1IuTFAgaXMgc2V0IHRvIDAsIGlmIGluY3JlbWVudGluZyBQTUVWQ05U UjxuPiBjYXVzZXMgYW4gdW5zaWduZWQKPiA+ICAgICBvdmVyZmxvdyBvZiBiaXRzIFszMTowXSBv ZiB0aGUgZXZlbnQgY291bnRlciwgdGhlIFBFIHNldHMgUE1PVlNDTFJbbl0gdG8gMS4KPiA+ICAg 4oCUIFdoZW4gUE1DUi5MUCBpcyBzZXQgdG8gMSwgaWYgaW5jcmVtZW50aW5nIFBNRVZDTlRSPG4+ IGNhdXNlcyBhbiB1bnNpZ25lZAo+ID4gICAgIG92ZXJmbG93IG9mIGJpdHMgWzYzOjBdIG9mIHRo ZSBldmVudCBjb3VudGVyLCB0aGUgUEUgc2V0cyBQTU9WU0NMUltuXSB0byAxLgo+ID4gCj4gPiAg IFsuLi5dCj4gPiAKPiA+ICAgRm9yIGFsbCA2NC1iaXQgY291bnRlcnMsIGluY3JlbWVudGluZyB0 aGUgY291bnRlciBpcyB0aGUgc2FtZSB3aGV0aGVyIGFuCj4gPiAgIHVuc2lnbmVkIG92ZXJmbG93 IG9jY3VycyBhdCBbMzE6MF0gb3IgWzYzOjBdLiBJZiB0aGUgY291bnRlciBpbmNyZW1lbnRzCj4g PiAgIGZvciBhbiBldmVudCwgYml0cyBbNjM6MF0gYXJlIGFsd2F5cyBpbmNyZW1lbnRlZC4KPiA+ IAo+ID4gRG8geW91IHNlZSB0aGlzIHNhbWUgKGV4cGVjdGVkKSBmYWlsdXJlIHcvIE1hcmMncyBz ZXJpZXM/Cj4gCj4gSSBkb24ndCBrbm93LCBJJ20gaGl0dGluZyBhbm90aGVyIGJ1ZyBpdCBzZWVt cy4KPiAKPiBKdXN0IHJlYWxpemVkIHRoYXQgS1ZNIGRvZXMgbm90IG9mZmVyIFBNVXYzcDUgKHdp dGggdGhpcyBzZXJpZXMgYXBwbGllZCkKPiB3aGVuIHRoZSByZWFsIGhhcmR3YXJlIGlzIG9ubHkg QXJtdjguMiAodGhlIHNldHVwIEkgb3JpZ2luYWxseSB0cmllZCkuCj4gU28sIHRyaWVkIHRoZXNl IG90aGVyIHR3byBzZXR1cHMgb24gdGhlIGZhc3QgbW9kZWw6Cj4gCj4gaGFzX2FybV92OC01PTEK PiAKPiAJIyAuL2xrdm0tc3RhdGljIHJ1biAtLW5vZGVmYXVsdHMgLS1wbXUgcG11LmZsYXQgLXAg cG11LWNoYWluZWQtc3ctaW5jcgo+IAkjIGxrdm0gcnVuIC1rIHBtdS5mbGF0IC1tIDcwNCAtYyA4 IC0tbmFtZSBndWVzdC0xMzUKPiAKPiAJSU5GTzogUE1VIHZlcnNpb246IDB4Ngo+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgIF5eXgo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBNVXYz IGZvciBBcm12OC41Cj4gCUlORk86IFBNVSBpbXBsZW1lbnRlci9JRCBjb2RlOiAweDQxKCJBIikv MAo+IAlJTkZPOiBJbXBsZW1lbnRzIDggZXZlbnQgY291bnRlcnMKPiAJRkFJTDogcG11OiBwbXUt Y2hhaW5lZC1zdy1pbmNyOiBvdmVyZmxvdyBhbmQgY2hhaW4gY291bnRlciBpbmNyZW1lbnRlZCBh ZnRlciAxMDAgU1dfSU5DUi9DSEFJTgo+IAlJTkZPOiBwbXU6IHBtdS1jaGFpbmVkLXN3LWluY3I6 IG92ZXJmbG93PTB4MCwgIzA9NDI5NDk2NzM4MCAjMT0wCj4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5eXgo+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBubyBvdmVyZmxvd3MKPiAJRkFJTDogcG11OiBwbXUt Y2hhaW5lZC1zdy1pbmNyOiBleHBlY3RlZCBvdmVyZmxvd3MgYW5kIHZhbHVlcyBhZnRlciAxMDAg U1dfSU5DUi9DSEFJTgo+IAlJTkZPOiBwbXU6IHBtdS1jaGFpbmVkLXN3LWluY3I6IG92ZXJmbG93 PTB4MCwgIzA9ODQgIzE9LTEKPiAJSU5GTzogcG11OiBwbXUtY2hhaW5lZC1zdy1pbmNyOiBvdmVy Zmxvdz0weDAsICMwPTQyOTQ5NjczODAgIzE9NDI5NDk2NzI5NQo+IAlTVU1NQVJZOiAyIHRlc3Rz LCAyIHVuZXhwZWN0ZWQgZmFpbHVyZXMKCkhtbS4gSSB0aGluayBJIHNlZSB3aGF0J3Mgd3Jvbmcu IEluIGt2bV9wbXVfY3JlYXRlX3BlcmZfZXZlbnQoKSwgd2UKaGF2ZSB0aGlzOgoKCWlmIChrdm1f cG11X2lkeF9pc182NGJpdCh2Y3B1LCBzZWxlY3RfaWR4KSkKCQlhdHRyLmNvbmZpZzEgfD0gMTsK Cgljb3VudGVyID0ga3ZtX3BtdV9nZXRfY291bnRlcl92YWx1ZSh2Y3B1LCBzZWxlY3RfaWR4KTsK CgkvKiBUaGUgaW5pdGlhbCBzYW1wbGUgcGVyaW9kIChvdmVyZmxvdyBjb3VudCkgb2YgYW4gZXZl bnQuICovCglpZiAoa3ZtX3BtdV9pZHhfaGFzXzY0Yml0X292ZXJmbG93KHZjcHUsIHNlbGVjdF9p ZHgpKQoJCWF0dHIuc2FtcGxlX3BlcmlvZCA9ICgtY291bnRlcikgJiBHRU5NQVNLKDYzLCAwKTsK CWVsc2UKCQlhdHRyLnNhbXBsZV9wZXJpb2QgPSAoLWNvdW50ZXIpICYgR0VOTUFTSygzMSwgMCk7 CgpidXQgdGhlIGluaXRpYWwgc2FtcGxpbmcgcGVyaW9kIHNob3VsZG4ndCBiZSBiYXNlZCBvbiB0 aGUgKmd1ZXN0Kgpjb3VudGVyIG92ZXJmbG93LiBJdCByZWFsbHkgaXMgYWJvdXQgdGhlIGdldHRp bmcgdG8gYW4gb3ZlcmZsb3cgb24gdGhlCipob3N0Kiwgc28gdGhlIGluaXRpYWwgY29kZSB3YXMg Y29ycmVjdCwgYW5kIG9ubHkgdGhlIHdpZHRoIG9mIHRoZQpjb3VudGVyIG1hdHRlcnMgaGVyZS4K Ci9tZSBnb2VzIGJhY2sgdG8gcnVubmluZyB0aGUgRlZQLi4uCgpUaGFua3MsCgoJTS4KCi0tIApX aXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUu Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBt YWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNz LmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AED05C19F2A for ; Thu, 11 Aug 2022 12:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Clcd3DxzVp6DcGUyfnr8xfl1AzVVFT4YgOSL0QH3ynw=; b=hc8BTmYXABQQIA 5fS+7xu56X8hR4kOVPZo/U/YeTceNiJLRmJ1fTnywSTskrKTR65q1nnQrHO3RRc1t+cF2vfjwKfCY 2q+XkbVHNpCJqknRcqNqxW/5DftqJsaM3TeSglQVZ902/nobMm27I6nkRxpmlDFP/zyYqJjvQRZAY BCC8ABwcfThyUjrvDcwyiNu8iAqCzWfT342G68974q0ukOInceGTGxv9iIlrvCeSBaqQ0r5M8+DDc 1iNZHhyLZ5dm0cAJOgJPbsUwxPHfunovy50fXGqfl/JON4Qh7fFZe1+zFq4/uoLlJ5R7QVaMrtJC+ EowBowhOYabB1P6pEW/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oM7jg-00CMOA-Px; Thu, 11 Aug 2022 12:56:28 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oM7jd-00CMMt-Sh for linux-arm-kernel@lists.infradead.org; Thu, 11 Aug 2022 12:56:27 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4878861480; Thu, 11 Aug 2022 12:56:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5D9CC433C1; Thu, 11 Aug 2022 12:56:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660222583; bh=BG0EIiB0G/2fnhVV42nQWkp6CJVQTQC8ZIJ8vLyaPYs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UZFsNSvUvlt4QQphm8bTQrlb6gUnTbmaewplUS9QqX7KcPa0EGGYIKFX5gFzwCOdt G+zzEeuqsjTr6MEkjg0aK0hAG+nEp6wmyT6NXwwBPjnOCmsjgQMG1L6B7MBL+lS2FF SJoS5mN7edBxOClxqjO2eL3maQOuG7rwofgGJG5PG1IJCHU8PFWIxvf5csDLtqjF6C SmZkq1dxGUIrTq0yJAhV27gLiQBAFheuryrt3oX7ZnqVlT7Ew/dS6EuDD931wPIAjQ B44EkWf4x+sCMKIZUSf6KuLmrai3mLCmjzqT9AmwnsDwZKsj1c8/dc77Kc2Qn/y8h3 EREDXpWk1fUwQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oM7jZ-002LKU-Kz; Thu, 11 Aug 2022 13:56:21 +0100 Date: Thu, 11 Aug 2022 13:56:21 +0100 Message-ID: <87lervuefe.wl-maz@kernel.org> From: Marc Zyngier To: Ricardo Koller Cc: Oliver Upton , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH 0/9] KVM: arm64: PMU: Fixing chained events, and PMUv3p5 support In-Reply-To: References: <20220805135813.2102034-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ricarkol@google.com, oliver.upton@linux.dev, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, alexandru.elisei@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220811_055626_025272_412DC324 X-CRM114-Status: GOOD ( 39.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxMCBBdWcgMjAyMiAyMjo1NTowMyArMDEwMCwKUmljYXJkbyBLb2xsZXIgPHJpY2Fy a29sQGdvb2dsZS5jb20+IHdyb3RlOgo+IAo+IE9uIFdlZCwgQXVnIDEwLCAyMDIyIGF0IDAyOjMz OjUzUE0gLTA1MDAsIE9saXZlciBVcHRvbiB3cm90ZToKPiA+IEhpIFJpY2FyZG8sCj4gPiAKPiA+ IE9uIFdlZCwgQXVnIDEwLCAyMDIyIGF0IDExOjQ2OjIyQU0gLTA3MDAsIFJpY2FyZG8gS29sbGVy IHdyb3RlOgo+ID4gPiBPbiBGcmksIEF1ZyAwNSwgMjAyMiBhdCAwMjo1ODowNFBNICswMTAwLCBN YXJjIFp5bmdpZXIgd3JvdGU6Cj4gPiA+ID4gUmljYXJkbyByZWNlbnRseSByZXBvcnRlZFsxXSB0 aGF0IG91ciBQTVUgZW11bGF0aW9uIHdhcyBidXN0ZWQgd2hlbiBpdAo+ID4gPiA+IGNvbWVzIHRv IGNoYWluZWQgZXZlbnRzLCBhcyB3ZSBjYW5ub3QgZXhwb3NlIHRoZSBvdmVyZmxvdyBvbiBhIDMy Yml0Cj4gPiA+ID4gYm91bmRhcnkgKHdoaWNoIHRoZSBhcmNoaXRlY3R1cmUgcmVxdWlyZXMpLgo+ ID4gPiA+IAo+ID4gPiA+IFRoaXMgc2VyaWVzIGFpbXMgYXQgZml4aW5nIHRoaXMgKGJ5IGRlbGV0 aW5nIGEgbG90IG9mIGNvZGUpLCBhbmQgYXMgYQo+ID4gPiA+IGJvbnVzIGFkZHMgc3VwcG9ydCBm b3IgUE1VdjNwNSwgYXMgdGhpcyByZXF1aXJlcyB1cyB0byBmaXggYSBmZXcgbW9yZQo+ID4gPiA+ IHRoaW5ncy4KPiA+ID4gPiAKPiA+ID4gPiBUZXN0ZWQgb24gQTUzIChQTVV2MykgYW5kIEZWUCAo UE1VdjNwNSkuCj4gPiA+ID4gCj4gPiA+ID4gWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3Iv MjAyMjA4MDUwMDQxMzkuOTkwNTMxLTEtcmljYXJrb2xAZ29vZ2xlLmNvbQo+ID4gPiA+IAo+ID4g PiA+IE1hcmMgWnluZ2llciAoOSk6Cj4gPiA+ID4gICBLVk06IGFybTY0OiBQTVU6IEFsaWduIGNo YWluZWQgY291bnRlciBpbXBsZW1lbnRhdGlvbiB3aXRoCj4gPiA+ID4gICAgIGFyY2hpdGVjdHVy ZSBwc2V1ZG9jb2RlCj4gPiA+ID4gICBLVk06IGFybTY0OiBQTVU6IERpc3Rpbmd1aXNoIGJldHdl ZW4gNjRiaXQgY291bnRlciBhbmQgNjRiaXQgb3ZlcmZsb3cKPiA+ID4gPiAgIEtWTTogYXJtNjQ6 IFBNVTogT25seSBuYXJyb3cgY291bnRlcnMgdGhhdCBhcmUgbm90IDY0Yml0IHdpZGUKPiA+ID4g PiAgIEtWTTogYXJtNjQ6IFBNVTogQWRkIGNvdW50ZXJfaW5kZXhfdG9fKnJlZygpIGhlbHBlcnMK PiA+ID4gPiAgIEtWTTogYXJtNjQ6IFBNVTogU2ltcGxpZnkgc2V0dGluZyBhIGNvdW50ZXIgdG8g YSBzcGVjaWZpYyB2YWx1ZQo+ID4gPiA+ICAgS1ZNOiBhcm02NDogUE1VOiBNb3ZlIHRoZSBJRF9B QTY0REZSMF9FTDEuUE1VdmVyIGxpbWl0IHRvIFZNIGNyZWF0aW9uCj4gPiA+ID4gICBLVk06IGFy bTY0OiBQTVU6IEFsZXZlbiBJRF9BQTY0REZSMF9FTDEuUE1VdmVyIHRvIGJlIHNldCBmcm9tIHVz ZXJzcGFjZQo+ID4gPiA+ICAgS1ZNOiBhcm02NDogUE1VOiBJbXBsZW1lbnQgUE1VdjNwNSBsb25n IGNvdW50ZXIgc3VwcG9ydAo+ID4gPiA+ICAgS1ZNOiBhcm02NDogUE1VOiBBbGV2ZW4gUE1VdjNw NSB0byBiZSBleHBvc2VkIHRvIHRoZSBndWVzdAo+ID4gPiA+IAo+ID4gPiA+ICBhcmNoL2FybTY0 L2luY2x1ZGUvYXNtL2t2bV9ob3N0LmggfCAgIDEgKwo+ID4gPiA+ICBhcmNoL2FybTY0L2t2bS9h cm0uYyAgICAgICAgICAgICAgfCAgIDYgKwo+ID4gPiA+ICBhcmNoL2FybTY0L2t2bS9wbXUtZW11 bC5jICAgICAgICAgfCAzNzIgKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiA+ID4g IGFyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmMgICAgICAgICB8ICA2NSArKysrKy0KPiA+ID4gPiAg aW5jbHVkZS9rdm0vYXJtX3BtdS5oICAgICAgICAgICAgIHwgIDE2ICstCj4gPiA+ID4gIDUgZmls ZXMgY2hhbmdlZCwgMjA4IGluc2VydGlvbnMoKyksIDI1MiBkZWxldGlvbnMoLSkKPiA+ID4gPiAK PiA+ID4gPiAtLSAKPiA+ID4gPiAyLjM0LjEKPiA+ID4gPiAKPiA+ID4gCj4gPiA+IEhpIE1hcmMs Cj4gPiA+IAo+ID4gPiBUaGVyZSBpcyBvbmUgZXh0cmEgcG90ZW50aWFsIGlzc3VlIHdpdGggZXhw b3NpbmcgUE1VdjNwNS4gSSBzZWUgdGhpcwo+ID4gPiB3ZWlyZCBiZWhhdmlvciB3aGVuIGRvaW5n IHBhc3N0aHJvdWdoICgiYmFyZSBtZXRhbCIpIG9uIHRoZSBmYXN0LW1vZGVsCj4gPiA+IGNvbmZp Z3VyZWQgdG8gZW11bGF0ZSBQTVV2M3A1OiB0aGUgWzYzOjMyXSBoYWxmIG9mIHRoZSBjb3VudGVy cwo+ID4gPiBvdmVyZmxvd2luZyBhdCAzMi1iaXRzIGlzIHN0aWxsIGluY3JlbWVudGVkLgo+ID4g PiAKPiA+ID4gICBGYXN0IG1vZGVsIC0gQVJNdjguNToKPiA+ID4gICAgCj4gPiA+IAlBc3N1bWlu ZyB0aGUgaW5pdGlhbCBzdGF0ZSBpcyBldmVuPTB4RkZGRkZGRkYgYW5kIG9kZD0weDAsCj4gPiA+ IAlpbmNyZW1lbnRpbmcgdGhlIGV2ZW4gY291bnRlciBsZWFkcyB0bzoKPiA+ID4gCj4gPiA+IAkw eDAwMDAwMDAxXzAwMDAwMDAwCTB4MDAwMDAwMDBfMDAwMDAwMDEJCTB4MQo+ID4gPiAJZXZlbiBj b3VudGVyCQlvZGQgY291bnRlcgkJCVBNT1ZTRVQKPiA+ID4gCj4gPiA+IAlBc3N1bWluZyB0aGUg aW5pdGlhbCBzdGF0ZSBpcyBldmVuPTB4RkZGRkZGRkYgYW5kIG9kZD0weEZGRkZGRkZGLAo+ID4g PiAJaW5jcmVtZW50aW5nIHRoZSBldmVuIGNvdW50ZXIgbGVhZHMgdG86Cj4gPiA+IAo+ID4gPiAJ MHgwMDAwMDAwMV8wMDAwMDAwMAkweDAwMDAwMDAxXzAwMDAwMDAwCQkweDMKPiA+ID4gCWV2ZW4g Y291bnRlcgkJb2RkIGNvdW50ZXIJCQlQTU9WU0VUCj4gPiAKPiA+IFRoaXMgaXMgdG8gYmUgZXhw ZWN0ZWQsIGFjdHVhbGx5LiBQTVV2OHA1IGNvdW50ZXJzIGFyZSBhbHdheXMgNjQgYml0LAo+ID4g cmVnYXJkbGVzcyBvZiB0aGUgY29uZmlndXJlZCBvdmVyZmxvdy4KPiA+IAo+ID4gRERJIDA0ODdI IEQ4LjMgQmVoYXZpb3Igb24gb3ZlcmZsb3cKPiA+IAo+ID4gICBJZiBGRUFUX1BNVXYzcDUgaXMg aW1wbGVtZW50ZWQsIDY0LWJpdCBldmVudCBjb3VudGVycyBhcmUgaW1wbGVtZW50ZWQsCj4gPiAg IEhEQ1IuSFBNTiBpcyBub3QgMCwgYW5kIGVpdGhlciBuIGlzIGluIHRoZSByYW5nZSBbMCAuLiAo SERDUi5IUE1OLTEpXQo+ID4gICBvciBFTDIgaXMgbm90IGltcGxlbWVudGVkLCB0aGVuIGV2ZW50 IGNvdW50ZXIgb3ZlcmZsb3cgaXMgY29uZmlndXJlZAo+ID4gICBieSBQTUNSLkxQOgo+ID4gCj4g PiAgIOKAlCBXaGVuIFBNQ1IuTFAgaXMgc2V0IHRvIDAsIGlmIGluY3JlbWVudGluZyBQTUVWQ05U UjxuPiBjYXVzZXMgYW4gdW5zaWduZWQKPiA+ICAgICBvdmVyZmxvdyBvZiBiaXRzIFszMTowXSBv ZiB0aGUgZXZlbnQgY291bnRlciwgdGhlIFBFIHNldHMgUE1PVlNDTFJbbl0gdG8gMS4KPiA+ICAg 4oCUIFdoZW4gUE1DUi5MUCBpcyBzZXQgdG8gMSwgaWYgaW5jcmVtZW50aW5nIFBNRVZDTlRSPG4+ IGNhdXNlcyBhbiB1bnNpZ25lZAo+ID4gICAgIG92ZXJmbG93IG9mIGJpdHMgWzYzOjBdIG9mIHRo ZSBldmVudCBjb3VudGVyLCB0aGUgUEUgc2V0cyBQTU9WU0NMUltuXSB0byAxLgo+ID4gCj4gPiAg IFsuLi5dCj4gPiAKPiA+ICAgRm9yIGFsbCA2NC1iaXQgY291bnRlcnMsIGluY3JlbWVudGluZyB0 aGUgY291bnRlciBpcyB0aGUgc2FtZSB3aGV0aGVyIGFuCj4gPiAgIHVuc2lnbmVkIG92ZXJmbG93 IG9jY3VycyBhdCBbMzE6MF0gb3IgWzYzOjBdLiBJZiB0aGUgY291bnRlciBpbmNyZW1lbnRzCj4g PiAgIGZvciBhbiBldmVudCwgYml0cyBbNjM6MF0gYXJlIGFsd2F5cyBpbmNyZW1lbnRlZC4KPiA+ IAo+ID4gRG8geW91IHNlZSB0aGlzIHNhbWUgKGV4cGVjdGVkKSBmYWlsdXJlIHcvIE1hcmMncyBz ZXJpZXM/Cj4gCj4gSSBkb24ndCBrbm93LCBJJ20gaGl0dGluZyBhbm90aGVyIGJ1ZyBpdCBzZWVt cy4KPiAKPiBKdXN0IHJlYWxpemVkIHRoYXQgS1ZNIGRvZXMgbm90IG9mZmVyIFBNVXYzcDUgKHdp dGggdGhpcyBzZXJpZXMgYXBwbGllZCkKPiB3aGVuIHRoZSByZWFsIGhhcmR3YXJlIGlzIG9ubHkg QXJtdjguMiAodGhlIHNldHVwIEkgb3JpZ2luYWxseSB0cmllZCkuCj4gU28sIHRyaWVkIHRoZXNl IG90aGVyIHR3byBzZXR1cHMgb24gdGhlIGZhc3QgbW9kZWw6Cj4gCj4gaGFzX2FybV92OC01PTEK PiAKPiAJIyAuL2xrdm0tc3RhdGljIHJ1biAtLW5vZGVmYXVsdHMgLS1wbXUgcG11LmZsYXQgLXAg cG11LWNoYWluZWQtc3ctaW5jcgo+IAkjIGxrdm0gcnVuIC1rIHBtdS5mbGF0IC1tIDcwNCAtYyA4 IC0tbmFtZSBndWVzdC0xMzUKPiAKPiAJSU5GTzogUE1VIHZlcnNpb246IDB4Ngo+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgIF5eXgo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBNVXYz IGZvciBBcm12OC41Cj4gCUlORk86IFBNVSBpbXBsZW1lbnRlci9JRCBjb2RlOiAweDQxKCJBIikv MAo+IAlJTkZPOiBJbXBsZW1lbnRzIDggZXZlbnQgY291bnRlcnMKPiAJRkFJTDogcG11OiBwbXUt Y2hhaW5lZC1zdy1pbmNyOiBvdmVyZmxvdyBhbmQgY2hhaW4gY291bnRlciBpbmNyZW1lbnRlZCBh ZnRlciAxMDAgU1dfSU5DUi9DSEFJTgo+IAlJTkZPOiBwbXU6IHBtdS1jaGFpbmVkLXN3LWluY3I6 IG92ZXJmbG93PTB4MCwgIzA9NDI5NDk2NzM4MCAjMT0wCj4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5eXgo+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBubyBvdmVyZmxvd3MKPiAJRkFJTDogcG11OiBwbXUt Y2hhaW5lZC1zdy1pbmNyOiBleHBlY3RlZCBvdmVyZmxvd3MgYW5kIHZhbHVlcyBhZnRlciAxMDAg U1dfSU5DUi9DSEFJTgo+IAlJTkZPOiBwbXU6IHBtdS1jaGFpbmVkLXN3LWluY3I6IG92ZXJmbG93 PTB4MCwgIzA9ODQgIzE9LTEKPiAJSU5GTzogcG11OiBwbXUtY2hhaW5lZC1zdy1pbmNyOiBvdmVy Zmxvdz0weDAsICMwPTQyOTQ5NjczODAgIzE9NDI5NDk2NzI5NQo+IAlTVU1NQVJZOiAyIHRlc3Rz LCAyIHVuZXhwZWN0ZWQgZmFpbHVyZXMKCkhtbS4gSSB0aGluayBJIHNlZSB3aGF0J3Mgd3Jvbmcu IEluIGt2bV9wbXVfY3JlYXRlX3BlcmZfZXZlbnQoKSwgd2UKaGF2ZSB0aGlzOgoKCWlmIChrdm1f cG11X2lkeF9pc182NGJpdCh2Y3B1LCBzZWxlY3RfaWR4KSkKCQlhdHRyLmNvbmZpZzEgfD0gMTsK Cgljb3VudGVyID0ga3ZtX3BtdV9nZXRfY291bnRlcl92YWx1ZSh2Y3B1LCBzZWxlY3RfaWR4KTsK CgkvKiBUaGUgaW5pdGlhbCBzYW1wbGUgcGVyaW9kIChvdmVyZmxvdyBjb3VudCkgb2YgYW4gZXZl bnQuICovCglpZiAoa3ZtX3BtdV9pZHhfaGFzXzY0Yml0X292ZXJmbG93KHZjcHUsIHNlbGVjdF9p ZHgpKQoJCWF0dHIuc2FtcGxlX3BlcmlvZCA9ICgtY291bnRlcikgJiBHRU5NQVNLKDYzLCAwKTsK CWVsc2UKCQlhdHRyLnNhbXBsZV9wZXJpb2QgPSAoLWNvdW50ZXIpICYgR0VOTUFTSygzMSwgMCk7 CgpidXQgdGhlIGluaXRpYWwgc2FtcGxpbmcgcGVyaW9kIHNob3VsZG4ndCBiZSBiYXNlZCBvbiB0 aGUgKmd1ZXN0Kgpjb3VudGVyIG92ZXJmbG93LiBJdCByZWFsbHkgaXMgYWJvdXQgdGhlIGdldHRp bmcgdG8gYW4gb3ZlcmZsb3cgb24gdGhlCipob3N0Kiwgc28gdGhlIGluaXRpYWwgY29kZSB3YXMg Y29ycmVjdCwgYW5kIG9ubHkgdGhlIHdpZHRoIG9mIHRoZQpjb3VudGVyIG1hdHRlcnMgaGVyZS4K Ci9tZSBnb2VzIGJhY2sgdG8gcnVubmluZyB0aGUgRlZQLi4uCgpUaGFua3MsCgoJTS4KCi0tIApX aXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUu CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86126C19F2A for ; Thu, 11 Aug 2022 12:56:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235498AbiHKM42 (ORCPT ); Thu, 11 Aug 2022 08:56:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234179AbiHKM41 (ORCPT ); Thu, 11 Aug 2022 08:56:27 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CBF13F314 for ; Thu, 11 Aug 2022 05:56:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DF9B7B820BE for ; Thu, 11 Aug 2022 12:56:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5D9CC433C1; Thu, 11 Aug 2022 12:56:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660222583; bh=BG0EIiB0G/2fnhVV42nQWkp6CJVQTQC8ZIJ8vLyaPYs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UZFsNSvUvlt4QQphm8bTQrlb6gUnTbmaewplUS9QqX7KcPa0EGGYIKFX5gFzwCOdt G+zzEeuqsjTr6MEkjg0aK0hAG+nEp6wmyT6NXwwBPjnOCmsjgQMG1L6B7MBL+lS2FF SJoS5mN7edBxOClxqjO2eL3maQOuG7rwofgGJG5PG1IJCHU8PFWIxvf5csDLtqjF6C SmZkq1dxGUIrTq0yJAhV27gLiQBAFheuryrt3oX7ZnqVlT7Ew/dS6EuDD931wPIAjQ B44EkWf4x+sCMKIZUSf6KuLmrai3mLCmjzqT9AmwnsDwZKsj1c8/dc77Kc2Qn/y8h3 EREDXpWk1fUwQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oM7jZ-002LKU-Kz; Thu, 11 Aug 2022 13:56:21 +0100 Date: Thu, 11 Aug 2022 13:56:21 +0100 Message-ID: <87lervuefe.wl-maz@kernel.org> From: Marc Zyngier To: Ricardo Koller Cc: Oliver Upton , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH 0/9] KVM: arm64: PMU: Fixing chained events, and PMUv3p5 support In-Reply-To: References: <20220805135813.2102034-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ricarkol@google.com, oliver.upton@linux.dev, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, alexandru.elisei@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 10 Aug 2022 22:55:03 +0100, Ricardo Koller wrote: >=20 > On Wed, Aug 10, 2022 at 02:33:53PM -0500, Oliver Upton wrote: > > Hi Ricardo, > >=20 > > On Wed, Aug 10, 2022 at 11:46:22AM -0700, Ricardo Koller wrote: > > > On Fri, Aug 05, 2022 at 02:58:04PM +0100, Marc Zyngier wrote: > > > > Ricardo recently reported[1] that our PMU emulation was busted when= it > > > > comes to chained events, as we cannot expose the overflow on a 32bit > > > > boundary (which the architecture requires). > > > >=20 > > > > This series aims at fixing this (by deleting a lot of code), and as= a > > > > bonus adds support for PMUv3p5, as this requires us to fix a few mo= re > > > > things. > > > >=20 > > > > Tested on A53 (PMUv3) and FVP (PMUv3p5). > > > >=20 > > > > [1] https://lore.kernel.org/r/20220805004139.990531-1-ricarkol@goog= le.com > > > >=20 > > > > Marc Zyngier (9): > > > > KVM: arm64: PMU: Align chained counter implementation with > > > > architecture pseudocode > > > > KVM: arm64: PMU: Distinguish between 64bit counter and 64bit over= flow > > > > KVM: arm64: PMU: Only narrow counters that are not 64bit wide > > > > KVM: arm64: PMU: Add counter_index_to_*reg() helpers > > > > KVM: arm64: PMU: Simplify setting a counter to a specific value > > > > KVM: arm64: PMU: Move the ID_AA64DFR0_EL1.PMUver limit to VM crea= tion > > > > KVM: arm64: PMU: Aleven ID_AA64DFR0_EL1.PMUver to be set from use= rspace > > > > KVM: arm64: PMU: Implement PMUv3p5 long counter support > > > > KVM: arm64: PMU: Aleven PMUv3p5 to be exposed to the guest > > > >=20 > > > > arch/arm64/include/asm/kvm_host.h | 1 + > > > > arch/arm64/kvm/arm.c | 6 + > > > > arch/arm64/kvm/pmu-emul.c | 372 ++++++++++----------------= ---- > > > > arch/arm64/kvm/sys_regs.c | 65 +++++- > > > > include/kvm/arm_pmu.h | 16 +- > > > > 5 files changed, 208 insertions(+), 252 deletions(-) > > > >=20 > > > > --=20 > > > > 2.34.1 > > > >=20 > > >=20 > > > Hi Marc, > > >=20 > > > There is one extra potential issue with exposing PMUv3p5. I see this > > > weird behavior when doing passthrough ("bare metal") on the fast-model > > > configured to emulate PMUv3p5: the [63:32] half of the counters > > > overflowing at 32-bits is still incremented. > > >=20 > > > Fast model - ARMv8.5: > > > =20 > > > Assuming the initial state is even=3D0xFFFFFFFF and odd=3D0x0, > > > incrementing the even counter leads to: > > >=20 > > > 0x00000001_00000000 0x00000000_00000001 0x1 > > > even counter odd counter PMOVSET > > >=20 > > > Assuming the initial state is even=3D0xFFFFFFFF and odd=3D0xFFFFFFFF, > > > incrementing the even counter leads to: > > >=20 > > > 0x00000001_00000000 0x00000001_00000000 0x3 > > > even counter odd counter PMOVSET > >=20 > > This is to be expected, actually. PMUv8p5 counters are always 64 bit, > > regardless of the configured overflow. > >=20 > > DDI 0487H D8.3 Behavior on overflow > >=20 > > If FEAT_PMUv3p5 is implemented, 64-bit event counters are implemented, > > HDCR.HPMN is not 0, and either n is in the range [0 .. (HDCR.HPMN-1)] > > or EL2 is not implemented, then event counter overflow is configured > > by PMCR.LP: > >=20 > > =E2=80=94 When PMCR.LP is set to 0, if incrementing PMEVCNTR cause= s an unsigned > > overflow of bits [31:0] of the event counter, the PE sets PMOVSCLR[= n] to 1. > > =E2=80=94 When PMCR.LP is set to 1, if incrementing PMEVCNTR cause= s an unsigned > > overflow of bits [63:0] of the event counter, the PE sets PMOVSCLR[= n] to 1. > >=20 > > [...] > >=20 > > For all 64-bit counters, incrementing the counter is the same whether= an > > unsigned overflow occurs at [31:0] or [63:0]. If the counter incremen= ts > > for an event, bits [63:0] are always incremented. > >=20 > > Do you see this same (expected) failure w/ Marc's series? >=20 > I don't know, I'm hitting another bug it seems. >=20 > Just realized that KVM does not offer PMUv3p5 (with this series applied) > when the real hardware is only Armv8.2 (the setup I originally tried). > So, tried these other two setups on the fast model: >=20 > has_arm_v8-5=3D1 >=20 > # ./lkvm-static run --nodefaults --pmu pmu.flat -p pmu-chained-sw-incr > # lkvm run -k pmu.flat -m 704 -c 8 --name guest-135 >=20 > INFO: PMU version: 0x6 > ^^^ > PMUv3 for Armv8.5 > INFO: PMU implementer/ID code: 0x41("A")/0 > INFO: Implements 8 event counters > FAIL: pmu: pmu-chained-sw-incr: overflow and chain counter incremented a= fter 100 SW_INCR/CHAIN > INFO: pmu: pmu-chained-sw-incr: overflow=3D0x0, #0=3D4294967380 #1=3D0 > ^^^ > no overflows > FAIL: pmu: pmu-chained-sw-incr: expected overflows and values after 100 = SW_INCR/CHAIN > INFO: pmu: pmu-chained-sw-incr: overflow=3D0x0, #0=3D84 #1=3D-1 > INFO: pmu: pmu-chained-sw-incr: overflow=3D0x0, #0=3D4294967380 #1=3D429= 4967295 > SUMMARY: 2 tests, 2 unexpected failures Hmm. I think I see what's wrong. In kvm_pmu_create_perf_event(), we have this: if (kvm_pmu_idx_is_64bit(vcpu, select_idx)) attr.config1 |=3D 1; counter =3D kvm_pmu_get_counter_value(vcpu, select_idx); /* The initial sample period (overflow count) of an event. */ if (kvm_pmu_idx_has_64bit_overflow(vcpu, select_idx)) attr.sample_period =3D (-counter) & GENMASK(63, 0); else attr.sample_period =3D (-counter) & GENMASK(31, 0); but the initial sampling period shouldn't be based on the *guest* counter overflow. It really is about the getting to an overflow on the *host*, so the initial code was correct, and only the width of the counter matters here. /me goes back to running the FVP... Thanks, M. --=20 Without deviation from the norm, progress is not possible.