From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBA07C433EF for ; Fri, 22 Jul 2022 14:16:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4EC704CDB1; Fri, 22 Jul 2022 10:16:42 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K3p6Gcevg6NC; Fri, 22 Jul 2022 10:16:41 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 19A364CD93; Fri, 22 Jul 2022 10:16:41 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 59ABE4CD8A for ; Fri, 22 Jul 2022 10:16:40 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZHeXB6pKpcMJ for ; Fri, 22 Jul 2022 10:16:39 -0400 (EDT) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 0FBF94CD89 for ; Fri, 22 Jul 2022 10:16:38 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C3B5B6207B; Fri, 22 Jul 2022 14:16:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B7B1C341C6; Fri, 22 Jul 2022 14:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658499397; bh=qPci77WK/98/z0Cyg/1FZengXU7A1Tr9GDGL2oMHA0M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VQuQTeCEljHzEjJXz4qGxwKYrcgTdErLguIV6/4HKkpKoeCVIjSS0uv4pb2wvi1IK bHat0KgKoTn8ZmQA0QM7Xtc58ZnG+QHHbVxlaalI324Z8MM58OSogUO9xixlT/pYqY WTUY5o2m2IWAhK7ubI5zNin0z5/lmMlSXnCPIR4ekta45lejAK3soV79PlOezX3wxa w8hcjECHGr2MIJJom2Jlg7tTyRVHYA3ub9R2auvu0D38tWkp22THyNfc/R1OtypSkJ wxf2gaxDERD9CxJkocrr0j6/U3YJmhiwDH+AVIkutn7mSUfh3VITPIpoxvL3+D7+28 LLc/b2d+pdf/w== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oEtSF-009MCL-0a; Fri, 22 Jul 2022 15:16:35 +0100 Date: Fri, 22 Jul 2022 15:16:34 +0100 Message-ID: <87leslxmf1.wl-maz@kernel.org> From: Marc Zyngier To: Peter Collingbourne Subject: Re: [PATCH v2 3/7] mm: Add PG_arch_3 page flag In-Reply-To: <20220722015034.809663-4-pcc@google.com> References: <20220722015034.809663-1-pcc@google.com> <20220722015034.809663-4-pcc@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pcc@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, cohuck@redhat.com, catalin.marinas@arm.com, will@kernel.org, eugenis@google.com, kvm@vger.kernel.org, steven.price@arm.com, vincenzo.frascino@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, Catalin Marinas , Cornelia Huck , Steven Price , linux-arm-kernel@lists.infradead.org, Vincenzo Frascino , Will Deacon , kvmarm@lists.cs.columbia.edu, Evgenii Stepanov X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, 22 Jul 2022 02:50:29 +0100, Peter Collingbourne wrote: > > As with PG_arch_2, this flag is only allowed on 64-bit architectures due > to the shortage of bits available. It will be used by the arm64 MTE code > in subsequent patches. > > Signed-off-by: Peter Collingbourne > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Steven Price > [catalin.marinas@arm.com: added flag preserving in __split_huge_page_tail()] > Signed-off-by: Catalin Marinas > --- > fs/proc/page.c | 1 + > include/linux/page-flags.h | 1 + > include/trace/events/mmflags.h | 7 ++++--- > mm/huge_memory.c | 1 + > 4 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/fs/proc/page.c b/fs/proc/page.c > index a2873a617ae8..438b8aa7249d 100644 > --- a/fs/proc/page.c > +++ b/fs/proc/page.c > @@ -220,6 +220,7 @@ u64 stable_page_flags(struct page *page) > u |= kpf_copy_bit(k, KPF_ARCH, PG_arch_1); > #ifdef CONFIG_64BIT > u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_2); > + u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_3); Are PG_arch_2 and PG_arch_3 supposed to share the same user bit in /proc/kpageflags? This seems odd. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4F23CCA473 for ; Fri, 22 Jul 2022 14:17:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CzLA/dDwEBez/1X+F7IbXQFz+d0m3Xk5yI6qiVWdCLc=; b=2/Xp0Fnus3wzOr NPaCHB5CPzE3+Cea9PqPGKLwY8isx/lgcijFdRlWfuFi3CEXZpn4StJwy6dWsUYeWZ/NUfi6BxKH1 N9msENonMSNCmtJAccEe+INkmZs4j4umLq8YvxcFxZ/HhtT+ffexhnlQDQ2/glM9DuPJgRsRTNkFl t+VJl5O+OSD/d+vW4IhCKQzLupTnmHl0cp7sgAylpL0Ce0iuA9s2UdvWqBdshDBm5Klg9H+yE/A+r H6lwe/yRZm9IfP/0N8pNJY42Lq+4DXmD+AIkWGmVK1zFEgtuLBTIF37LjTxCVZ1YtPSWz9gnztjTV bIBBIXl7EpM73ewqQA0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEtSQ-005uiQ-Mb; Fri, 22 Jul 2022 14:16:46 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEtSN-005uXc-DL for linux-arm-kernel@lists.infradead.org; Fri, 22 Jul 2022 14:16:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C3B5B6207B; Fri, 22 Jul 2022 14:16:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B7B1C341C6; Fri, 22 Jul 2022 14:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658499397; bh=qPci77WK/98/z0Cyg/1FZengXU7A1Tr9GDGL2oMHA0M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VQuQTeCEljHzEjJXz4qGxwKYrcgTdErLguIV6/4HKkpKoeCVIjSS0uv4pb2wvi1IK bHat0KgKoTn8ZmQA0QM7Xtc58ZnG+QHHbVxlaalI324Z8MM58OSogUO9xixlT/pYqY WTUY5o2m2IWAhK7ubI5zNin0z5/lmMlSXnCPIR4ekta45lejAK3soV79PlOezX3wxa w8hcjECHGr2MIJJom2Jlg7tTyRVHYA3ub9R2auvu0D38tWkp22THyNfc/R1OtypSkJ wxf2gaxDERD9CxJkocrr0j6/U3YJmhiwDH+AVIkutn7mSUfh3VITPIpoxvL3+D7+28 LLc/b2d+pdf/w== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oEtSF-009MCL-0a; Fri, 22 Jul 2022 15:16:35 +0100 Date: Fri, 22 Jul 2022 15:16:34 +0100 Message-ID: <87leslxmf1.wl-maz@kernel.org> From: Marc Zyngier To: Peter Collingbourne Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Cornelia Huck , Catalin Marinas , Will Deacon , Evgenii Stepanov , kvm@vger.kernel.org, Steven Price , Vincenzo Frascino Subject: Re: [PATCH v2 3/7] mm: Add PG_arch_3 page flag In-Reply-To: <20220722015034.809663-4-pcc@google.com> References: <20220722015034.809663-1-pcc@google.com> <20220722015034.809663-4-pcc@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pcc@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, cohuck@redhat.com, catalin.marinas@arm.com, will@kernel.org, eugenis@google.com, kvm@vger.kernel.org, steven.price@arm.com, vincenzo.frascino@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220722_071643_510551_E938200B X-CRM114-Status: GOOD ( 20.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 22 Jul 2022 02:50:29 +0100, Peter Collingbourne wrote: > > As with PG_arch_2, this flag is only allowed on 64-bit architectures due > to the shortage of bits available. It will be used by the arm64 MTE code > in subsequent patches. > > Signed-off-by: Peter Collingbourne > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Steven Price > [catalin.marinas@arm.com: added flag preserving in __split_huge_page_tail()] > Signed-off-by: Catalin Marinas > --- > fs/proc/page.c | 1 + > include/linux/page-flags.h | 1 + > include/trace/events/mmflags.h | 7 ++++--- > mm/huge_memory.c | 1 + > 4 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/fs/proc/page.c b/fs/proc/page.c > index a2873a617ae8..438b8aa7249d 100644 > --- a/fs/proc/page.c > +++ b/fs/proc/page.c > @@ -220,6 +220,7 @@ u64 stable_page_flags(struct page *page) > u |= kpf_copy_bit(k, KPF_ARCH, PG_arch_1); > #ifdef CONFIG_64BIT > u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_2); > + u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_3); Are PG_arch_2 and PG_arch_3 supposed to share the same user bit in /proc/kpageflags? This seems odd. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44EBFC43334 for ; Fri, 22 Jul 2022 14:16:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235229AbiGVOQk (ORCPT ); Fri, 22 Jul 2022 10:16:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233115AbiGVOQj (ORCPT ); Fri, 22 Jul 2022 10:16:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF4F5A026A for ; Fri, 22 Jul 2022 07:16:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3D6F962096 for ; Fri, 22 Jul 2022 14:16:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B7B1C341C6; Fri, 22 Jul 2022 14:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658499397; bh=qPci77WK/98/z0Cyg/1FZengXU7A1Tr9GDGL2oMHA0M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VQuQTeCEljHzEjJXz4qGxwKYrcgTdErLguIV6/4HKkpKoeCVIjSS0uv4pb2wvi1IK bHat0KgKoTn8ZmQA0QM7Xtc58ZnG+QHHbVxlaalI324Z8MM58OSogUO9xixlT/pYqY WTUY5o2m2IWAhK7ubI5zNin0z5/lmMlSXnCPIR4ekta45lejAK3soV79PlOezX3wxa w8hcjECHGr2MIJJom2Jlg7tTyRVHYA3ub9R2auvu0D38tWkp22THyNfc/R1OtypSkJ wxf2gaxDERD9CxJkocrr0j6/U3YJmhiwDH+AVIkutn7mSUfh3VITPIpoxvL3+D7+28 LLc/b2d+pdf/w== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oEtSF-009MCL-0a; Fri, 22 Jul 2022 15:16:35 +0100 Date: Fri, 22 Jul 2022 15:16:34 +0100 Message-ID: <87leslxmf1.wl-maz@kernel.org> From: Marc Zyngier To: Peter Collingbourne Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Cornelia Huck , Catalin Marinas , Will Deacon , Evgenii Stepanov , kvm@vger.kernel.org, Steven Price , Vincenzo Frascino Subject: Re: [PATCH v2 3/7] mm: Add PG_arch_3 page flag In-Reply-To: <20220722015034.809663-4-pcc@google.com> References: <20220722015034.809663-1-pcc@google.com> <20220722015034.809663-4-pcc@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pcc@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, cohuck@redhat.com, catalin.marinas@arm.com, will@kernel.org, eugenis@google.com, kvm@vger.kernel.org, steven.price@arm.com, vincenzo.frascino@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, 22 Jul 2022 02:50:29 +0100, Peter Collingbourne wrote: > > As with PG_arch_2, this flag is only allowed on 64-bit architectures due > to the shortage of bits available. It will be used by the arm64 MTE code > in subsequent patches. > > Signed-off-by: Peter Collingbourne > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Steven Price > [catalin.marinas@arm.com: added flag preserving in __split_huge_page_tail()] > Signed-off-by: Catalin Marinas > --- > fs/proc/page.c | 1 + > include/linux/page-flags.h | 1 + > include/trace/events/mmflags.h | 7 ++++--- > mm/huge_memory.c | 1 + > 4 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/fs/proc/page.c b/fs/proc/page.c > index a2873a617ae8..438b8aa7249d 100644 > --- a/fs/proc/page.c > +++ b/fs/proc/page.c > @@ -220,6 +220,7 @@ u64 stable_page_flags(struct page *page) > u |= kpf_copy_bit(k, KPF_ARCH, PG_arch_1); > #ifdef CONFIG_64BIT > u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_2); > + u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_3); Are PG_arch_2 and PG_arch_3 supposed to share the same user bit in /proc/kpageflags? This seems odd. M. -- Without deviation from the norm, progress is not possible.