From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/iptables: drop duplicated dependency
Date: Sun, 19 Jun 2022 14:36:15 +0200 [thread overview]
Message-ID: <87letsu8xs.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220617204210.12026-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Fri, 17 Jun 2022 22:42:10 +0200")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> libnetfilter_conntrack dependency is wrongly duplicated since commit
> b835171cf9db23095c669b872dbaa15fc1e99898
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/iptables/iptables.mk | 5 -----
> 1 file changed, 5 deletions(-)
> diff --git a/package/iptables/iptables.mk b/package/iptables/iptables.mk
> index a54194a8c3..682e23a091 100644
> --- a/package/iptables/iptables.mk
> +++ b/package/iptables/iptables.mk
> @@ -19,11 +19,6 @@ IPTABLES_SELINUX_MODULES = iptables
> IPTABLES_CONF_OPTS = --libexecdir=/usr/lib --with-kernel=$(STAGING_DIR)/usr \
> $(if $(BR2_STATIC_LIBS),,--disable-static)
> -# For connlabel match
> -ifeq ($(BR2_PACKAGE_LIBNETFILTER_CONNTRACK),y)
> -IPTABLES_DEPENDENCIES += libnetfilter_conntrack
> -endif
I think it is nicer to instead drop it from the "main" _DEPENDENCIES
line for consistency with the other optional dependencies, so I've
committed with that change, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-06-19 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 20:42 [Buildroot] [PATCH 1/1] package/iptables: drop duplicated dependency Fabrice Fontaine
2022-06-19 12:36 ` Peter Korsgaard [this message]
2022-07-19 15:09 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87letsu8xs.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.