From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DFCDC433F5 for ; Mon, 14 Mar 2022 17:50:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 314E310E2F1; Mon, 14 Mar 2022 17:50:32 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2EAD10E1CF; Mon, 14 Mar 2022 17:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647280230; x=1678816230; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=0mqtM7Adkh24NjsJkV9lZzRBLanfOzR93YwqfCzHxDU=; b=Jp7pEq6obm3VJ7KUEYsZphnGjKE7GjIHEUaegueUeCw1LFfBjjFqCecF 6Swh6tvuQo0UAdqhBB/qmHOAAvzd0Idj2wUGQ3l+TRpDJMrBv2pSN9Pjl YADZacoWyBs7IoKxgNVw4+05kr8hFsK1OMmLKZ4SRh5dWQ5T07yFUWAlx MzBbKhrlxuFWbLBtLluXXPEL3wy7Syv8vhuadBSkx0yZDBDQMeZqiG7ro IHXX/bdaV0C48mmqGBeRzW4OyP/Rqq25Xc3xIcO1C/Ja4h80qd2SZkO0F bWDB3PU3zH3eDMdTiq78Mik4u9UJ5C76SmJ9Oy9ERwWjX7a4rX+Dd+Ato Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10285"; a="319321166" X-IronPort-AV: E=Sophos;i="5.90,181,1643702400"; d="scan'208";a="319321166" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2022 10:50:29 -0700 X-IronPort-AV: E=Sophos;i="5.90,181,1643702400"; d="scan'208";a="580201841" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.253.138]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2022 10:50:29 -0700 Date: Mon, 14 Mar 2022 10:50:28 -0700 Message-ID: <87lexcpgnv.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Tvrtko Ursulin In-Reply-To: <025a284f-a1fc-3f7a-12eb-d5a4029e3393@linux.intel.com> References: <20220310051853.30440-1-matthew.s.atwood@intel.com> <16c7053b-1773-f1d8-ae7d-904d418b869b@linux.intel.com> <20220312041624.GA18367@msatwood-mobl> <025a284f-a1fc-3f7a-12eb-d5a4029e3393@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 14 Mar 2022 08:35:17 -0700, Tvrtko Ursulin wrote: > > >> Alternatively, all other uapi uses struct i915_engine_class_instance to > >> address engines which uses u16:u16. > >> > >> How ugly it is to stuff a struct into u32 flags is the question... But you > >> could at least use u16:u16 for consistency. Unless you wanted to leave some > >> bits free for the future? > > Originally when I wrote this I was wanting to leave space in case it was > > ever needed. I'm not particularly for or against keeping the space now. > > Yes, shrug... Neither I can't guess if we are ever likely to hit a problem > by having fewer bits for class:instance here compared to other uapi, or if > stuffing struct i915_engine_class_instance into flags would just be too > ugly. I mean there is option to define a new struct and not use flags at > all but that's probably to complicated for what it is. > > Anyone else with an opinion? Consistency or should be fine even like it is? Consistency. I'd prefer to stuff struct i915_engine_class_instance into flags, fwiw. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5168C433EF for ; Mon, 14 Mar 2022 17:50:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2666D10E22A; Mon, 14 Mar 2022 17:50:31 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2EAD10E1CF; Mon, 14 Mar 2022 17:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647280230; x=1678816230; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=0mqtM7Adkh24NjsJkV9lZzRBLanfOzR93YwqfCzHxDU=; b=Jp7pEq6obm3VJ7KUEYsZphnGjKE7GjIHEUaegueUeCw1LFfBjjFqCecF 6Swh6tvuQo0UAdqhBB/qmHOAAvzd0Idj2wUGQ3l+TRpDJMrBv2pSN9Pjl YADZacoWyBs7IoKxgNVw4+05kr8hFsK1OMmLKZ4SRh5dWQ5T07yFUWAlx MzBbKhrlxuFWbLBtLluXXPEL3wy7Syv8vhuadBSkx0yZDBDQMeZqiG7ro IHXX/bdaV0C48mmqGBeRzW4OyP/Rqq25Xc3xIcO1C/Ja4h80qd2SZkO0F bWDB3PU3zH3eDMdTiq78Mik4u9UJ5C76SmJ9Oy9ERwWjX7a4rX+Dd+Ato Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10285"; a="319321166" X-IronPort-AV: E=Sophos;i="5.90,181,1643702400"; d="scan'208";a="319321166" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2022 10:50:29 -0700 X-IronPort-AV: E=Sophos;i="5.90,181,1643702400"; d="scan'208";a="580201841" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.253.138]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2022 10:50:29 -0700 Date: Mon, 14 Mar 2022 10:50:28 -0700 Message-ID: <87lexcpgnv.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Tvrtko Ursulin Subject: Re: [Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES In-Reply-To: <025a284f-a1fc-3f7a-12eb-d5a4029e3393@linux.intel.com> References: <20220310051853.30440-1-matthew.s.atwood@intel.com> <16c7053b-1773-f1d8-ae7d-904d418b869b@linux.intel.com> <20220312041624.GA18367@msatwood-mobl> <025a284f-a1fc-3f7a-12eb-d5a4029e3393@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Matt Atwood , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 14 Mar 2022 08:35:17 -0700, Tvrtko Ursulin wrote: > > >> Alternatively, all other uapi uses struct i915_engine_class_instance to > >> address engines which uses u16:u16. > >> > >> How ugly it is to stuff a struct into u32 flags is the question... But you > >> could at least use u16:u16 for consistency. Unless you wanted to leave some > >> bits free for the future? > > Originally when I wrote this I was wanting to leave space in case it was > > ever needed. I'm not particularly for or against keeping the space now. > > Yes, shrug... Neither I can't guess if we are ever likely to hit a problem > by having fewer bits for class:instance here compared to other uapi, or if > stuffing struct i915_engine_class_instance into flags would just be too > ugly. I mean there is option to define a new struct and not use flags at > all but that's probably to complicated for what it is. > > Anyone else with an opinion? Consistency or should be fine even like it is? Consistency. I'd prefer to stuff struct i915_engine_class_instance into flags, fwiw.