From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F07AC433EF for ; Thu, 10 Feb 2022 19:06:08 +0000 (UTC) Received: from localhost ([::1]:33186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIEla-0004Ff-TE for qemu-devel@archiver.kernel.org; Thu, 10 Feb 2022 14:06:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIBoA-00025z-NE for qemu-devel@nongnu.org; Thu, 10 Feb 2022 10:56:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52667) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIBo8-0004eH-6L for qemu-devel@nongnu.org; Thu, 10 Feb 2022 10:56:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644508590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nh4FdtyDOewhhWmQhkLhBXhRZdUKM6eB/fhg0SYmslw=; b=RMgEmowAWYKeGHUmnr8Uij1Ha+CNAX8WRAXXvS1jrSPptcaB9CLFRvSZ/sQWpLDJORs6E8 pVRprI60eO09AbcCkV0dqLM+Pd2wKW9ixceN8IRLFTERAgHVLEi5Bi8WK/3/CnntjlRihX 9wcOZRMovBu3McpVP31KCgVFniZAqno= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-480-lydtwJiZM92VP5IDWOP_dw-1; Thu, 10 Feb 2022 10:56:23 -0500 X-MC-Unique: lydtwJiZM92VP5IDWOP_dw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9078785EE63; Thu, 10 Feb 2022 15:56:22 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6140E2B5A3; Thu, 10 Feb 2022 15:56:22 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D152121E6A00; Thu, 10 Feb 2022 16:56:20 +0100 (CET) From: Markus Armbruster To: John Snow Subject: Re: [PATCH] scripts/qapi: minor delinting References: <20220204225230.2114135-1-jsnow@redhat.com> Date: Thu, 10 Feb 2022 16:56:20 +0100 In-Reply-To: <20220204225230.2114135-1-jsnow@redhat.com> (John Snow's message of "Fri, 4 Feb 2022 17:52:30 -0500") Message-ID: <87leyibtqz.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > Just cleaning up some cobwebs. > > Signed-off-by: John Snow > --- > scripts/qapi/commands.py | 2 +- > scripts/qapi/events.py | 6 +++--- > scripts/qapi/types.py | 6 +++++- > scripts/qapi/visit.py | 6 +++++- > 4 files changed, 14 insertions(+), 6 deletions(-) > > diff --git a/scripts/qapi/commands.py b/scripts/qapi/commands.py > index 869d799ed2..38ca38a7b9 100644 > --- a/scripts/qapi/commands.py > +++ b/scripts/qapi/commands.py > @@ -25,8 +25,8 @@ > QAPIGenC, > QAPISchemaModularCVisitor, > build_params, > - ifcontext, > gen_special_features, > + ifcontext, > ) > from .schema import ( > QAPISchema, > diff --git a/scripts/qapi/events.py b/scripts/qapi/events.py > index 27b44c49f5..8edf43d8da 100644 > --- a/scripts/qapi/events.py > +++ b/scripts/qapi/events.py > @@ -109,15 +109,15 @@ def gen_event_send(name: str, > if not boxed: > ret += gen_param_var(arg_type) > > - for f in features: > - if f.is_special(): > + for feat in features: > + if feat.is_special(): > ret += mcgen(''' > > if (compat_policy.%(feat)s_output == COMPAT_POLICY_OUTPUT_HIDE) { > return; > } > ''', > - feat=f.name) > + feat=feat.name) > > ret += mcgen(''' > Meh. Expressive variable names are good when there's something useful to express. But what's the added value in such a simple, obvious loop? Besides: $ git-grep 'for . in' scripts/qapi | wc -l 42 $ git-grep -E 'for [A-Za-z0-9]{2,} in' scripts/qapi | wc -l 31 > diff --git a/scripts/qapi/types.py b/scripts/qapi/types.py > index 3013329c24..477d027001 100644 > --- a/scripts/qapi/types.py > +++ b/scripts/qapi/types.py > @@ -16,7 +16,11 @@ > from typing import List, Optional > > from .common import c_enum_const, c_name, mcgen > -from .gen import QAPISchemaModularCVisitor, gen_special_features, ifcontext > +from .gen import ( > + QAPISchemaModularCVisitor, > + gen_special_features, > + ifcontext, > +) > from .schema import ( > QAPISchema, > QAPISchemaEnumMember, > diff --git a/scripts/qapi/visit.py b/scripts/qapi/visit.py > index e13bbe4292..380fa197f5 100644 > --- a/scripts/qapi/visit.py > +++ b/scripts/qapi/visit.py > @@ -21,7 +21,11 @@ > indent, > mcgen, > ) > -from .gen import QAPISchemaModularCVisitor, gen_special_features, ifcontext > +from .gen import ( > + QAPISchemaModularCVisitor, > + gen_special_features, > + ifcontext, > +) > from .schema import ( > QAPISchema, > QAPISchemaEnumMember, Everything else, gladly Reviewed-by: Markus Armbruster