From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: kwolf@redhat.com, michael.roth@amd.com, qemu-devel@nongnu.org,
hreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com,
jsnow@redhat.com
Subject: Re: [PATCH v5 7/7] qapi: generate trace events by default
Date: Wed, 26 Jan 2022 15:04:37 +0100 [thread overview]
Message-ID: <87lez2twy2.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20220125215655.3111881-8-vsementsov@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Tue, 25 Jan 2022 22:56:55 +0100")
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> We don't generate trace events for tests/ and qga/ because that it is
> not simple and not necessary. We have corresponding comments in both
> tests/meson.build and qga/meson.build.
>
> Still to not miss possible future qapi code generation call, and not to
> forget to enable trace events generation, let's enable it by default.
> So, turn option --gen-trace into opposite --no-trace-events and use new
Let's call it --suppress-tracing.
> option only in tests/ and qga/ where we already have good comments why
> we don't generate trace events code.
>
> Note that this commit enables trace-events generation for qapi-gen.py
> call from tests/qapi-schema/meson.build and storage-daemon/meson.build.
> Still, both are kind of noop: tests/qapi-schema/ doesn't seem to
> generate any QMP command code and no .trace-events files anyway,
> storage-daemon/ uses common QMP command implementations and just
> generate empty .trace-events
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
next prev parent reply other threads:[~2022-01-26 14:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 21:56 [PATCH v5 0/7] trace qmp commands Vladimir Sementsov-Ogievskiy
2022-01-25 21:56 ` [PATCH v5 1/7] scripts/qapi/gen.py: add FOO.trace-events output module Vladimir Sementsov-Ogievskiy
2022-01-26 13:20 ` Stefan Hajnoczi
2022-01-26 14:32 ` Markus Armbruster
2022-01-26 14:03 ` Markus Armbruster
2022-01-25 21:56 ` [PATCH v5 2/7] qapi/commands: refactor error handling code Vladimir Sementsov-Ogievskiy
2022-01-25 21:56 ` [PATCH v5 3/7] qapi/commands: Optionally generate trace for QMP commands Vladimir Sementsov-Ogievskiy
2022-01-26 14:03 ` Markus Armbruster
2022-01-25 21:56 ` [PATCH v5 4/7] meson: generate trace events for qmp commands Vladimir Sementsov-Ogievskiy
2022-01-25 21:56 ` [PATCH v5 5/7] docs/qapi-code-gen: update to cover trace events code generation Vladimir Sementsov-Ogievskiy
2022-01-26 14:24 ` Markus Armbruster
2022-01-25 21:56 ` [PATCH v5 6/7] meson: document, why we don't generate trace events for tests/ and qga/ Vladimir Sementsov-Ogievskiy
2022-01-26 13:33 ` Stefan Hajnoczi
2022-01-26 13:34 ` Stefan Hajnoczi
2022-01-26 14:04 ` Markus Armbruster
2022-01-25 21:56 ` [PATCH v5 7/7] qapi: generate trace events by default Vladimir Sementsov-Ogievskiy
2022-01-26 14:04 ` Markus Armbruster [this message]
2022-01-26 13:35 ` [PATCH v5 0/7] trace qmp commands Stefan Hajnoczi
2022-01-26 14:33 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lez2twy2.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.