From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id EB05110E968
 for <igt-dev@lists.freedesktop.org>; Mon, 24 Jan 2022 19:07:08 +0000 (UTC)
Date: Mon, 24 Jan 2022 11:07:07 -0800
Message-ID: <87lez5osv8.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <20220124023833.13535-1-chuansheng.liu@intel.com>
References: <20220124023833.13535-1-chuansheng.liu@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_busy: Prevent context ban with
 right ctx id
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Chuansheng Liu <chuansheng.liu@intel.com>
Cc: igt-dev@lists.freedesktop.org
List-ID: <igt-dev@lists.freedesktop.org>

On Sun, 23 Jan 2022 18:38:33 -0800, Chuansheng Liu wrote:
>
> When running multiple hang tests, the code is intended to
> disallow context ban at first, but it is always with fix
> ctx id 0. It will cause below test failures when running
> the test gem_busy:
>
> --
> tarting dynamic subtest: vcs0
> (gem_busy:18571) ioctl_wrappers-CRITICAL: Test assertion failure
> function gem_execbuf_wr, file ../lib/ioctl_wrappers.c:706:
> (gem_busy:18571) ioctl_wrappers-CRITICAL: Failed assertion:
> __gem_execbuf_wr(fd, execbuf) == 0
> (gem_busy:18571) ioctl_wrappers-CRITICAL: error: -5 != 0
> --
>
> -5 (EIO) means the context is banned and can not be used for
> execution.
>
> This patch corrects the ctx id accordindly. Furthermore,
> there are other code places with similar mistakes, will
> try to send out the fixes further.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>

The SOB I think should be with the top description otherwise SOB is dropped
when we apply the patch. Anyway I've fixed it up and merged it this
time. Thanks for the patch.