From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A555C433EF for ; Mon, 13 Dec 2021 13:34:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 01DC310E8F8; Mon, 13 Dec 2021 13:34:22 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E8B110E8E2; Mon, 13 Dec 2021 13:34:20 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10196"; a="238675399" X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="238675399" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 05:34:19 -0800 X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="517751011" Received: from ppolasze-mobl.ger.corp.intel.com (HELO localhost) ([10.252.20.7]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 05:34:15 -0800 From: Jani Nikula To: Thomas Zimmermann , mripard@kernel.org, maarten.lankhorst@linux.intel.com, airlied@linux.ie, daniel@ffwll.ch In-Reply-To: <20211213093650.19598-1-tzimmermann@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20211213093650.19598-1-tzimmermann@suse.de> Date: Mon, 13 Dec 2021 15:34:12 +0200 Message-ID: <87lf0o7hnv.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Thomas Zimmermann , linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 13 Dec 2021, Thomas Zimmermann wrote: > Split-off DisplayPort functions from KMS helper library and move them > into their own module. Reduces the size of drm_kms_helper.ko by ~50%. > > This patchset is part of an on-going effort to reduce the minimum > binary size of the DRM core and helpers. It's helpful for systems with > early-boot DRM graphics, which requires DRM to be linked into the > kernel image. Would it be time to add a subdirectory for each non-driver, non-core drm module? We've touched this topic before. I find it increasingly hard to remember which files are part of helpers. This would also help with the arbitrary drm_dp_helper_mod.c naming. Perhaps drivers/gpu/drm/drm_dp/? BR, Jani. > > Thomas Zimmermann (3): > drm/dp_mst: Remove trailing whitespace. > drm/dp: Move DP declarations into separate header file > drm/dp: Move DisplayPort helpers into separate helper module > > drivers/gpu/drm/Kconfig | 8 ++++++ > drivers/gpu/drm/Makefile | 14 ++++++---- > drivers/gpu/drm/bridge/Kconfig | 4 +++ > drivers/gpu/drm/bridge/analogix/Kconfig | 2 ++ > drivers/gpu/drm/bridge/cadence/Kconfig | 1 + > drivers/gpu/drm/drm_crtc_helper_internal.h | 27 ------------------ > drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} | 2 +- > drivers/gpu/drm/drm_dp_aux_dev.c | 2 +- > drivers/gpu/drm/drm_dp_helper_internal.h | 28 +++++++++++++++++++ > drivers/gpu/drm/drm_dp_helper_mod.c | 22 +++++++++++++++ > drivers/gpu/drm/drm_dp_mst_topology.c | 4 +-- > drivers/gpu/drm/drm_kms_helper_common.c | 14 ---------- > drivers/gpu/drm/i915/Kconfig | 1 + > drivers/gpu/drm/msm/Kconfig | 1 + > drivers/gpu/drm/nouveau/Kconfig | 1 + > drivers/gpu/drm/rockchip/Kconfig | 1 + > drivers/gpu/drm/tegra/Kconfig | 1 + > drivers/gpu/drm/xlnx/Kconfig | 1 + > 18 files changed, 83 insertions(+), 51 deletions(-) > rename drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} (99%) > create mode 100644 drivers/gpu/drm/drm_dp_helper_internal.h > create mode 100644 drivers/gpu/drm/drm_dp_helper_mod.c > > > base-commit: 3f422828221d9ceefcddef0be33561b1646a1cbe > prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d > prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 > -- > 2.34.1 > -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317E8C433EF for ; Mon, 13 Dec 2021 13:34:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237653AbhLMNeU (ORCPT ); Mon, 13 Dec 2021 08:34:20 -0500 Received: from mga14.intel.com ([192.55.52.115]:64854 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237638AbhLMNeU (ORCPT ); Mon, 13 Dec 2021 08:34:20 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10196"; a="238954425" X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="238954425" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 05:34:19 -0800 X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="517751011" Received: from ppolasze-mobl.ger.corp.intel.com (HELO localhost) ([10.252.20.7]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 05:34:15 -0800 From: Jani Nikula To: Thomas Zimmermann , mripard@kernel.org, maarten.lankhorst@linux.intel.com, airlied@linux.ie, daniel@ffwll.ch Cc: linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Thomas Zimmermann , nouveau@lists.freedesktop.org, linux-tegra@vger.kernel.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module In-Reply-To: <20211213093650.19598-1-tzimmermann@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20211213093650.19598-1-tzimmermann@suse.de> Date: Mon, 13 Dec 2021 15:34:12 +0200 Message-ID: <87lf0o7hnv.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, 13 Dec 2021, Thomas Zimmermann wrote: > Split-off DisplayPort functions from KMS helper library and move them > into their own module. Reduces the size of drm_kms_helper.ko by ~50%. > > This patchset is part of an on-going effort to reduce the minimum > binary size of the DRM core and helpers. It's helpful for systems with > early-boot DRM graphics, which requires DRM to be linked into the > kernel image. Would it be time to add a subdirectory for each non-driver, non-core drm module? We've touched this topic before. I find it increasingly hard to remember which files are part of helpers. This would also help with the arbitrary drm_dp_helper_mod.c naming. Perhaps drivers/gpu/drm/drm_dp/? BR, Jani. > > Thomas Zimmermann (3): > drm/dp_mst: Remove trailing whitespace. > drm/dp: Move DP declarations into separate header file > drm/dp: Move DisplayPort helpers into separate helper module > > drivers/gpu/drm/Kconfig | 8 ++++++ > drivers/gpu/drm/Makefile | 14 ++++++---- > drivers/gpu/drm/bridge/Kconfig | 4 +++ > drivers/gpu/drm/bridge/analogix/Kconfig | 2 ++ > drivers/gpu/drm/bridge/cadence/Kconfig | 1 + > drivers/gpu/drm/drm_crtc_helper_internal.h | 27 ------------------ > drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} | 2 +- > drivers/gpu/drm/drm_dp_aux_dev.c | 2 +- > drivers/gpu/drm/drm_dp_helper_internal.h | 28 +++++++++++++++++++ > drivers/gpu/drm/drm_dp_helper_mod.c | 22 +++++++++++++++ > drivers/gpu/drm/drm_dp_mst_topology.c | 4 +-- > drivers/gpu/drm/drm_kms_helper_common.c | 14 ---------- > drivers/gpu/drm/i915/Kconfig | 1 + > drivers/gpu/drm/msm/Kconfig | 1 + > drivers/gpu/drm/nouveau/Kconfig | 1 + > drivers/gpu/drm/rockchip/Kconfig | 1 + > drivers/gpu/drm/tegra/Kconfig | 1 + > drivers/gpu/drm/xlnx/Kconfig | 1 + > 18 files changed, 83 insertions(+), 51 deletions(-) > rename drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} (99%) > create mode 100644 drivers/gpu/drm/drm_dp_helper_internal.h > create mode 100644 drivers/gpu/drm/drm_dp_helper_mod.c > > > base-commit: 3f422828221d9ceefcddef0be33561b1646a1cbe > prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d > prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 > -- > 2.34.1 > -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADCC0C433F5 for ; Mon, 13 Dec 2021 13:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PgqS0clpUxFpYz5UX868+KTKEE0Kvo2bZM9ESnufV7A=; b=x0TSYca5rpx7pv /6ytdEvfaSgJTMS0OPYl0YIQ80ywMLNEEDHYCbjSdyOohyckDgi7bLN8JVANWNQFCWBELvv5aDXQS aNvcEs+gQrvX7kDT1rd5cNesIX7m0gtVhpIsDwH5oypCVeQG9Z2U4KaD/zvX9890fIyvC8yFj07ZG LUAEShlI9NcytabYjEblVQfZbL+MDvohz3Xa9dx8PrQQAuflFval/GVvfIRg9u4A2Xc1aNUnOaFEW /UizTzRWQR70FWdvMwSZxal7d1+iRhlxzMYooR+wnsnbyIYZADaxu4EOY/AqMEvxtW438ZAldhxMn uv8VVCynPWDNPEBDeURA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwlTW-009isU-1w; Mon, 13 Dec 2021 13:34:42 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwlTB-009iiW-Fc; Mon, 13 Dec 2021 13:34:22 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10196"; a="226007994" X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="226007994" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 05:34:19 -0800 X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="517751011" Received: from ppolasze-mobl.ger.corp.intel.com (HELO localhost) ([10.252.20.7]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 05:34:15 -0800 From: Jani Nikula To: Thomas Zimmermann , mripard@kernel.org, maarten.lankhorst@linux.intel.com, airlied@linux.ie, daniel@ffwll.ch Cc: linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Thomas Zimmermann , nouveau@lists.freedesktop.org, linux-tegra@vger.kernel.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module In-Reply-To: <20211213093650.19598-1-tzimmermann@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20211213093650.19598-1-tzimmermann@suse.de> Date: Mon, 13 Dec 2021 15:34:12 +0200 Message-ID: <87lf0o7hnv.fsf@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_053421_612023_2D50AE28 X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Mon, 13 Dec 2021, Thomas Zimmermann wrote: > Split-off DisplayPort functions from KMS helper library and move them > into their own module. Reduces the size of drm_kms_helper.ko by ~50%. > > This patchset is part of an on-going effort to reduce the minimum > binary size of the DRM core and helpers. It's helpful for systems with > early-boot DRM graphics, which requires DRM to be linked into the > kernel image. Would it be time to add a subdirectory for each non-driver, non-core drm module? We've touched this topic before. I find it increasingly hard to remember which files are part of helpers. This would also help with the arbitrary drm_dp_helper_mod.c naming. Perhaps drivers/gpu/drm/drm_dp/? BR, Jani. > > Thomas Zimmermann (3): > drm/dp_mst: Remove trailing whitespace. > drm/dp: Move DP declarations into separate header file > drm/dp: Move DisplayPort helpers into separate helper module > > drivers/gpu/drm/Kconfig | 8 ++++++ > drivers/gpu/drm/Makefile | 14 ++++++---- > drivers/gpu/drm/bridge/Kconfig | 4 +++ > drivers/gpu/drm/bridge/analogix/Kconfig | 2 ++ > drivers/gpu/drm/bridge/cadence/Kconfig | 1 + > drivers/gpu/drm/drm_crtc_helper_internal.h | 27 ------------------ > drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} | 2 +- > drivers/gpu/drm/drm_dp_aux_dev.c | 2 +- > drivers/gpu/drm/drm_dp_helper_internal.h | 28 +++++++++++++++++++ > drivers/gpu/drm/drm_dp_helper_mod.c | 22 +++++++++++++++ > drivers/gpu/drm/drm_dp_mst_topology.c | 4 +-- > drivers/gpu/drm/drm_kms_helper_common.c | 14 ---------- > drivers/gpu/drm/i915/Kconfig | 1 + > drivers/gpu/drm/msm/Kconfig | 1 + > drivers/gpu/drm/nouveau/Kconfig | 1 + > drivers/gpu/drm/rockchip/Kconfig | 1 + > drivers/gpu/drm/tegra/Kconfig | 1 + > drivers/gpu/drm/xlnx/Kconfig | 1 + > 18 files changed, 83 insertions(+), 51 deletions(-) > rename drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} (99%) > create mode 100644 drivers/gpu/drm/drm_dp_helper_internal.h > create mode 100644 drivers/gpu/drm/drm_dp_helper_mod.c > > > base-commit: 3f422828221d9ceefcddef0be33561b1646a1cbe > prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d > prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 > -- > 2.34.1 > -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56F54C433FE for ; Mon, 13 Dec 2021 13:34:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DAF3310E8F3; Mon, 13 Dec 2021 13:34:22 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E8B110E8E2; Mon, 13 Dec 2021 13:34:20 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10196"; a="238675399" X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="238675399" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 05:34:19 -0800 X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="517751011" Received: from ppolasze-mobl.ger.corp.intel.com (HELO localhost) ([10.252.20.7]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 05:34:15 -0800 From: Jani Nikula To: Thomas Zimmermann , mripard@kernel.org, maarten.lankhorst@linux.intel.com, airlied@linux.ie, daniel@ffwll.ch In-Reply-To: <20211213093650.19598-1-tzimmermann@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20211213093650.19598-1-tzimmermann@suse.de> Date: Mon, 13 Dec 2021 15:34:12 +0200 Message-ID: <87lf0o7hnv.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Nouveau] [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Mon, 13 Dec 2021, Thomas Zimmermann wrote: > Split-off DisplayPort functions from KMS helper library and move them > into their own module. Reduces the size of drm_kms_helper.ko by ~50%. > > This patchset is part of an on-going effort to reduce the minimum > binary size of the DRM core and helpers. It's helpful for systems with > early-boot DRM graphics, which requires DRM to be linked into the > kernel image. Would it be time to add a subdirectory for each non-driver, non-core drm module? We've touched this topic before. I find it increasingly hard to remember which files are part of helpers. This would also help with the arbitrary drm_dp_helper_mod.c naming. Perhaps drivers/gpu/drm/drm_dp/? BR, Jani. > > Thomas Zimmermann (3): > drm/dp_mst: Remove trailing whitespace. > drm/dp: Move DP declarations into separate header file > drm/dp: Move DisplayPort helpers into separate helper module > > drivers/gpu/drm/Kconfig | 8 ++++++ > drivers/gpu/drm/Makefile | 14 ++++++---- > drivers/gpu/drm/bridge/Kconfig | 4 +++ > drivers/gpu/drm/bridge/analogix/Kconfig | 2 ++ > drivers/gpu/drm/bridge/cadence/Kconfig | 1 + > drivers/gpu/drm/drm_crtc_helper_internal.h | 27 ------------------ > drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} | 2 +- > drivers/gpu/drm/drm_dp_aux_dev.c | 2 +- > drivers/gpu/drm/drm_dp_helper_internal.h | 28 +++++++++++++++++++ > drivers/gpu/drm/drm_dp_helper_mod.c | 22 +++++++++++++++ > drivers/gpu/drm/drm_dp_mst_topology.c | 4 +-- > drivers/gpu/drm/drm_kms_helper_common.c | 14 ---------- > drivers/gpu/drm/i915/Kconfig | 1 + > drivers/gpu/drm/msm/Kconfig | 1 + > drivers/gpu/drm/nouveau/Kconfig | 1 + > drivers/gpu/drm/rockchip/Kconfig | 1 + > drivers/gpu/drm/tegra/Kconfig | 1 + > drivers/gpu/drm/xlnx/Kconfig | 1 + > 18 files changed, 83 insertions(+), 51 deletions(-) > rename drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} (99%) > create mode 100644 drivers/gpu/drm/drm_dp_helper_internal.h > create mode 100644 drivers/gpu/drm/drm_dp_helper_mod.c > > > base-commit: 3f422828221d9ceefcddef0be33561b1646a1cbe > prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d > prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 > -- > 2.34.1 > -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 528C4C433F5 for ; Mon, 13 Dec 2021 13:35:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mtj2WbyTIMb5L0SvKo3GvLxgnL3obJxJdkcE6MwsO5E=; b=TxGktWq/UwUzav Nn1cOuYblJLyWE2TfoBz8K/Uvi3Y8Fhb721b6tVDGYnsuo45L6KzDFYHKerry/BeMO70DlYG9VGcg fX6N2xBRqCQ3A8HBqmaY8wNGp1WrFRNvCsQYdtPnpwKKfBl92k6+C4VJ2vjFOhyoeqIXGsKTJJo2W /uuV2lw9OGdrCfEIiypOcwkD3H8EFgXT0x9IOfsv8yLc3wjhE1GspcU2WrGtiSUXTQ9oh9dfTwMU6 VHhh8d8p34t/n7C+OrRVPRbA6yCKm8tTMNyyVt1IBWXT1PmhFT9caQV6rga8c1gK4sbGr7D2SB5Sl o4LsA+3adi4pLvQ/CwEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwlTI-009ilD-0M; Mon, 13 Dec 2021 13:34:28 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwlTB-009iiW-Fc; Mon, 13 Dec 2021 13:34:22 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10196"; a="226007994" X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="226007994" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 05:34:19 -0800 X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="517751011" Received: from ppolasze-mobl.ger.corp.intel.com (HELO localhost) ([10.252.20.7]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 05:34:15 -0800 From: Jani Nikula To: Thomas Zimmermann , mripard@kernel.org, maarten.lankhorst@linux.intel.com, airlied@linux.ie, daniel@ffwll.ch Cc: linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Thomas Zimmermann , nouveau@lists.freedesktop.org, linux-tegra@vger.kernel.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module In-Reply-To: <20211213093650.19598-1-tzimmermann@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20211213093650.19598-1-tzimmermann@suse.de> Date: Mon, 13 Dec 2021 15:34:12 +0200 Message-ID: <87lf0o7hnv.fsf@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_053421_612023_2D50AE28 X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 13 Dec 2021, Thomas Zimmermann wrote: > Split-off DisplayPort functions from KMS helper library and move them > into their own module. Reduces the size of drm_kms_helper.ko by ~50%. > > This patchset is part of an on-going effort to reduce the minimum > binary size of the DRM core and helpers. It's helpful for systems with > early-boot DRM graphics, which requires DRM to be linked into the > kernel image. Would it be time to add a subdirectory for each non-driver, non-core drm module? We've touched this topic before. I find it increasingly hard to remember which files are part of helpers. This would also help with the arbitrary drm_dp_helper_mod.c naming. Perhaps drivers/gpu/drm/drm_dp/? BR, Jani. > > Thomas Zimmermann (3): > drm/dp_mst: Remove trailing whitespace. > drm/dp: Move DP declarations into separate header file > drm/dp: Move DisplayPort helpers into separate helper module > > drivers/gpu/drm/Kconfig | 8 ++++++ > drivers/gpu/drm/Makefile | 14 ++++++---- > drivers/gpu/drm/bridge/Kconfig | 4 +++ > drivers/gpu/drm/bridge/analogix/Kconfig | 2 ++ > drivers/gpu/drm/bridge/cadence/Kconfig | 1 + > drivers/gpu/drm/drm_crtc_helper_internal.h | 27 ------------------ > drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} | 2 +- > drivers/gpu/drm/drm_dp_aux_dev.c | 2 +- > drivers/gpu/drm/drm_dp_helper_internal.h | 28 +++++++++++++++++++ > drivers/gpu/drm/drm_dp_helper_mod.c | 22 +++++++++++++++ > drivers/gpu/drm/drm_dp_mst_topology.c | 4 +-- > drivers/gpu/drm/drm_kms_helper_common.c | 14 ---------- > drivers/gpu/drm/i915/Kconfig | 1 + > drivers/gpu/drm/msm/Kconfig | 1 + > drivers/gpu/drm/nouveau/Kconfig | 1 + > drivers/gpu/drm/rockchip/Kconfig | 1 + > drivers/gpu/drm/tegra/Kconfig | 1 + > drivers/gpu/drm/xlnx/Kconfig | 1 + > 18 files changed, 83 insertions(+), 51 deletions(-) > rename drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} (99%) > create mode 100644 drivers/gpu/drm/drm_dp_helper_internal.h > create mode 100644 drivers/gpu/drm/drm_dp_helper_mod.c > > > base-commit: 3f422828221d9ceefcddef0be33561b1646a1cbe > prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d > prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 > -- > 2.34.1 > -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DDD3C433FE for ; Mon, 13 Dec 2021 13:34:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 078A310E8E2; Mon, 13 Dec 2021 13:34:21 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E8B110E8E2; Mon, 13 Dec 2021 13:34:20 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10196"; a="238675399" X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="238675399" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 05:34:19 -0800 X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="517751011" Received: from ppolasze-mobl.ger.corp.intel.com (HELO localhost) ([10.252.20.7]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 05:34:15 -0800 From: Jani Nikula To: Thomas Zimmermann , mripard@kernel.org, maarten.lankhorst@linux.intel.com, airlied@linux.ie, daniel@ffwll.ch Subject: Re: [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module In-Reply-To: <20211213093650.19598-1-tzimmermann@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20211213093650.19598-1-tzimmermann@suse.de> Date: Mon, 13 Dec 2021 15:34:12 +0200 Message-ID: <87lf0o7hnv.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Thomas Zimmermann , linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 13 Dec 2021, Thomas Zimmermann wrote: > Split-off DisplayPort functions from KMS helper library and move them > into their own module. Reduces the size of drm_kms_helper.ko by ~50%. > > This patchset is part of an on-going effort to reduce the minimum > binary size of the DRM core and helpers. It's helpful for systems with > early-boot DRM graphics, which requires DRM to be linked into the > kernel image. Would it be time to add a subdirectory for each non-driver, non-core drm module? We've touched this topic before. I find it increasingly hard to remember which files are part of helpers. This would also help with the arbitrary drm_dp_helper_mod.c naming. Perhaps drivers/gpu/drm/drm_dp/? BR, Jani. > > Thomas Zimmermann (3): > drm/dp_mst: Remove trailing whitespace. > drm/dp: Move DP declarations into separate header file > drm/dp: Move DisplayPort helpers into separate helper module > > drivers/gpu/drm/Kconfig | 8 ++++++ > drivers/gpu/drm/Makefile | 14 ++++++---- > drivers/gpu/drm/bridge/Kconfig | 4 +++ > drivers/gpu/drm/bridge/analogix/Kconfig | 2 ++ > drivers/gpu/drm/bridge/cadence/Kconfig | 1 + > drivers/gpu/drm/drm_crtc_helper_internal.h | 27 ------------------ > drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} | 2 +- > drivers/gpu/drm/drm_dp_aux_dev.c | 2 +- > drivers/gpu/drm/drm_dp_helper_internal.h | 28 +++++++++++++++++++ > drivers/gpu/drm/drm_dp_helper_mod.c | 22 +++++++++++++++ > drivers/gpu/drm/drm_dp_mst_topology.c | 4 +-- > drivers/gpu/drm/drm_kms_helper_common.c | 14 ---------- > drivers/gpu/drm/i915/Kconfig | 1 + > drivers/gpu/drm/msm/Kconfig | 1 + > drivers/gpu/drm/nouveau/Kconfig | 1 + > drivers/gpu/drm/rockchip/Kconfig | 1 + > drivers/gpu/drm/tegra/Kconfig | 1 + > drivers/gpu/drm/xlnx/Kconfig | 1 + > 18 files changed, 83 insertions(+), 51 deletions(-) > rename drivers/gpu/drm/{drm_dp_helper.c => drm_dp.c} (99%) > create mode 100644 drivers/gpu/drm/drm_dp_helper_internal.h > create mode 100644 drivers/gpu/drm/drm_dp_helper_mod.c > > > base-commit: 3f422828221d9ceefcddef0be33561b1646a1cbe > prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d > prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 > -- > 2.34.1 > -- Jani Nikula, Intel Open Source Graphics Center