From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F16F8C433EF for ; Tue, 7 Dec 2021 12:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LKIJBsnze4MEv95tm7FL1GGQLuaH7P/igu0WlI3fu7Y=; b=UGw24SPPOJJD+L LpR9hKPg1iWId5MSzP0wqQOjeKaZy2MyxIH8QPtah6kn++UZeHm+jqMhkS+UrulP+bp/oVyfjOOjC Kg32oetw31Pyw/Jd1+g4vvoBY5UsjGg+T6EYCwuK7BrqZtkoB2BRVtbE/a7RqPH//0Y3VZ1Eg5Gm6 gI/xzPsNoedeDV2XVdxvv5K6wKngxtM+53g/gbsQB5Kupcdva/S5go8bYH04cqL+o+T+I1HoZG0LZ 500gOHUgshVGUVCjeO6hBMULthOrlGqT1NnJ0ABkkDsaL3rD1EKKpMh2tTTuE4YYHJ3d+/XdEV8vx 6oOVYV3uU4nearzUJdlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muZze-008Yqd-T2; Tue, 07 Dec 2021 12:54:51 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muZzT-008Yns-JW for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 12:54:41 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8B024CE1AA3; Tue, 7 Dec 2021 12:54:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B94F1C341C1; Tue, 7 Dec 2021 12:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638881675; bh=0uBdWMVhKyYiag0ISYOZJSTPdbiWPkew+9HK4hpAZ8U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UTNs1kcIAfOyzoBL2bU+sUbhSqwzYJqJOgu8u7gRaMweKROcF7NxBEBbkW4uqI8d8 T2Qn9BKckDWwfv6z9GYOlxfOJJOExXMaIYOreZ9uL8wUqqS989dxBEWgS2fJ4YmWMx fH80NFZLEEGxvSUO4v7PBz68UjioUm5jPnyOKm8CAfyNFgSGWpcLtV9OHLjjnymUup ZVXonUyzfbIjBuDJ/gAewyTRVXoq5YdnfvnU3vWc1ImcdfgdlntLrisgx2vWce0o8N ZrCxebG4rWIFDWdhJtWCDeC9I4Ho+X9Q+UC10KqzW6jxiczXnypi67OfioNhtqD8K/ NKqrK6FcJgblQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1muZzN-00AVZo-CW; Tue, 07 Dec 2021 12:54:33 +0000 Date: Tue, 07 Dec 2021 12:54:32 +0000 Message-ID: <87lf0w1son.wl-maz@kernel.org> From: Marc Zyngier To: Joey Gouly Cc: , , , , , , , , Subject: Re: [PATCH v2 2/3] arm64: add ID_AA64ISAR2_EL1 sys register In-Reply-To: <20211207124226.50095-3-joey.gouly@arm.com> References: <20211207124226.50095-1-joey.gouly@arm.com> <20211207124226.50095-3-joey.gouly@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: joey.gouly@arm.com, linux-arm-kernel@lists.infradead.org, nd@arm.com, alexandru.elisei@arm.com, catalin.marinas@arm.com, corbet@lwn.net, james.morse@arm.com, reijiw@google.com, suzuki.poulose@arm.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211207_045440_068725_251993C0 X-CRM114-Status: GOOD ( 22.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Joey, On Tue, 07 Dec 2021 12:42:25 +0000, Joey Gouly wrote: > > This is a new ID register, introduced in 8.7. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: James Morse > Cc: Alexandru Elisei > Cc: Suzuki K Poulose > Cc: Reiji Watanabe > --- > arch/arm64/include/asm/cpu.h | 1 + > arch/arm64/include/asm/sysreg.h | 10 ++++++++++ > arch/arm64/kernel/cpufeature.c | 9 +++++++++ > arch/arm64/kernel/cpuinfo.c | 1 + > arch/arm64/kvm/sys_regs.c | 2 +- > 5 files changed, 22 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/cpu.h b/arch/arm64/include/asm/cpu.h > index 0f6d16faa540..a58e366f0b07 100644 > --- a/arch/arm64/include/asm/cpu.h > +++ b/arch/arm64/include/asm/cpu.h > @@ -51,6 +51,7 @@ struct cpuinfo_arm64 { > u64 reg_id_aa64dfr1; > u64 reg_id_aa64isar0; > u64 reg_id_aa64isar1; > + u64 reg_id_aa64isar2; > u64 reg_id_aa64mmfr0; > u64 reg_id_aa64mmfr1; > u64 reg_id_aa64mmfr2; > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index adcab9009f9d..5393a00340f5 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h > @@ -182,6 +182,7 @@ > > #define SYS_ID_AA64ISAR0_EL1 sys_reg(3, 0, 0, 6, 0) > #define SYS_ID_AA64ISAR1_EL1 sys_reg(3, 0, 0, 6, 1) > +#define SYS_ID_AA64ISAR2_EL1 sys_reg(3, 0, 0, 6, 2) > > #define SYS_ID_AA64MMFR0_EL1 sys_reg(3, 0, 0, 7, 0) > #define SYS_ID_AA64MMFR1_EL1 sys_reg(3, 0, 0, 7, 1) > @@ -771,6 +772,15 @@ > #define ID_AA64ISAR1_GPI_NI 0x0 > #define ID_AA64ISAR1_GPI_IMP_DEF 0x1 > > +/* id_aa64isar2 */ > +#define ID_AA64ISAR2_RPRES_SHIFT 4 > +#define ID_AA64ISAR2_WFXT_SHIFT 0 > + > +#define ID_AA64ISAR2_RPRES_8BIT 0x0 > +#define ID_AA64ISAR2_RPRES_12BIT 0x1 > +#define ID_AA64ISAR2_WFXT_NI 0x0 > +#define ID_AA64ISAR2_WFXT_SUPPORTED 0x2 Maybe I wasn't clear in my earlier comment: you need to enumerate all the architecturally valid values: #define ID_AA64ISAR2_WFXT_NI 0x0 #define ID_AA64ISAR2_WFXT_V1 0x1 #define ID_AA64ISAR2_WFXT_V2 0x2 where WFXT_V1 represent the original FEAT_WFxT, and WFXT_V2 the new, more usable FEAT_WFxT2. Even if the original FEAT_WFxT is deprecated, it still exists, and is still the only mandatory option for v8.7. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel