From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A45DC433EF for ; Mon, 6 Dec 2021 15:30:58 +0000 (UTC) Received: from localhost ([::1]:41414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muFxB-0003lF-PL for qemu-devel@archiver.kernel.org; Mon, 06 Dec 2021 10:30:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muFvO-0001Uh-Ro for qemu-devel@nongnu.org; Mon, 06 Dec 2021 10:29:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:29018) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muFvL-0003gb-QJ for qemu-devel@nongnu.org; Mon, 06 Dec 2021 10:29:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638804543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hLh6PpUwr4VeSzxbzdhyh+0Ye12D4s02Akc9mOvML4U=; b=Npw/c++ldshLACMeWRFcHCJrZZzmMaB2E3eSL1fVt+fKpzk/87J2uWgQpkjoKd82+heZC5 Pnkr3hVrTp+cGBGTdczL3MU1jEPqnYTBVr42t6HHCdztMX075GXeSb79DOIkMxA/2VnlSA 3Qy31DP5tbF10cIYEaCCVY+zYqpJNsg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-251-8PdwSpLzPpCchl52uUtAjg-1; Mon, 06 Dec 2021 10:29:01 -0500 X-MC-Unique: 8PdwSpLzPpCchl52uUtAjg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D5F74835E20; Mon, 6 Dec 2021 15:29:00 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-7.ams2.redhat.com [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A683D1001F4D; Mon, 6 Dec 2021 15:29:00 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 30E5A113865F; Mon, 6 Dec 2021 16:28:59 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Subject: Re: [PATCH v2 00/13] Eliminate drive_get_next() References: <20211117163409.3587705-1-armbru@redhat.com> Date: Mon, 06 Dec 2021 16:28:59 +0100 In-Reply-To: <20211117163409.3587705-1-armbru@redhat.com> (Markus Armbruster's message of "Wed, 17 Nov 2021 17:33:56 +0100") Message-ID: <87lf0xkb0k.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.619, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Markus Armbruster writes: > drive_get_next() is basically a bad idea. It returns the "next" block > backend of a certain interface type. "Next" means bus=0,unit=N, where > subsequent calls count N up from zero, per interface type. > > This lets you define unit numbers implicitly by execution order. If > the order changes, or new calls appear "in the middle", unit numbers > change. ABI break. Hard to spot in review. Replace its uses by > drive_get(), then delete it. Queued for 7.0.