Re: [Intel-gfx] [PATCH] drm/i915/fdi: make intel_fdi_link_freq() return int

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 24 Aug 2021, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Mon, Aug 23, 2021 at 12:36:45PM +0300, Jani Nikula wrote:
>> The unsigned doesn't help us here.
>> 
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks, pushed.

BR,
Jani.


>
>> ---
>>  drivers/gpu/drm/i915/display/intel_fdi.c | 2 +-
>>  drivers/gpu/drm/i915/display/intel_fdi.h | 4 +---
>>  2 files changed, 2 insertions(+), 4 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c b/drivers/gpu/drm/i915/display/intel_fdi.c
>> index 970a57369b05..13f8ba4c9188 100644
>> --- a/drivers/gpu/drm/i915/display/intel_fdi.c
>> +++ b/drivers/gpu/drm/i915/display/intel_fdi.c
>> @@ -95,7 +95,7 @@ static int ilk_check_fdi_lanes(struct drm_device *dev, enum pipe pipe,
>>  	}
>>  }
>>  
>> -u32 intel_fdi_link_freq(struct drm_i915_private *i915,
>> +int intel_fdi_link_freq(struct drm_i915_private *i915,
>>  			const struct intel_crtc_state *pipe_config)
>>  {
>>  	if (HAS_DDI(i915))
>> diff --git a/drivers/gpu/drm/i915/display/intel_fdi.h b/drivers/gpu/drm/i915/display/intel_fdi.h
>> index fd63a6a53fca..2c8ffd9ceaed 100644
>> --- a/drivers/gpu/drm/i915/display/intel_fdi.h
>> +++ b/drivers/gpu/drm/i915/display/intel_fdi.h
>> @@ -6,15 +6,13 @@
>>  #ifndef _INTEL_FDI_H_
>>  #define _INTEL_FDI_H_
>>  
>> -#include <linux/types.h>
>> -
>>  struct drm_i915_private;
>>  struct intel_crtc;
>>  struct intel_crtc_state;
>>  struct intel_encoder;
>>  
>>  #define I915_DISPLAY_CONFIG_RETRY 1
>> -u32 intel_fdi_link_freq(struct drm_i915_private *i915,
>> +int intel_fdi_link_freq(struct drm_i915_private *i915,
>>  			const struct intel_crtc_state *pipe_config);
>>  int ilk_fdi_compute_config(struct intel_crtc *intel_crtc,
>>  			   struct intel_crtc_state *pipe_config);
>> -- 
>> 2.20.1

-- 
Jani Nikula, Intel Open Source Graphics Center