From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 645B1C4338F for ; Fri, 23 Jul 2021 12:58:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B4CB60EE6 for ; Fri, 23 Jul 2021 12:58:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2B4CB60EE6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B+Wwu1VulPR5eIYoVpCiRTxizr2DcveDZq4WFzijOxk=; b=JQixDsC3jl9o2S J6EPOotCBQI3Iyxeax3npWWjcpUH0rtoEgXq+zMDjOLtmMBx4ul4FzL2V4VzPmDM3R9Zp0XizKB4z OyK1jKfpLIiWhL49PAp+0oq/cxHWYkqlRzolM+UxIwqLYF/1Kliz09+Vx7sxuPWaE2VV6bUbmjWgb emJoPWHzRDinZ3rBnYxCSgckkwHFjIJou2MQmEvkuS6oLj4zzKkjWjhMV0QPFJv9449sSZygYYYad jUeivx6+fiaXLB+OrC0WKd3jN+Xl7TeJI34YRp0v6vrR/XckVrb39jkt2mBFqaqpq+uYdu8wGNq4V apG8sVenjHsyqASUb4Qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6uja-004jwR-1g; Fri, 23 Jul 2021 12:56:58 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6ujV-004juc-6W for linux-arm-kernel@lists.infradead.org; Fri, 23 Jul 2021 12:56:54 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 786BDC000C; Fri, 23 Jul 2021 12:56:50 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Marek =?utf-8?Q?Beh=C3=BAn?= , Russell King Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: armada-3720-turris-mox: remove mrvl,i2c-fast-mode In-Reply-To: <20210628151229.25214-1-pali@kernel.org> References: <20210628121015.22660-1-pali@kernel.org> <20210628151229.25214-1-pali@kernel.org> Date: Fri, 23 Jul 2021 14:56:50 +0200 Message-ID: <87lf5x194d.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210723_055653_403633_186F9861 X-CRM114-Status: GOOD ( 13.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUGFsaSwKCj4gU29tZSBTRlAgbW9kdWxlcyBhcmUgbm90IGRldGVjdGVkIHdoZW4gaTJjLWZh c3QtbW9kZSBpcyBlbmFibGVkIGV2ZW4gd2hlbgo+IGNsb2NrLWZyZXF1ZW5jeSBpcyBhbHJlYWR5 IHNldCB0byAxMDAwMDAuIFRoZSBJMkMgYnVzIHZpb2xhdGVzIHRoZSB0aW1pbmcKPiBzcGVjaWZp Y2F0aW9ucyB3aGVuIHJ1biBpbiBmYXN0IG1vZGUuIFNvIGRpc2FibGUgZmFzdCBtb2RlIG9uIFR1 cnJpcyBNb3guCj4KPiBTYW1lIGNoYW5nZSB3YXMgYWxyZWFkeSBhcHBsaWVkIGZvciB1RFBVIChh bHNvIEFybWFkYSAzNzIwIGJvYXJkIHdpdGggU0ZQKQo+IGluIGNvbW1pdCBmZTNlYzYzMWE3N2Qg KCJhcm02NDogZHRzOiB1RFBVOiByZW1vdmUgaTJjLWZhc3QtbW9kZSIpLgo+Cj4gRml4ZXM6IDcx MDlkODE3ZGIyZSAoImFybTY0OiBkdHM6IG1hcnZlbGw6IGFkZCBEVFMgZm9yIFR1cnJpcyBNb3gi KQo+IFNpZ25lZC1vZmYtYnk6IFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5vcmc+Cj4gUmV2aWV3 ZWQtYnk6IE1hcmVrIEJlaMO6biA8a2FiZWxAa2VybmVsLm9yZz4KCkFwcGxpZWQgb24gbXZlYnUv Zml4ZXMKClRoYW5rcywKCkdyZWdvcnkKCj4gLS0tCj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMvbWFy dmVsbC9hcm1hZGEtMzcyMC10dXJyaXMtbW94LmR0cyB8IDEgKwo+ICAxIGZpbGUgY2hhbmdlZCwg MSBpbnNlcnRpb24oKykKPgo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZl bGwvYXJtYWRhLTM3MjAtdHVycmlzLW1veC5kdHMgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZl bGwvYXJtYWRhLTM3MjAtdHVycmlzLW1veC5kdHMKPiBpbmRleCA2YmNjMzE5YTAxNjEuLjg1ZjE1 ZjJhNDc0MCAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZlbGwvYXJtYWRh LTM3MjAtdHVycmlzLW1veC5kdHMKPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZlbGwv YXJtYWRhLTM3MjAtdHVycmlzLW1veC5kdHMKPiBAQCAtMTE5LDYgKzExOSw3IEBACj4gIAlwaW5j dHJsLW5hbWVzID0gImRlZmF1bHQiOwo+ICAJcGluY3RybC0wID0gPCZpMmMxX3BpbnM+Owo+ICAJ Y2xvY2stZnJlcXVlbmN5ID0gPDEwMDAwMD47Cj4gKwkvZGVsZXRlLXByb3BlcnR5LyBtcnZsLGky Yy1mYXN0LW1vZGU7Cj4gIAlzdGF0dXMgPSAib2theSI7Cj4gIAo+ICAJcnRjQDZmIHsKPiAtLSAK PiAyLjIwLjEKPgoKLS0gCkdyZWdvcnkgQ2xlbWVudCwgQm9vdGxpbgpFbWJlZGRlZCBMaW51eCBh bmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHA6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47FB7C4338F for ; Fri, 23 Jul 2021 12:57:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3227660EE6 for ; Fri, 23 Jul 2021 12:57:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234996AbhGWMQm convert rfc822-to-8bit (ORCPT ); Fri, 23 Jul 2021 08:16:42 -0400 Received: from mslow1.mail.gandi.net ([217.70.178.240]:58683 "EHLO mslow1.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234914AbhGWMQm (ORCPT ); Fri, 23 Jul 2021 08:16:42 -0400 Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 1E014C5251 for ; Fri, 23 Jul 2021 12:57:15 +0000 (UTC) Received: (Authenticated sender: gregory.clement@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 786BDC000C; Fri, 23 Jul 2021 12:56:50 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Marek =?utf-8?Q?Beh=C3=BAn?= , Russell King Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: armada-3720-turris-mox: remove mrvl,i2c-fast-mode In-Reply-To: <20210628151229.25214-1-pali@kernel.org> References: <20210628121015.22660-1-pali@kernel.org> <20210628151229.25214-1-pali@kernel.org> Date: Fri, 23 Jul 2021 14:56:50 +0200 Message-ID: <87lf5x194d.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Pali, > Some SFP modules are not detected when i2c-fast-mode is enabled even when > clock-frequency is already set to 100000. The I2C bus violates the timing > specifications when run in fast mode. So disable fast mode on Turris Mox. > > Same change was already applied for uDPU (also Armada 3720 board with SFP) > in commit fe3ec631a77d ("arm64: dts: uDPU: remove i2c-fast-mode"). > > Fixes: 7109d817db2e ("arm64: dts: marvell: add DTS for Turris Mox") > Signed-off-by: Pali Rohár > Reviewed-by: Marek Behún Applied on mvebu/fixes Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > index 6bcc319a0161..85f15f2a4740 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > @@ -119,6 +119,7 @@ > pinctrl-names = "default"; > pinctrl-0 = <&i2c1_pins>; > clock-frequency = <100000>; > + /delete-property/ mrvl,i2c-fast-mode; > status = "okay"; > > rtc@6f { > -- > 2.20.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com