diff for duplicates of <87lf672wdd.fsf@linux.ibm.com> diff --git a/a/1.txt b/N1/1.txt index 063e033..243e061 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -44,7 +44,8 @@ Sure, that is a valid concern. But the documentation for the header version field says: "Version of the Header. The header will be always backward compatible, - and changes will not impact the Array of attributes. Current version 0x01" + and changes will not impact the Array of attributes. Current version = + 0x01" I guess this is a bit vague still, but I understood that: @@ -146,7 +147,7 @@ I'm fine with keeping it like this. >>> + pgs[idx].pg.name = buf; >>> + >>> + /* Do not add the value description if it does not exist */ ->>> + if (strlen(esi_attrs[idx].value_desc) = 0) +>>> + if (strlen(esi_attrs[idx].value_desc) == 0) >>> + show_val_desc = false; >>> + >>> + if (add_attr_group(be64_to_cpu(esi_attrs[idx].id), diff --git a/a/content_digest b/N1/content_digest index 423dbab..6f52d93 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\060575876-b15d-6dee-dbb7-c68b9e304557@linux.ibm.com\0" "From\0Fabiano Rosas <farosas@linux.ibm.com>\0" "Subject\0Re: [PATCH v3 1/1] powerpc/pseries: Interface to represent PAPR firmware attributes\0" - "Date\0Thu, 15 Jul 2021 19:46:38 +0000\0" + "Date\0Thu, 15 Jul 2021 16:46:38 -0300\0" "To\0Pratik Sampat <psampat@linux.ibm.com>" mpe@ellerman.id.au benh@kernel.crashing.org @@ -61,7 +61,8 @@ "version field says:\n" "\n" " \"Version of the Header. The header will be always backward compatible,\n" - " and changes will not impact the Array of attributes. Current version 0x01\"\n" + " and changes will not impact the Array of attributes. Current version =\n" + " 0x01\"\n" "\n" "I guess this is a bit vague still, but I understood that:\n" "\n" @@ -163,7 +164,7 @@ ">>> +\t\tpgs[idx].pg.name = buf;\n" ">>> +\n" ">>> +\t\t/* Do not add the value description if it does not exist */\n" - ">>> +\t\tif (strlen(esi_attrs[idx].value_desc) = 0)\n" + ">>> +\t\tif (strlen(esi_attrs[idx].value_desc) == 0)\n" ">>> +\t\t\tshow_val_desc = false;\n" ">>> +\n" ">>> +\t\tif (add_attr_group(be64_to_cpu(esi_attrs[idx].id),\n" @@ -195,4 +196,4 @@ ">>> +\n" >>> +machine_device_initcall(pseries, papr_init); -174fdfcb5596db1d6b50b94e69d15a7d4d18c3591d54ff88370d01e9c6d6b009 +0c974658497295be8e06ed412224db90d9ee17ba585b086db4980b8dbea45c55
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.