From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, "Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, libvir-list@redhat.com, mreitz@redhat.com,
jsnow@redhat.com
Subject: Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration
Date: Fri, 05 Mar 2021 09:06:45 +0100 [thread overview]
Message-ID: <87lfb29g8a.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <87v9a7dmfk.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Thu, 04 Mar 2021 15:26:55 +0100")
Markus Armbruster <armbru@redhat.com> writes:
> Daniel P. Berrangé <berrange@redhat.com> writes:
>
>> On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote:
>>> Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate
>>> configuring floppies with -global isa-fdc" (v5.1.0).
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
[...]
> Sadly, the commit's update of docs/system/deprecated.rst neglects to
> cover this use. Looks the series overtaxed my capacity to juggle
> details; my apologies.
[...]
I'm talking about commit 4a27a638e7 here.
The deprecated.rst text only covers setting floppy controller properties
with -global. It neglects to cover setting them with -device. For
onboard controllers, -global is the only way to set them.
I append a fixup.
We can put it before this patch. This patch then moves the fixed up
text to removed-features.rst.
Or we squash it into this patch, i.e. this patch deletes the flawed text
from deprecated.rst and adds the fixed up text to removed-features.rst.
Got a preference?
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index 2fcac7861e..393ede47f1 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -97,7 +97,11 @@ QEMU 5.1 has three options:
``Configuring floppies with ``-global``
'''''''''''''''''''''''''''''''''''''''
-Use ``-device floppy,...`` instead:
+Floppy controllers' drive properties (since 5.1)
+''''''''''''''''''''''''''''''''''''''''''''''''
+
+Use ``-device floppy,...`` instead. When configuring onboard floppy
+controllers
::
-global isa-fdc.driveA=...
@@ -120,8 +124,30 @@ become
-device floppy,unit=1,drive=...
-``-drive`` with bogus interface type
-''''''''''''''''''''''''''''''''''''
+When plugging in a floppy controller
+::
+
+ -device isa-fdc,...,driveA=...
+
+becomes
+::
+
+ -device isa-fdc,...
+ -device floppy,unit=0,drive=...
+
+and
+::
+
+ -device isa-fdc,...,driveB=...
+
+becomes
+::
+
+ -device isa-fdc,...
+ -device floppy,unit=1,drive=...
+
+``-drive`` with bogus interface type (since 5.1)
+''''''''''''''''''''''''''''''''''''''''''''''''
Drives with interface types other than ``if=none`` are for onboard
devices. It is possible to use drives the board doesn't pick up with
next prev parent reply other threads:[~2021-03-05 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 10:00 [PATCH v2 0/3] Drop deprecated floppy config & bogus -drive if=T Markus Armbruster
2021-03-04 10:00 ` [PATCH v2 1/3] fdc: Drop deprecated floppy configuration Markus Armbruster
2021-03-04 10:52 ` Daniel P. Berrangé
2021-03-04 14:26 ` Markus Armbruster
2021-03-04 14:34 ` Daniel P. Berrangé
2021-03-04 16:23 ` Markus Armbruster
2021-03-04 16:52 ` Peter Krempa
2021-03-04 16:54 ` Daniel P. Berrangé
2021-03-05 6:41 ` Markus Armbruster
2021-03-05 8:06 ` Markus Armbruster [this message]
2021-03-08 11:23 ` Daniel P. Berrangé
2021-03-04 10:00 ` [PATCH v2 2/3] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common() Markus Armbruster
2021-03-04 10:00 ` [PATCH v2 3/3] blockdev: Drop deprecated bogus -drive interface type Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfb29g8a.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.