From: "Alex Bennée" <alex.bennee@linaro.org>
To: Vincent Fazio <vfazio@xes-inc.com>
Cc: qemu-trivial@nongnu.org, laurent@vivier.eu,
Vincent Fazio <vfazio@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] linux-user/elfload: munmap proper address in pgd_find_hole_fallback
Date: Sun, 14 Feb 2021 11:32:54 +0000 [thread overview]
Message-ID: <87lfbqc2ab.fsf@linaro.org> (raw)
In-Reply-To: <20210131061849.12615-1-vfazio@xes-inc.com>
Vincent Fazio <vfazio@xes-inc.com> writes:
> From: Vincent Fazio <vfazio@gmail.com>
>
> Previously, if the build host's libc did not define MAP_FIXED_NOREPLACE
> or if the running kernel didn't support that flag, it was possible for
> pgd_find_hole_fallback to munmap an incorrect address which could lead to
> SIGSEGV if the range happened to overlap with the mapped address of the
> QEMU binary.
>
> mmap(0x1000, 22261224, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_NORESERVE, -1, 0) = 0x7f889d331000
> munmap(0x1000, 22261224) = 0
> --- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0x84b817} ---
> ++ killed by SIGSEGV +++
>
> Now, always munmap the address returned by mmap.
>
> Fixes: 2667e069e7b5 ("linux-user: don't use MAP_FIXED in pgd_find_hole_fallback")
> Signed-off-by: Vincent Fazio <vfazio@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2021-02-14 11:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 6:18 [PATCH] linux-user/elfload: munmap proper address in pgd_find_hole_fallback Vincent Fazio
2021-01-31 6:18 ` Vincent Fazio
2021-02-13 21:37 ` Laurent Vivier
2021-02-13 21:37 ` Laurent Vivier
2021-02-14 11:32 ` Alex Bennée [this message]
2021-03-09 21:04 ` Vincent Fazio
2021-03-09 21:04 ` Vincent Fazio
2021-03-09 21:23 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfbqc2ab.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=vfazio@gmail.com \
--cc=vfazio@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.