All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aurélien Aptel" <aaptel@suse.com>
To: Adam Harvey <adam@adamharvey.name>,
	sfrench@samba.org, linux-cifs@vger.kernel.org
Cc: samba-technical@lists.samba.org, Adam Harvey <adam@adamharvey.name>
Subject: Re: [PATCH] cifs: ignore the noauto option if it is provided
Date: Wed, 27 Jan 2021 11:56:15 +0100	[thread overview]
Message-ID: <87lfceabsg.fsf@suse.com> (raw)
In-Reply-To: <20210127071020.18052-1-adam@adamharvey.name>

Hi Adam,

Adam Harvey <adam@adamharvey.name> writes:
> In 24e0a1eff9e2, the noauto option was missed when migrating to the new
> mount API. As a result, users with noauto in their fstab mount options
> are now unable to mount cifs filesystems, as they'll receive an "Unknown
> parameter" error.
>
> This restores the old behaviour of ignoring noauto if it's given.

I was looking at other fs code and it seems no one explicitely parses
auto/noauto. Any idea why? This looks like it could be handled somewhere
else.

Also I would have expected fsparam_flag_no("auto", Opt_ignore) to allow
for both auto and noauto.

Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)


  reply	other threads:[~2021-01-27 11:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27  7:10 [PATCH] cifs: ignore the noauto option if it is provided Adam Harvey
2021-01-27 10:56 ` Aurélien Aptel [this message]
2021-01-27 20:39   ` Adam Harvey
2021-01-27 21:44     ` [PATCH] cifs: ignore auto and noauto options if given Adam Harvey
2021-01-27 23:18       ` Steve French
2021-01-27 23:25         ` ronnie sahlberg
2021-01-28  1:25       ` Steve French
     [not found]   ` <CAH2r5mtWa8JyWXHvnWKB5N-8qfGO+G_mmu5m3+QfuhxgWX14sg@mail.gmail.com>
2021-01-27 20:43     ` [PATCH] cifs: ignore the noauto option if it is provided Adam Harvey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfceabsg.fsf@suse.com \
    --to=aaptel@suse.com \
    --cc=adam@adamharvey.name \
    --cc=linux-cifs@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.