From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Felix Fietkau <nbd@nbd.name>,
Sebastian Gottschall <s.gottschall@dd-wrt.com>,
linux-wireless@vger.kernel.org
Cc: johannes@sipsolutions.net
Subject: Re: [PATCH 5.9 3/3] mac80211: improve AQL aggregation estimation for low data rates
Date: Fri, 21 Aug 2020 18:37:50 +0200 [thread overview]
Message-ID: <87lfi82bvl.fsf@toke.dk> (raw)
In-Reply-To: <623a2b24-31c8-83be-ae24-1461ecbfc224@nbd.name>
Felix Fietkau <nbd@nbd.name> writes:
> On 2020-08-21 17:33, Toke Høiland-Jørgensen wrote:
>> Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
>>
>>> i mean airtime fairness policy was not configured
>>
>> Ah, right, that makes a lot more sense :)
>>
>> Still not sure why this would affect throughput, though; maybe the
>> change in calculation makes AQL overestimate the airtime and throttle
>> too much? Or does the saving of last_rate_info on tx_status_ext() work
>> badly for ath10k?
> The issue turned out to be missing return code checks on converting the
> tx rate to struct ieee80211_rx_status.
> I'll send v2 of this series with fixes.
Ah, great! :)
-Toke
next prev parent reply other threads:[~2020-08-21 16:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 15:52 [PATCH 5.9 1/3] mac80211: use rate provided via status->rate on ieee80211_tx_status_ext for AQL Felix Fietkau
2020-08-13 15:52 ` [PATCH 5.9 2/3] mac80211: factor out code to look up the average packet length duration for a rate Felix Fietkau
2020-08-20 12:44 ` Toke Høiland-Jørgensen
2020-08-13 15:52 ` [PATCH 5.9 3/3] mac80211: improve AQL aggregation estimation for low data rates Felix Fietkau
2020-08-20 12:44 ` Toke Høiland-Jørgensen
2020-08-21 14:46 ` Sebastian Gottschall
2020-08-21 14:58 ` Toke Høiland-Jørgensen
2020-08-21 15:09 ` Sebastian Gottschall
2020-08-21 15:33 ` Toke Høiland-Jørgensen
2020-08-21 16:22 ` Felix Fietkau
2020-08-21 16:37 ` Toke Høiland-Jørgensen [this message]
2020-08-20 12:43 ` [PATCH 5.9 1/3] mac80211: use rate provided via status->rate on ieee80211_tx_status_ext for AQL Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfi82bvl.fsf@toke.dk \
--to=toke@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=s.gottschall@dd-wrt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.