From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>,
Nikolay Igotti <igotti@gmail.com>
Subject: Re: [PATCH 3/3] plugins: avoid failing plugin when CPU is inited several times
Date: Mon, 20 Apr 2020 16:07:58 +0100 [thread overview]
Message-ID: <87lfmqdwkx.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA9Yk53oK5YstN7DpCCq344+tbyjvDA6RaWcJCrL9QSjMw@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On Mon, 20 Apr 2020 at 10:16, Nikolay Igotti <igotti@gmail.com> wrote:
>>
>> In linux-user multithreaded scenarious CPU could be inited many times with the same id,
>>
>> so avoid assertions on already present hashtable entry.
>>
>>
>> Signed-off-by: Nikolay Igotti <igotti@gmail.com>
>
> Wouldn't it be better to make sure we remove the entry from
> the hashtable when the old thread that was using that CPU
> ID exits, or is that not feasible ?
I'm fairly sure that is exactly what should be happening via
qemu_plugin_vcpu_exit_hook(cpu) which should be a result of the
object_unref(OBJECT(cpu)) in thread exit.
Is there a test vase?
>
> thanks
> -- PMM
--
Alex Bennée
next prev parent reply other threads:[~2020-04-20 15:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 9:15 [PATCH 3/3] plugins: avoid failing plugin when CPU is inited several times Nikolay Igotti
2020-04-20 9:51 ` Laurent Vivier
2020-04-20 10:04 ` Nikolay Igotti
2020-05-09 23:00 ` Emilio G. Cota
2020-05-11 15:53 ` Nikolay Igotti
2020-05-12 0:55 ` Emilio G. Cota
2020-05-12 8:38 ` Nikolay Igotti
2020-05-12 19:35 ` Alex Bennée
2020-05-12 20:11 ` Alex Bennée
2020-05-24 14:11 ` Emilio G. Cota
2020-04-20 10:11 ` Peter Maydell
2020-04-20 10:18 ` Nikolay Igotti
2020-04-20 10:30 ` Peter Maydell
2020-04-20 15:07 ` Alex Bennée [this message]
2020-04-20 16:14 ` Nikolay Igotti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfmqdwkx.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=igotti@gmail.com \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.