From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 860C6C2D0EA for ; Wed, 8 Apr 2020 11:38:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A73F20747 for ; Wed, 8 Apr 2020 11:38:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A73F20747 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DA85F6E0F1; Wed, 8 Apr 2020 11:38:45 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 753716E0F1 for ; Wed, 8 Apr 2020 11:38:44 +0000 (UTC) IronPort-SDR: SCiqhwFPFAjYhQ/kA+I+kE6L2urAWglVRZyElriDVWovMaD2t+RFt0yV1ZHw9YmOFUQrmYRK1X +Q/K3hIIqX0Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2020 04:38:43 -0700 IronPort-SDR: WFPugLdz+kyTZwqcv1TbxWPiKbXOxg6XSLquDwl4Jcrubsk3H3zIM2sNGhT8QkQcrPl7wO2TZy BrJhgloE2abw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,358,1580803200"; d="scan'208";a="398175505" Received: from gaia.fi.intel.com ([10.237.72.192]) by orsmga004.jf.intel.com with ESMTP; 08 Apr 2020 04:38:43 -0700 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id 264105C0D80; Wed, 8 Apr 2020 14:36:59 +0300 (EEST) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20200408091723.28937-1-chris@chris-wilson.co.uk> References: <20200408091631.28753-1-chris@chris-wilson.co.uk> <20200408091723.28937-1-chris@chris-wilson.co.uk> Date: Wed, 08 Apr 2020 14:36:59 +0300 Message-ID: <87lfn6nr8k.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Take an explicit ref for rq->batch X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > Since we are peeking into the batch object of the request, it is > beholden on us to hold a reference to it. > > Closes: https://gitlab.freedesktop.org/drm/intel/issues/1634 > Signed-off-by: Chris Wilson Follow the mon^H^H^H request. Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/selftest_lrc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c > index 57db3d0ffaf2..616d03506c2c 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c > +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c > @@ -2655,7 +2655,7 @@ static int create_gang(struct intel_engine_cs *engine, > if (IS_ERR(rq)) > goto err_obj; > > - rq->batch = vma; > + rq->batch = i915_vma_get(vma); > i915_request_get(rq); > > i915_vma_lock(vma); > @@ -2679,6 +2679,7 @@ static int create_gang(struct intel_engine_cs *engine, > return 0; > > err_rq: > + i915_vma_put(rq->batch); > i915_request_put(rq); > err_obj: > i915_gem_object_put(obj); > @@ -2775,6 +2776,7 @@ static int live_preempt_gang(void *arg) > err = -ETIME; > } > > + i915_vma_put(rq->batch); > i915_request_put(rq); > rq = n; > } > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx