From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Mika Kuoppala In-Reply-To: <20200303143137.1615349-1-chris@chris-wilson.co.uk> References: <20200303143137.1615349-1-chris@chris-wilson.co.uk> Date: Tue, 03 Mar 2020 16:39:28 +0200 Message-ID: <87lfoh5wpr.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_create: Fix 'files' List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: Chris Wilson writes: > The test is supposed to create a context for each execution, so do so. > > Signed-off-by: Chris Wilson > --- > tests/i915/gem_ctx_create.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/tests/i915/gem_ctx_create.c b/tests/i915/gem_ctx_create.c > index 2c44a3e3e..d9192fbab 100644 > --- a/tests/i915/gem_ctx_create.c > +++ b/tests/i915/gem_ctx_create.c > @@ -178,7 +178,7 @@ static void active(int fd, const struct intel_execution_engine2 *e, > > execbuf.flags = ppgtt_engines[child]; > > - while (!*(volatile unsigned *)shared) { > + while (!READ_ONCE(*shared)) { Pleasing. > obj.handle = gem_create(fd, 4096 << 10); > gem_write(fd, obj.handle, 0, &bbe, sizeof(bbe)); > > @@ -209,17 +209,19 @@ static void active(int fd, const struct intel_execution_engine2 *e, > > clock_gettime(CLOCK_MONOTONIC, &start); > do { > - do { > - execbuf.rsvd1 = ctx; > - for (unsigned n = 0; n < nengine; n++) { > - execbuf.flags = engines[n]; > - gem_execbuf(fd, &execbuf); > - } > - gem_context_destroy(fd, execbuf.rsvd1); > - } while (++count & 1023); > + execbuf.rsvd1 = gem_context_clone_with_engines(fd, ctx); > + for (unsigned n = 0; n < nengine; n++) { > + execbuf.flags = engines[n]; > + gem_execbuf(fd, &execbuf); > + } > + gem_context_destroy(fd, execbuf.rsvd1); > + count++; > + > clock_gettime(CLOCK_MONOTONIC, &end); > } while (elapsed(&start, &end) < timeout); > > + gem_context_destroy(fd, ctx); Tidy. Well as the test name is terse as 'active' I can't argue that it should or should not create a context. But tossing the same ctx for each execbuf looks fruitless enough. Reviewed-by: Mika Kuoppala > + > gem_sync(fd, obj.handle); > clock_gettime(CLOCK_MONOTONIC, &end); > igt_info("[%d] Context creation + execution: %.3f us\n", > -- > 2.25.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EA2BC3F2CD for ; Tue, 3 Mar 2020 14:41:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B61D2083E for ; Tue, 3 Mar 2020 14:41:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B61D2083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 893C66EA78; Tue, 3 Mar 2020 14:41:48 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 445046EA7D; Tue, 3 Mar 2020 14:41:47 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2020 06:40:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,511,1574150400"; d="scan'208";a="274221383" Received: from gaia.fi.intel.com ([10.237.72.192]) by fmsmga002.fm.intel.com with ESMTP; 03 Mar 2020 06:40:44 -0800 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id C84B25C1D7C; Tue, 3 Mar 2020 16:39:28 +0200 (EET) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20200303143137.1615349-1-chris@chris-wilson.co.uk> References: <20200303143137.1615349-1-chris@chris-wilson.co.uk> Date: Tue, 03 Mar 2020 16:39:28 +0200 Message-ID: <87lfoh5wpr.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_create: Fix 'files' X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > The test is supposed to create a context for each execution, so do so. > > Signed-off-by: Chris Wilson > --- > tests/i915/gem_ctx_create.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/tests/i915/gem_ctx_create.c b/tests/i915/gem_ctx_create.c > index 2c44a3e3e..d9192fbab 100644 > --- a/tests/i915/gem_ctx_create.c > +++ b/tests/i915/gem_ctx_create.c > @@ -178,7 +178,7 @@ static void active(int fd, const struct intel_execution_engine2 *e, > > execbuf.flags = ppgtt_engines[child]; > > - while (!*(volatile unsigned *)shared) { > + while (!READ_ONCE(*shared)) { Pleasing. > obj.handle = gem_create(fd, 4096 << 10); > gem_write(fd, obj.handle, 0, &bbe, sizeof(bbe)); > > @@ -209,17 +209,19 @@ static void active(int fd, const struct intel_execution_engine2 *e, > > clock_gettime(CLOCK_MONOTONIC, &start); > do { > - do { > - execbuf.rsvd1 = ctx; > - for (unsigned n = 0; n < nengine; n++) { > - execbuf.flags = engines[n]; > - gem_execbuf(fd, &execbuf); > - } > - gem_context_destroy(fd, execbuf.rsvd1); > - } while (++count & 1023); > + execbuf.rsvd1 = gem_context_clone_with_engines(fd, ctx); > + for (unsigned n = 0; n < nengine; n++) { > + execbuf.flags = engines[n]; > + gem_execbuf(fd, &execbuf); > + } > + gem_context_destroy(fd, execbuf.rsvd1); > + count++; > + > clock_gettime(CLOCK_MONOTONIC, &end); > } while (elapsed(&start, &end) < timeout); > > + gem_context_destroy(fd, ctx); Tidy. Well as the test name is terse as 'active' I can't argue that it should or should not create a context. But tossing the same ctx for each execbuf looks fruitless enough. Reviewed-by: Mika Kuoppala > + > gem_sync(fd, obj.handle); > clock_gettime(CLOCK_MONOTONIC, &end); > igt_info("[%d] Context creation + execution: %.3f us\n", > -- > 2.25.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx