From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Wambui Karuga <wambui.karugax@gmail.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix force-probe failure message
Date: Fri, 07 Feb 2020 16:40:11 +0200 [thread overview]
Message-ID: <87lfpe1mwk.fsf@intel.com> (raw)
In-Reply-To: <20200207135048.2788199-1-chris@chris-wilson.co.uk>
On Fri, 07 Feb 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Do not try and deference the i915 private before it has been allocated
> and attached to the drvdata!
>
> Fixes: 7daac72e9a3f ("drm/i915/pci: conversion to drm_device based logging macros.")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Wambui Karuga <wambui.karugax@gmail.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
Whoops!
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index da337aee632e..24b1f0ce8743 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -963,7 +963,7 @@ static int i915_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>
> if (intel_info->require_force_probe &&
> !force_probe(pdev->device, i915_modparams.force_probe)) {
> - drm_info(&pdev_to_i915(pdev)->drm,
> + dev_info(&pdev->dev,
> "Your graphics device %04x is not properly supported by the driver in this\n"
> "kernel version. To force driver probe anyway, use i915.force_probe=%04x\n"
> "module parameter or CONFIG_DRM_I915_FORCE_PROBE=%04x configuration option,\n"
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-07 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 13:50 [Intel-gfx] [PATCH] drm/i915: Fix force-probe failure message Chris Wilson
2020-02-07 14:40 ` Jani Nikula [this message]
2020-02-07 16:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-10 16:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfpe1mwk.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.