From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B03C43141 for ; Tue, 3 Dec 2019 12:42:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 452C12080A for ; Tue, 3 Dec 2019 12:42:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 452C12080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F0B76E4BA; Tue, 3 Dec 2019 12:42:24 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id D80306E4B5; Tue, 3 Dec 2019 12:42:23 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 04:42:23 -0800 X-IronPort-AV: E=Sophos;i="5.69,273,1571727600"; d="scan'208";a="213397102" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 04:42:19 -0800 From: Jani Nikula To: Lyude Paul , intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 5/5] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel In-Reply-To: <20191122231616.2574-6-lyude@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191122231616.2574-1-lyude@redhat.com> <20191122231616.2574-6-lyude@redhat.com> Date: Tue, 03 Dec 2019 14:42:17 +0200 Message-ID: <87lfrtinrq.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi , Lee Shawn C Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCAyMiBOb3YgMjAxOSwgTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4gd3JvdGU6 Cj4gQW5ub3lpbmdseSwgdGhlIFZCVCBvbiB0aGUgVGhpbmtQYWQgWDEgRXh0cmVtZSAybmQgR2Vu IGluZGljYXRlcyB0aGF0Cj4gdGhlIHN5c3RlbSB1c2VzIHBsYWluIFBXTSBiYXNlZCBiYWNrbGln aHQgY29udHJvbHMsIHdoZW4gaW4gcmVhbGl0eSB0aGUKPiBvbmx5IGJhY2tsaWdodCBjb250cm9s cyB0aGF0IHdvcmsgYXJlIHRoZSBzdGFuZGFyZCBWRVNBIGVEUCBEUENECj4gYmFja2xpZ2h0IGNv bnRyb2xzLgo+Cj4gSG9uZXN0bHksIHRoaXMgbWFrZXMgbWUgd29uZGVyIGhvdyBtYW55IG90aGVy IHN5c3RlbXMgaGF2ZSB0aGVzZSBpc3N1ZXMKPiBvciBsaWUgYWJvdXQgdGhpcyBpbiB0aGVpciBW QlQuIE5vdCBzdXJlIHdlIGhhdmUgYW55IGdvb2Qgd2F5IG9mIGZpbmRpbmcKPiBvdXQgdW50aWwg cGFuZWxzIGxpa2UgdGhpcyBiZWNvbWUgbW9yZSBjb21tb24gcGxhY2UgaW4gdGhlIGxhcHRvcAo+ IG1hcmtldC4gRm9yIG5vdywganVzdCBhZGQgYSBEUk0gRFAgcXVpcmsgdG8gaW5kaWNhdGUgdGhh dCB0aGlzIHBhbmVsIGlzCj4gdGVsbGluZyB0aGUgdHJ1dGggYW5kIGlzIGJlaW5nIGEgZ29vZCBM Q0QuCj4KPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTEyMzc2Cj4gU2lnbmVkLW9mZi1ieTogTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNv bT4KCkFja2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2RybV9kcF9oZWxwZXIuYyAgICAgICAgICAgICAgICAgICAgICAg fCAgNCArKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBfYXV4X2Jh Y2tsaWdodC5jIHwgMTAgKysrKysrKystLQo+ICBpbmNsdWRlL2RybS9kcm1fZHBfaGVscGVyLmgg ICAgICAgICAgICAgICAgICAgICAgICAgICB8ICA4ICsrKysrKysrCj4gIDMgZmlsZXMgY2hhbmdl ZCwgMjAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX2RwX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9oZWxw ZXIuYwo+IGluZGV4IDJjNzg3MGFlZjQ2OS4uZWM3MDYxZTNhOTliIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1fZHBfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2RwX2hlbHBlci5jCj4gQEAgLTExNTUsNiArMTE1NSwxMCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IGRwY2RfcXVpcmsgZHBjZF9xdWlya19saXN0W10gPSB7Cj4gIAl7IE9VSSgweDAwLCAweDEwLCAw eGZhKSwgREVWSUNFX0lEX0FOWSwgZmFsc2UsIEJJVChEUF9EUENEX1FVSVJLX05PX1BTUikgfSwK PiAgCS8qIENINzUxMSBzZWVtcyB0byBsZWF2ZSBTSU5LX0NPVU5UIHplcm9lZCAqLwo+ICAJeyBP VUkoMHgwMCwgMHgwMCwgMHgwMCksIERFVklDRV9JRCgnQycsICdIJywgJzcnLCAnNScsICcxJywg JzEnKSwgZmFsc2UsIEJJVChEUF9EUENEX1FVSVJLX05PX1NJTktfQ09VTlQpIH0sCj4gKwkvKiBP cHRpb25hbCA0SyBBTU9MRUQgcGFuZWwgaW4gdGhlIFRoaW5rUGFkIFgxIEV4dHJlbWUgMm5kIEdl bmVyYXRpb24KPiArCSAqIG9ubHkgc3VwcG9ydHMgRFBDRCBiYWNrbGlnaHQgY29udHJvbHMsIGRl c3BpdGUgYWR2ZXJ0aXNpbmcgb3RoZXJ3aXNlCj4gKwkgKi8KPiArCXsgT1VJKDB4YmEsIDB4NDEs IDB4NTkpLCBERVZJQ0VfSURfQU5ZLCBmYWxzZSwgQklUKERQX0RQQ0RfUVVJUktfRk9SQ0VfRFBD RF9CQUNLTElHSFQpIH0sCj4gIH07Cj4gIAo+ICAjdW5kZWYgT1VJCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBfYXV4X2JhY2tsaWdodC5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPiBpbmRl eCA4N2I1OWRiOWZmZTMuLjNkNjEyNjBiMDhhZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9kaXNwbGF5L2ludGVsX2RwX2F1eF9iYWNrbGlnaHQuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBfYXV4X2JhY2tsaWdodC5jCj4gQEAgLTMyNSwx MSArMzI1LDE3IEBAIGludGVsX2RwX2F1eF9kaXNwbGF5X2NvbnRyb2xfY2FwYWJsZShzdHJ1Y3Qg aW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4gIGludCBpbnRlbF9kcF9hdXhfaW5pdF9iYWNr bGlnaHRfZnVuY3Moc3RydWN0IGludGVsX2Nvbm5lY3RvciAqaW50ZWxfY29ubmVjdG9yKQo+ICB7 Cj4gIAlzdHJ1Y3QgaW50ZWxfcGFuZWwgKnBhbmVsID0gJmludGVsX2Nvbm5lY3Rvci0+cGFuZWw7 Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGludGVsX2Nv bm5lY3Rvci0+YmFzZS5kZXYpOwo+ICsJc3RydWN0IGludGVsX2RwICppbnRlbF9kcCA9Cj4gKwkJ ZW5jX3RvX2ludGVsX2RwKCZpbnRlbF9jb25uZWN0b3ItPmVuY29kZXItPmJhc2UpOwo+ICsJc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0KPiArCQl0b19pOTE1KGludGVsX2Nvbm5l Y3Rvci0+YmFzZS5kZXYpOwo+ICAKPiAgCWlmIChpOTE1X21vZHBhcmFtcy5lbmFibGVfZHBjZF9i YWNrbGlnaHQgPT0gMCB8fAo+ICAJICAgIChpOTE1X21vZHBhcmFtcy5lbmFibGVfZHBjZF9iYWNr bGlnaHQgPT0gLTEgJiYKPiAtCSAgICBkZXZfcHJpdi0+dmJ0LmJhY2tsaWdodC50eXBlICE9IElO VEVMX0JBQ0tMSUdIVF9WRVNBX0VEUF9BVVhfSU5URVJGQUNFKSkKPiArCSAgICAgZGV2X3ByaXYt PnZidC5iYWNrbGlnaHQudHlwZSAhPQo+ICsJCSAgICAgSU5URUxfQkFDS0xJR0hUX1ZFU0FfRURQ X0FVWF9JTlRFUkZBQ0UgJiYKPiArCSAgICAgIWRybV9kcF9oYXNfcXVpcmsoJmludGVsX2RwLT5k ZXNjLAo+ICsJCQkgICAgICAgRFBfRFBDRF9RVUlSS19GT1JDRV9EUENEX0JBQ0tMSUdIVCkpKQo+ ICAJCXJldHVybiAtRU5PREVWOwo+ICAKPiAgCWlmICghaW50ZWxfZHBfYXV4X2Rpc3BsYXlfY29u dHJvbF9jYXBhYmxlKGludGVsX2Nvbm5lY3RvcikpCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJt L2RybV9kcF9oZWxwZXIuaCBiL2luY2x1ZGUvZHJtL2RybV9kcF9oZWxwZXIuaAo+IGluZGV4IDUx ZWNiNTExMmVmOC4uYTQ0NDIwOWNkNTRiIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9k cF9oZWxwZXIuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9kcF9oZWxwZXIuaAo+IEBAIC0xNTIw LDYgKzE1MjAsMTQgQEAgZW51bSBkcm1fZHBfcXVpcmsgewo+ICAJICogVGhlIGRyaXZlciBzaG91 bGQgaWdub3JlIFNJTktfQ09VTlQgZHVyaW5nIGRldGVjdGlvbi4KPiAgCSAqLwo+ICAJRFBfRFBD RF9RVUlSS19OT19TSU5LX0NPVU5ULAo+ICsJLyoqCj4gKwkgKiBARFBfRFBDRF9RVUlSS19GT1JD RV9EUENEX0JBQ0tMSUdIVDoKPiArCSAqCj4gKwkgKiBUaGUgZGV2aWNlIGlzIHRlbGxpbmcgdGhl IHRydXRoIHdoZW4gaXQgc2F5cyB0aGF0IGl0IHVzZXMgRFBDRAo+ICsJICogYmFja2xpZ2h0IGNv bnRyb2xzLCBldmVuIGlmIHRoZSBzeXN0ZW0ncyBmaXJtd2FyZSBkaXNhZ3JlZXMuCj4gKwkgKiBU aGUgZHJpdmVyIHNob3VsZCBob25vciB0aGUgRFBDRCBiYWNrbGlnaHQgY2FwYWJpbGl0aWVzIGFk dmVydGlzZWQuCj4gKwkgKi8KPiArCURQX0RQQ0RfUVVJUktfRk9SQ0VfRFBDRF9CQUNLTElHSFQs Cj4gIH07Cj4gIAo+ICAvKioKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3Jh cGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13D81C432C0 for ; Tue, 3 Dec 2019 12:42:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA37A2073F for ; Tue, 3 Dec 2019 12:42:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA37A2073F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 46D496E4B7; Tue, 3 Dec 2019 12:42:24 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id D80306E4B5; Tue, 3 Dec 2019 12:42:23 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 04:42:23 -0800 X-IronPort-AV: E=Sophos;i="5.69,273,1571727600"; d="scan'208";a="213397102" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 04:42:19 -0800 From: Jani Nikula To: Lyude Paul , intel-gfx@lists.freedesktop.org In-Reply-To: <20191122231616.2574-6-lyude@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191122231616.2574-1-lyude@redhat.com> <20191122231616.2574-6-lyude@redhat.com> Date: Tue, 03 Dec 2019 14:42:17 +0200 Message-ID: <87lfrtinrq.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 5/5] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, Maxime Ripard , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gRnJpLCAyMiBOb3YgMjAxOSwgTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4gd3JvdGU6 Cj4gQW5ub3lpbmdseSwgdGhlIFZCVCBvbiB0aGUgVGhpbmtQYWQgWDEgRXh0cmVtZSAybmQgR2Vu IGluZGljYXRlcyB0aGF0Cj4gdGhlIHN5c3RlbSB1c2VzIHBsYWluIFBXTSBiYXNlZCBiYWNrbGln aHQgY29udHJvbHMsIHdoZW4gaW4gcmVhbGl0eSB0aGUKPiBvbmx5IGJhY2tsaWdodCBjb250cm9s cyB0aGF0IHdvcmsgYXJlIHRoZSBzdGFuZGFyZCBWRVNBIGVEUCBEUENECj4gYmFja2xpZ2h0IGNv bnRyb2xzLgo+Cj4gSG9uZXN0bHksIHRoaXMgbWFrZXMgbWUgd29uZGVyIGhvdyBtYW55IG90aGVy IHN5c3RlbXMgaGF2ZSB0aGVzZSBpc3N1ZXMKPiBvciBsaWUgYWJvdXQgdGhpcyBpbiB0aGVpciBW QlQuIE5vdCBzdXJlIHdlIGhhdmUgYW55IGdvb2Qgd2F5IG9mIGZpbmRpbmcKPiBvdXQgdW50aWwg cGFuZWxzIGxpa2UgdGhpcyBiZWNvbWUgbW9yZSBjb21tb24gcGxhY2UgaW4gdGhlIGxhcHRvcAo+ IG1hcmtldC4gRm9yIG5vdywganVzdCBhZGQgYSBEUk0gRFAgcXVpcmsgdG8gaW5kaWNhdGUgdGhh dCB0aGlzIHBhbmVsIGlzCj4gdGVsbGluZyB0aGUgdHJ1dGggYW5kIGlzIGJlaW5nIGEgZ29vZCBM Q0QuCj4KPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTEyMzc2Cj4gU2lnbmVkLW9mZi1ieTogTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNv bT4KCkFja2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2RybV9kcF9oZWxwZXIuYyAgICAgICAgICAgICAgICAgICAgICAg fCAgNCArKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBfYXV4X2Jh Y2tsaWdodC5jIHwgMTAgKysrKysrKystLQo+ICBpbmNsdWRlL2RybS9kcm1fZHBfaGVscGVyLmgg ICAgICAgICAgICAgICAgICAgICAgICAgICB8ICA4ICsrKysrKysrCj4gIDMgZmlsZXMgY2hhbmdl ZCwgMjAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX2RwX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9oZWxw ZXIuYwo+IGluZGV4IDJjNzg3MGFlZjQ2OS4uZWM3MDYxZTNhOTliIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1fZHBfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2RwX2hlbHBlci5jCj4gQEAgLTExNTUsNiArMTE1NSwxMCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IGRwY2RfcXVpcmsgZHBjZF9xdWlya19saXN0W10gPSB7Cj4gIAl7IE9VSSgweDAwLCAweDEwLCAw eGZhKSwgREVWSUNFX0lEX0FOWSwgZmFsc2UsIEJJVChEUF9EUENEX1FVSVJLX05PX1BTUikgfSwK PiAgCS8qIENINzUxMSBzZWVtcyB0byBsZWF2ZSBTSU5LX0NPVU5UIHplcm9lZCAqLwo+ICAJeyBP VUkoMHgwMCwgMHgwMCwgMHgwMCksIERFVklDRV9JRCgnQycsICdIJywgJzcnLCAnNScsICcxJywg JzEnKSwgZmFsc2UsIEJJVChEUF9EUENEX1FVSVJLX05PX1NJTktfQ09VTlQpIH0sCj4gKwkvKiBP cHRpb25hbCA0SyBBTU9MRUQgcGFuZWwgaW4gdGhlIFRoaW5rUGFkIFgxIEV4dHJlbWUgMm5kIEdl bmVyYXRpb24KPiArCSAqIG9ubHkgc3VwcG9ydHMgRFBDRCBiYWNrbGlnaHQgY29udHJvbHMsIGRl c3BpdGUgYWR2ZXJ0aXNpbmcgb3RoZXJ3aXNlCj4gKwkgKi8KPiArCXsgT1VJKDB4YmEsIDB4NDEs IDB4NTkpLCBERVZJQ0VfSURfQU5ZLCBmYWxzZSwgQklUKERQX0RQQ0RfUVVJUktfRk9SQ0VfRFBD RF9CQUNLTElHSFQpIH0sCj4gIH07Cj4gIAo+ICAjdW5kZWYgT1VJCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBfYXV4X2JhY2tsaWdodC5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPiBpbmRl eCA4N2I1OWRiOWZmZTMuLjNkNjEyNjBiMDhhZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9kaXNwbGF5L2ludGVsX2RwX2F1eF9iYWNrbGlnaHQuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBfYXV4X2JhY2tsaWdodC5jCj4gQEAgLTMyNSwx MSArMzI1LDE3IEBAIGludGVsX2RwX2F1eF9kaXNwbGF5X2NvbnRyb2xfY2FwYWJsZShzdHJ1Y3Qg aW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4gIGludCBpbnRlbF9kcF9hdXhfaW5pdF9iYWNr bGlnaHRfZnVuY3Moc3RydWN0IGludGVsX2Nvbm5lY3RvciAqaW50ZWxfY29ubmVjdG9yKQo+ICB7 Cj4gIAlzdHJ1Y3QgaW50ZWxfcGFuZWwgKnBhbmVsID0gJmludGVsX2Nvbm5lY3Rvci0+cGFuZWw7 Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGludGVsX2Nv bm5lY3Rvci0+YmFzZS5kZXYpOwo+ICsJc3RydWN0IGludGVsX2RwICppbnRlbF9kcCA9Cj4gKwkJ ZW5jX3RvX2ludGVsX2RwKCZpbnRlbF9jb25uZWN0b3ItPmVuY29kZXItPmJhc2UpOwo+ICsJc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0KPiArCQl0b19pOTE1KGludGVsX2Nvbm5l Y3Rvci0+YmFzZS5kZXYpOwo+ICAKPiAgCWlmIChpOTE1X21vZHBhcmFtcy5lbmFibGVfZHBjZF9i YWNrbGlnaHQgPT0gMCB8fAo+ICAJICAgIChpOTE1X21vZHBhcmFtcy5lbmFibGVfZHBjZF9iYWNr bGlnaHQgPT0gLTEgJiYKPiAtCSAgICBkZXZfcHJpdi0+dmJ0LmJhY2tsaWdodC50eXBlICE9IElO VEVMX0JBQ0tMSUdIVF9WRVNBX0VEUF9BVVhfSU5URVJGQUNFKSkKPiArCSAgICAgZGV2X3ByaXYt PnZidC5iYWNrbGlnaHQudHlwZSAhPQo+ICsJCSAgICAgSU5URUxfQkFDS0xJR0hUX1ZFU0FfRURQ X0FVWF9JTlRFUkZBQ0UgJiYKPiArCSAgICAgIWRybV9kcF9oYXNfcXVpcmsoJmludGVsX2RwLT5k ZXNjLAo+ICsJCQkgICAgICAgRFBfRFBDRF9RVUlSS19GT1JDRV9EUENEX0JBQ0tMSUdIVCkpKQo+ ICAJCXJldHVybiAtRU5PREVWOwo+ICAKPiAgCWlmICghaW50ZWxfZHBfYXV4X2Rpc3BsYXlfY29u dHJvbF9jYXBhYmxlKGludGVsX2Nvbm5lY3RvcikpCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJt L2RybV9kcF9oZWxwZXIuaCBiL2luY2x1ZGUvZHJtL2RybV9kcF9oZWxwZXIuaAo+IGluZGV4IDUx ZWNiNTExMmVmOC4uYTQ0NDIwOWNkNTRiIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9k cF9oZWxwZXIuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9kcF9oZWxwZXIuaAo+IEBAIC0xNTIw LDYgKzE1MjAsMTQgQEAgZW51bSBkcm1fZHBfcXVpcmsgewo+ICAJICogVGhlIGRyaXZlciBzaG91 bGQgaWdub3JlIFNJTktfQ09VTlQgZHVyaW5nIGRldGVjdGlvbi4KPiAgCSAqLwo+ICAJRFBfRFBD RF9RVUlSS19OT19TSU5LX0NPVU5ULAo+ICsJLyoqCj4gKwkgKiBARFBfRFBDRF9RVUlSS19GT1JD RV9EUENEX0JBQ0tMSUdIVDoKPiArCSAqCj4gKwkgKiBUaGUgZGV2aWNlIGlzIHRlbGxpbmcgdGhl IHRydXRoIHdoZW4gaXQgc2F5cyB0aGF0IGl0IHVzZXMgRFBDRAo+ICsJICogYmFja2xpZ2h0IGNv bnRyb2xzLCBldmVuIGlmIHRoZSBzeXN0ZW0ncyBmaXJtd2FyZSBkaXNhZ3JlZXMuCj4gKwkgKiBU aGUgZHJpdmVyIHNob3VsZCBob25vciB0aGUgRFBDRCBiYWNrbGlnaHQgY2FwYWJpbGl0aWVzIGFk dmVydGlzZWQuCj4gKwkgKi8KPiArCURQX0RQQ0RfUVVJUktfRk9SQ0VfRFBDRF9CQUNLTElHSFQs Cj4gIH07Cj4gIAo+ICAvKioKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3Jh cGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F1A4C432C0 for ; Tue, 3 Dec 2019 12:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 111AA20803 for ; Tue, 3 Dec 2019 12:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726444AbfLCMmX (ORCPT ); Tue, 3 Dec 2019 07:42:23 -0500 Received: from mga04.intel.com ([192.55.52.120]:54928 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725954AbfLCMmX (ORCPT ); Tue, 3 Dec 2019 07:42:23 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 04:42:23 -0800 X-IronPort-AV: E=Sophos;i="5.69,273,1571727600"; d="scan'208";a="213397102" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 04:42:19 -0800 From: Jani Nikula To: Lyude Paul , intel-gfx@lists.freedesktop.org Cc: Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , Joonas Lahtinen , Rodrigo Vivi , Chris Wilson , Lee Shawn C , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel In-Reply-To: <20191122231616.2574-6-lyude@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191122231616.2574-1-lyude@redhat.com> <20191122231616.2574-6-lyude@redhat.com> Date: Tue, 03 Dec 2019 14:42:17 +0200 Message-ID: <87lfrtinrq.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Nov 2019, Lyude Paul wrote: > Annoyingly, the VBT on the ThinkPad X1 Extreme 2nd Gen indicates that > the system uses plain PWM based backlight controls, when in reality the > only backlight controls that work are the standard VESA eDP DPCD > backlight controls. > > Honestly, this makes me wonder how many other systems have these issues > or lie about this in their VBT. Not sure we have any good way of finding > out until panels like this become more common place in the laptop > market. For now, just add a DRM DP quirk to indicate that this panel is > telling the truth and is being a good LCD. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112376 > Signed-off-by: Lyude Paul Acked-by: Jani Nikula > --- > drivers/gpu/drm/drm_dp_helper.c | 4 ++++ > drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++++++++-- > include/drm/drm_dp_helper.h | 8 ++++++++ > 3 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > index 2c7870aef469..ec7061e3a99b 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -1155,6 +1155,10 @@ static const struct dpcd_quirk dpcd_quirk_list[] = { > { OUI(0x00, 0x10, 0xfa), DEVICE_ID_ANY, false, BIT(DP_DPCD_QUIRK_NO_PSR) }, > /* CH7511 seems to leave SINK_COUNT zeroed */ > { OUI(0x00, 0x00, 0x00), DEVICE_ID('C', 'H', '7', '5', '1', '1'), false, BIT(DP_DPCD_QUIRK_NO_SINK_COUNT) }, > + /* Optional 4K AMOLED panel in the ThinkPad X1 Extreme 2nd Generation > + * only supports DPCD backlight controls, despite advertising otherwise > + */ > + { OUI(0xba, 0x41, 0x59), DEVICE_ID_ANY, false, BIT(DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT) }, > }; > > #undef OUI > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > index 87b59db9ffe3..3d61260b08ad 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > @@ -325,11 +325,17 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector) > int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector) > { > struct intel_panel *panel = &intel_connector->panel; > - struct drm_i915_private *dev_priv = to_i915(intel_connector->base.dev); > + struct intel_dp *intel_dp = > + enc_to_intel_dp(&intel_connector->encoder->base); > + struct drm_i915_private *dev_priv = > + to_i915(intel_connector->base.dev); > > if (i915_modparams.enable_dpcd_backlight == 0 || > (i915_modparams.enable_dpcd_backlight == -1 && > - dev_priv->vbt.backlight.type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE)) > + dev_priv->vbt.backlight.type != > + INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE && > + !drm_dp_has_quirk(&intel_dp->desc, > + DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT))) > return -ENODEV; > > if (!intel_dp_aux_display_control_capable(intel_connector)) > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index 51ecb5112ef8..a444209cd54b 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -1520,6 +1520,14 @@ enum drm_dp_quirk { > * The driver should ignore SINK_COUNT during detection. > */ > DP_DPCD_QUIRK_NO_SINK_COUNT, > + /** > + * @DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT: > + * > + * The device is telling the truth when it says that it uses DPCD > + * backlight controls, even if the system's firmware disagrees. > + * The driver should honor the DPCD backlight capabilities advertised. > + */ > + DP_DPCD_QUIRK_FORCE_DPCD_BACKLIGHT, > }; > > /** -- Jani Nikula, Intel Open Source Graphics Center