From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A40AC43331 for ; Wed, 13 Nov 2019 11:13:50 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF04F222C2 for ; Wed, 13 Nov 2019 11:13:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="prv+uukc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF04F222C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47ChnR0mHRzF45l for ; Wed, 13 Nov 2019 22:13:47 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47Chgl6t9kzF4s7 for ; Wed, 13 Nov 2019 22:08:51 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="prv+uukc"; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 47Chgh6SPTz9sNH; Wed, 13 Nov 2019 22:08:48 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1573643331; bh=ToKhbEA1zIEt/CqcqU8IvA0xCdgG7bCPEQrifiO4Ef4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=prv+uukcXKixsHi6a8IlTLYS2Risu4DU1MJixf5189oCDB3vTaTA22QlIa7AaGeFp yX+zuh+uBXKNykQDYeCciV7d2W7eZ98SmA4fHHynwRiGG4wShJQyVqyWdSlUUD5nn0 vIxKztntKAp3kLcIYsQW56+F1hwT7VAyfCowvjD53PuzoRDJMG4YmSJIyx4adpTztz OJ5q1UhFZyETdY39NfxN3YPvXV6lSP+onIUb3shwisbQxAOY0PRbQAHeNXStRCubzq /vd7ysb8tUZUBQNbYrujZVyglaSnOpcVg4M+PgCfxdHKTQtgN6F8euFxIcKjVy+FUm 5kS2ey3jPm83A== From: Michael Ellerman To: David Hildenbrand , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 08/12] powerpc/pseries: CMM: Implement balloon compaction In-Reply-To: <8e46b1c5-f52b-0155-4d4f-e3bbdea95384@redhat.com> References: <20191031142933.10779-1-david@redhat.com> <20191031142933.10779-9-david@redhat.com> <87blth2wyk.fsf@mpe.ellerman.id.au> <8e46b1c5-f52b-0155-4d4f-e3bbdea95384@redhat.com> Date: Wed, 13 Nov 2019 22:08:44 +1100 Message-ID: <87lfsk11ab.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Enrico Weigelt, metux IT consult" , Oliver O'Halloran , Pavel Tatashin , Alexey Kardashevskiy , Gao Xiang , Greg Hackmann , David Howells , linux-mm@kvack.org, Arun KS , Paul Mackerras , Allison Randal , Christian Brauner , Greg Kroah-Hartman , Geert Uytterhoeven , Andrew Morton , Todd Kjos , linuxppc-dev@lists.ozlabs.org, Thomas Gleixner , Thiago Jung Bauermann , Anshuman Khandual Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" David Hildenbrand writes: > On 12.11.19 11:46, Michael Ellerman wrote: >> David Hildenbrand writes: >>> On 31.10.19 15:29, David Hildenbrand wrote: >>>> We can now get rid of the cmm_lock and completely rely on the balloon >>>> compaction internals, which now also manage the page list and the lock. >> ... >>>> + >>>> +static int cmm_migratepage(struct balloon_dev_info *b_dev_info, >>>> + struct page *newpage, struct page *page, >>>> + enum migrate_mode mode) >>>> +{ >>>> + unsigned long flags; >>>> + >>>> + /* >>>> + * loan/"inflate" the newpage first. >>>> + * >>>> + * We might race against the cmm_thread who might discover after our >>>> + * loan request that another page is to be unloaned. However, once >>>> + * the cmm_thread runs again later, this error will automatically >>>> + * be corrected. >>>> + */ >>>> + if (plpar_page_set_loaned(newpage)) { >>>> + /* Unlikely, but possible. Tell the caller not to retry now. */ >>>> + pr_err_ratelimited("%s: Cannot set page to loaned.", __func__); >>>> + return -EBUSY; >>>> + } >>>> + >>>> + /* balloon page list reference */ >>>> + get_page(newpage); >>>> + >>>> + spin_lock_irqsave(&b_dev_info->pages_lock, flags); >>>> + balloon_page_insert(b_dev_info, newpage); >>>> + balloon_page_delete(page); >>> >>> I think I am missing a b_dev_info->isolated_pages-- here. >> >> I don't know this code at all, but looking at other balloon drivers they >> do seem to do that in roughly the same spot. >> >> I'll add it, how can we test that it's correct? > > It's certainly correct. We increment when we isolate > (balloon_page_isolate()) and decrement when we un-isolate. > > Un-isolate happens when we putback a isolated page > (balloon_page_putback() - migration aborted) or when we successfully > migrate it (via balloon_page_migrate()). > > The issue is that we cannot decrement in balloon_page_migrate(), as we > have to hold the b_dev_info->pages_lock. That's why we have to do it in > the registered callback under lock. OK, I get it now. > Please note that b_dev_info->isolated_pages is only needed for a sanity > check in balloon_page_dequeue(). That's why I didn't notice during > testing. I wonder if we should at some point rip out that sanity check ... OK. Sanity checks can be good, though checks that call BUG() are less nice :) But I'm not an mm expert so I'll defer to you folks on the sanity check. For now I've merged this series with the decrement added to cmm_migratepage(). cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52E05C43331 for ; Wed, 13 Nov 2019 11:09:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 180E4222C2 for ; Wed, 13 Nov 2019 11:08:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="prv+uukc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 180E4222C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A8C136B0006; Wed, 13 Nov 2019 06:08:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A15BB6B0007; Wed, 13 Nov 2019 06:08:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 905286B0008; Wed, 13 Nov 2019 06:08:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id 7BE216B0006 for ; Wed, 13 Nov 2019 06:08:59 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 339C552AC for ; Wed, 13 Nov 2019 11:08:59 +0000 (UTC) X-FDA: 76150981998.07.vest47_3144fc10b7510 X-HE-Tag: vest47_3144fc10b7510 X-Filterd-Recvd-Size: 5166 Received: from ozlabs.org (ozlabs.org [203.11.71.1]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 Nov 2019 11:08:58 +0000 (UTC) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 47Chgh6SPTz9sNH; Wed, 13 Nov 2019 22:08:48 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1573643331; bh=ToKhbEA1zIEt/CqcqU8IvA0xCdgG7bCPEQrifiO4Ef4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=prv+uukcXKixsHi6a8IlTLYS2Risu4DU1MJixf5189oCDB3vTaTA22QlIa7AaGeFp yX+zuh+uBXKNykQDYeCciV7d2W7eZ98SmA4fHHynwRiGG4wShJQyVqyWdSlUUD5nn0 vIxKztntKAp3kLcIYsQW56+F1hwT7VAyfCowvjD53PuzoRDJMG4YmSJIyx4adpTztz OJ5q1UhFZyETdY39NfxN3YPvXV6lSP+onIUb3shwisbQxAOY0PRbQAHeNXStRCubzq /vd7ysb8tUZUBQNbYrujZVyglaSnOpcVg4M+PgCfxdHKTQtgN6F8euFxIcKjVy+FUm 5kS2ey3jPm83A== From: Michael Ellerman To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , Benjamin Herrenschmidt , Paul Mackerras , Thiago Jung Bauermann , Geert Uytterhoeven , Anshuman Khandual , Oliver O'Halloran , Alexey Kardashevskiy , "Enrico Weigelt\, metux IT consult" , Thomas Gleixner , Allison Randal , Greg Kroah-Hartman , Pavel Tatashin , Arun KS , Todd Kjos , Christian Brauner , Gao Xiang , Greg Hackmann , David Howells Subject: Re: [PATCH v1 08/12] powerpc/pseries: CMM: Implement balloon compaction In-Reply-To: <8e46b1c5-f52b-0155-4d4f-e3bbdea95384@redhat.com> References: <20191031142933.10779-1-david@redhat.com> <20191031142933.10779-9-david@redhat.com> <87blth2wyk.fsf@mpe.ellerman.id.au> <8e46b1c5-f52b-0155-4d4f-e3bbdea95384@redhat.com> Date: Wed, 13 Nov 2019 22:08:44 +1100 Message-ID: <87lfsk11ab.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Hildenbrand writes: > On 12.11.19 11:46, Michael Ellerman wrote: >> David Hildenbrand writes: >>> On 31.10.19 15:29, David Hildenbrand wrote: >>>> We can now get rid of the cmm_lock and completely rely on the balloon >>>> compaction internals, which now also manage the page list and the lock. >> ... >>>> + >>>> +static int cmm_migratepage(struct balloon_dev_info *b_dev_info, >>>> + struct page *newpage, struct page *page, >>>> + enum migrate_mode mode) >>>> +{ >>>> + unsigned long flags; >>>> + >>>> + /* >>>> + * loan/"inflate" the newpage first. >>>> + * >>>> + * We might race against the cmm_thread who might discover after our >>>> + * loan request that another page is to be unloaned. However, once >>>> + * the cmm_thread runs again later, this error will automatically >>>> + * be corrected. >>>> + */ >>>> + if (plpar_page_set_loaned(newpage)) { >>>> + /* Unlikely, but possible. Tell the caller not to retry now. */ >>>> + pr_err_ratelimited("%s: Cannot set page to loaned.", __func__); >>>> + return -EBUSY; >>>> + } >>>> + >>>> + /* balloon page list reference */ >>>> + get_page(newpage); >>>> + >>>> + spin_lock_irqsave(&b_dev_info->pages_lock, flags); >>>> + balloon_page_insert(b_dev_info, newpage); >>>> + balloon_page_delete(page); >>> >>> I think I am missing a b_dev_info->isolated_pages-- here. >> >> I don't know this code at all, but looking at other balloon drivers they >> do seem to do that in roughly the same spot. >> >> I'll add it, how can we test that it's correct? > > It's certainly correct. We increment when we isolate > (balloon_page_isolate()) and decrement when we un-isolate. > > Un-isolate happens when we putback a isolated page > (balloon_page_putback() - migration aborted) or when we successfully > migrate it (via balloon_page_migrate()). > > The issue is that we cannot decrement in balloon_page_migrate(), as we > have to hold the b_dev_info->pages_lock. That's why we have to do it in > the registered callback under lock. OK, I get it now. > Please note that b_dev_info->isolated_pages is only needed for a sanity > check in balloon_page_dequeue(). That's why I didn't notice during > testing. I wonder if we should at some point rip out that sanity check ... OK. Sanity checks can be good, though checks that call BUG() are less nice :) But I'm not an mm expert so I'll defer to you folks on the sanity check. For now I've merged this series with the decrement added to cmm_migratepage(). cheers