From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8717FCA9EC2 for ; Mon, 28 Oct 2019 21:59:45 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0154F21479 for ; Mon, 28 Oct 2019 21:59:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="CnI9xtdw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0154F21479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5DDD321C1; Mon, 28 Oct 2019 22:58:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5DDD321C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572299983; bh=yF/5AJjDt6FI721qUXUl/lNnzcrJ4yeJVMfR6q1KU8o=; h=From:To:References:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CnI9xtdwuNRA1I4/e8xPx0OMrRuDiM6BVRAMAEeGhzygf0Mu+M9/ZXu8HSeRUPffm qgAhua7u/5ePpBcocC/do6kAOVeCRupy2HD279Z1whDOrCggR7QLyA0RNcW7dHXN21 L/7fn4tOUfGs7Bmyu/L9dxXL00l/mJNY31ooBvKw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2DD95F8048F; Mon, 28 Oct 2019 22:48:06 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A3795F805FB; Mon, 28 Oct 2019 22:48:04 +0100 (CET) Received: from smtp.smtpout.orange.fr (smtp09.smtpout.orange.fr [80.12.242.131]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 04EF7F8048F for ; Mon, 28 Oct 2019 22:48:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 04EF7F8048F Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K9o0210015TFNlm039o0FH; Mon, 28 Oct 2019 22:48:00 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 22:48:00 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-31-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 22:47:59 +0100 In-Reply-To: <20191018154201.1276638-31-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:46 +0200") Message-ID: <87lft4k0ds.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, Linus Walleij , linux-kernel@vger.kernel.org, Haojian Zhuang , Daniel Mack , linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH 31/46] ASoC: pxa: ac97: use normal MMIO accessors X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Arnd Bergmann writes: > To avoid dereferencing hardwired constant pointers from a global header > file, change the driver to use devm_platform_ioremap_resource for getting > an __iomem pointer, and then using readl/writel on that. > > Each pointer dereference gets changed by a search&replace, which leads > to a few overlong lines, but seems less risky than trying to clean up > the code at the same time. > > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann Acked-by: Robert Jarzmik Cheers. -- Robert _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E6F1CA9EC1 for ; Mon, 28 Oct 2019 21:48:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6492C21479 for ; Mon, 28 Oct 2019 21:48:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E88Z2VHv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6492C21479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nCDG592Tvzkb+ObgjaYitBrSY13gilJFIV7crdB9fUE=; b=E88Z2VHvDfVeDz 4NIqsiDhrLI9PHxyo0TK4k0iZxl9bWHc2FoPwDkzIdJSAH9aPGATi+9XTB75Sxap12/5BA4Nl1YuE wIJWu//Gs+va6jDVvieWJtcK2rQe44RtwiGU87Sw/3dWx84tf9mvhg+zb/PYJQXvWsUjdL0zMKzu0 OKzBHMlUNCP8t7V0nwkjrPtKR4TCxJGoFWQhIzU0ZHtGWU1rm0cIfzxSfs2HbWUycuMVAMN6FFHca vm7/Dv4HJ5YOS3uD3Tu2Kt+7INTuWYw+nyvsDZPNrNMmItmbpyTgxF9X32NpJf4gCi8A6aYmpbgzv aUB8mCCAz6cVfLBMnnOw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPCru-0008U5-4f; Mon, 28 Oct 2019 21:48:06 +0000 Received: from smtp09.smtpout.orange.fr ([80.12.242.131] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPCrq-0008St-Bi for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2019 21:48:03 +0000 Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K9o0210015TFNlm039o0FH; Mon, 28 Oct 2019 22:48:00 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 22:48:00 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann Subject: Re: [PATCH 31/46] ASoC: pxa: ac97: use normal MMIO accessors References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-31-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 22:47:59 +0100 In-Reply-To: <20191018154201.1276638-31-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:46 +0200") Message-ID: <87lft4k0ds.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_144802_683836_893AE5E2 X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Linus Walleij , linux-kernel@vger.kernel.org, Haojian Zhuang , Daniel Mack , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Arnd Bergmann writes: > To avoid dereferencing hardwired constant pointers from a global header > file, change the driver to use devm_platform_ioremap_resource for getting > an __iomem pointer, and then using readl/writel on that. > > Each pointer dereference gets changed by a search&replace, which leads > to a few overlong lines, but seems less risky than trying to clean up > the code at the same time. > > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann Acked-by: Robert Jarzmik Cheers. -- Robert _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 282D3CA9EC0 for ; Mon, 28 Oct 2019 21:48:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F17B221479 for ; Mon, 28 Oct 2019 21:48:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732634AbfJ1VsC (ORCPT ); Mon, 28 Oct 2019 17:48:02 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:22441 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730592AbfJ1VsC (ORCPT ); Mon, 28 Oct 2019 17:48:02 -0400 Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K9o0210015TFNlm039o0FH; Mon, 28 Oct 2019 22:48:00 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 22:48:00 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , alsa-devel@alsa-project.org Subject: Re: [PATCH 31/46] ASoC: pxa: ac97: use normal MMIO accessors References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-31-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 22:47:59 +0100 In-Reply-To: <20191018154201.1276638-31-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:46 +0200") Message-ID: <87lft4k0ds.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > To avoid dereferencing hardwired constant pointers from a global header > file, change the driver to use devm_platform_ioremap_resource for getting > an __iomem pointer, and then using readl/writel on that. > > Each pointer dereference gets changed by a search&replace, which leads > to a few overlong lines, but seems less risky than trying to clean up > the code at the same time. > > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann Acked-by: Robert Jarzmik Cheers. -- Robert