From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Tony Chuang <yhchuang@realtek.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 4/6] rtw88: update regulatory settings implementaion
Date: Sat, 19 Oct 2019 14:14:41 +0300 [thread overview]
Message-ID: <87lfthvvfi.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+ASDXPkU8+8haHbyiQ5gf2e6rZ-2ks=D6zfV0CDnAzaWPZXFA@mail.gmail.com> (Brian Norris's message of "Wed, 16 Oct 2019 20:17:32 -0700")
Brian Norris <briannorris@chromium.org> writes:
> On Wed, Oct 16, 2019 at 7:55 PM Tony Chuang <yhchuang@realtek.com> wrote:
>>
>> From: Brian Norris
>> >
>> > On Wed, Oct 16, 2019 at 5:33 AM <yhchuang@realtek.com> wrote:
>> > > This also supports user regulatory hints, and it should only be
>> > > enabled for specific distributions that need this to correct
>> > > the cards reglutory.
> ...
>> > There should be a pretty high bar for introducing either new CONFIG_*
>> > options or module parameters, in my opinion, and I'm not sure you
>> > really satisfied it. Why "should only be enabled" by certain
>> > distributions? Your opinion? If it's the technical limitation you
>> > refer to ("efuse settings"), then just detect the efuse and prevent
>> > user hints only on those modules.
>> >
>>
>> Because the efuse/module does not contain the information if the
>> user's hint is allowed. But sometimes distributions require to set the
>> regulatory via "NL80211_CMD_SET_REG".
>> So we are leaving the CONFIG_* here for some reason that needs it.
>
> Is there ever a case where user hint is not allowed? For what reason?
> If not efuse, then what?
>
> Or alternatively: if someone sets CONFIG_RTW88_REGD_USER_REG_HINTS=y,
> then what problems will they have? Technical problems (e.g., firmware
> will crash on certain modules) or <other> problems?
I'm not convinced either that a Kconfig option is the correct thing to
do here. We need to understand more about the background first.
This patch needs a lot more discussion, please move it out from this
patchset and handle it separately. That way it won't block other
patches.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-10-19 11:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 12:32 [PATCH v2 0/6] rtw88: minor throughput improvement yhchuang
2019-10-16 12:32 ` [PATCH v2 1/6] rtw88: use macro to check the current band yhchuang
2019-10-16 17:10 ` Brian Norris
2019-10-17 2:39 ` Tony Chuang
2019-11-06 20:53 ` Brian Norris
2019-11-07 3:35 ` Tony Chuang
2019-10-16 12:32 ` [PATCH v2 2/6] rtw88: add power tracking support yhchuang
2019-10-17 10:32 ` Chris Chiu
2019-10-16 12:32 ` [PATCH v2 3/6] rtw88: Enable 802.11ac beamformee support yhchuang
2019-10-16 17:06 ` Brian Norris
2019-10-17 2:43 ` Tony Chuang
2019-10-16 12:32 ` [PATCH v2 4/6] rtw88: update regulatory settings implementaion yhchuang
2019-10-16 16:53 ` Brian Norris
2019-10-17 2:55 ` Tony Chuang
2019-10-17 3:17 ` Brian Norris
2019-10-19 11:14 ` Kalle Valo [this message]
2019-10-16 12:33 ` [PATCH v2 5/6] rtw88: add set_bitrate_mask support yhchuang
2019-10-17 10:25 ` Chris Chiu
2019-10-19 11:18 ` Kalle Valo
2019-10-16 12:33 ` [PATCH v2 6/6] rtw88: add phy_info debugfs to show Tx/Rx physical status yhchuang
2019-10-18 7:02 ` Chris Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfthvvfi.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.