From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: drivers/gpu/drm/i915/display/intel_display.c:3934 skl_plane_stride() error: testing array offset 'color_plane' after use. Date: Mon, 16 Sep 2019 10:31:35 +0300 Message-ID: <87lfuou27c.fsf@intel.com> References: <20190914040858.GT20699@kadam> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id C24676E860 for ; Mon, 16 Sep 2019 07:30:25 +0000 (UTC) In-Reply-To: <20190914040858.GT20699@kadam> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dan Carpenter , kbuild@01.org Cc: intel-gfx@lists.freedesktop.org, kbuild-all@01.org, linux-kernel@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org T24gU2F0LCAxNCBTZXAgMjAxOSwgRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUu Y29tPiB3cm90ZToKPiB0cmVlOiAgIGh0dHBzOi8va2VybmVsLmdvb2dsZXNvdXJjZS5jb20vcHVi L3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdCBtYXN0ZXIKPiBoZWFkOiAg IGE3Zjg5NjE2YjczNzY0OTU0MjRmNjgyYjYwODZlMGMzOTFhODlhMWQKPiBjb21taXQ6IGRmMDU2 NmE2NDFmOTU5MTA4YzE1MmJlNzQ4YTBhNTg3OTQyODBlMGUgZHJtL2k5MTU6IG1vdmUgbW9kZXNl dHRpbmcgY29yZSBjb2RlIHVuZGVyIGRpc3BsYXkvCj4gZGF0ZTogICAzIG1vbnRocyBhZ28KPgo+ IElmIHlvdSBmaXggdGhlIGlzc3VlLCBraW5kbHkgYWRkIGZvbGxvd2luZyB0YWcKPiBSZXBvcnRl ZC1ieToga2J1aWxkIHRlc3Qgcm9ib3QgPGxrcEBpbnRlbC5jb20+Cj4gUmVwb3J0ZWQtYnk6IERh biBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KPgo+IE5ldyBzbWF0Y2ggd2Fy bmluZ3M6Cj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmM6Mzkz NCBza2xfcGxhbmVfc3RyaWRlKCkgZXJyb3I6IHRlc3RpbmcgYXJyYXkgb2Zmc2V0ICdjb2xvcl9w bGFuZScgYWZ0ZXIgdXNlLgo+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlz cGxheS5jOjE2MzI4IGludGVsX3Nhbml0aXplX2VuY29kZXIoKSBlcnJvcjogd2UgcHJldmlvdXNs eSBhc3N1bWVkICdjcnRjJyBjb3VsZCBiZSBudWxsIChzZWUgbGluZSAxNjMxOCkKCk9kZCwgd2hh dCBjaGFuZ2VkIHRvIHByb3Zva2UgdGhlIHdhcm5pbmdzIG5vdz8gT3IgaXMgdGhlIHNtYXRjaCB0 ZXN0Cm5ldz8KCkFueXdheSwgQ2M6IFZpbGxlICYgaW50ZWwtZ2Z4LgoKQlIsCkphbmkuCgoKPgo+ IGdpdCByZW1vdGUgYWRkIGxpbnVzIGh0dHBzOi8va2VybmVsLmdvb2dsZXNvdXJjZS5jb20vcHVi L3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdAo+IGdpdCByZW1vdGUgdXBk YXRlIGxpbnVzCj4gZ2l0IGNoZWNrb3V0IGRmMDU2NmE2NDFmOTU5MTA4YzE1MmJlNzQ4YTBhNTg3 OTQyODBlMGUKPiB2aW0gKy9jb2xvcl9wbGFuZSArMzkzNCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9k aXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+Cj4gYjNjZjVjMDZjYTUwMDEgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jIFZpbGxlIFN5cmrDpGzDpCAyMDE4LTA5LTI1ICAzOTI2ICAK PiBkZjc5Y2Y0NDE5MTAyOSBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgVmls bGUgU3lyasOkbMOkIDIwMTgtMDktMTEgIDM5MjcgIHUzMiBza2xfcGxhbmVfc3RyaWRlKGNvbnN0 IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUsCj4gNWQyYTE5NTA3Y2I2NjUg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIFZpbGxlIFN5cmrDpGzDpCAyMDE4 LTA5LTA3ICAzOTI4ICAJCSAgICAgaW50IGNvbG9yX3BsYW5lKQo+IGQyMTk2Nzc0MGY0YjdkIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBWaWxsZSBTeXJqw6Rsw6QgMjAxNi0w MS0yOCAgMzkyOSAgewo+IGRmNzljZjQ0MTkxMDI5IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYyBWaWxsZSBTeXJqw6Rsw6QgMjAxOC0wOS0xMSAgMzkzMCAgCWNvbnN0IHN0cnVj dCBkcm1fZnJhbWVidWZmZXIgKmZiID0gcGxhbmVfc3RhdGUtPmJhc2UuZmI7Cj4gZGY3OWNmNDQx OTEwMjkgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIFZpbGxlIFN5cmrDpGzD pCAyMDE4LTA5LTExICAzOTMxICAJdW5zaWduZWQgaW50IHJvdGF0aW9uID0gcGxhbmVfc3RhdGUt PmJhc2Uucm90YXRpb247Cj4gNWQyYTE5NTA3Y2I2NjUgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jIFZpbGxlIFN5cmrDpGzDpCAyMDE4LTA5LTA3ICAzOTMyICAJdTMyIHN0cmlk ZSA9IHBsYW5lX3N0YXRlLT5jb2xvcl9wbGFuZVtjb2xvcl9wbGFuZV0uc3RyaWRlOwo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIF5eXl5eXl5eXl5eCj4gT3V0IG9mIGJvdW5kcyByZWFkPwo+Cj4gMWI1MDA1MzVjNTEz YWMgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIFZpbGxlIFN5cmrDpGzDpCAy MDE3LTAzLTA3ICAzOTMzICAKPiA1ZDJhMTk1MDdjYjY2NSBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMgVmlsbGUgU3lyasOkbMOkIDIwMTgtMDktMDcgQDM5MzQgIAlpZiAoY29s b3JfcGxhbmUgPj0gZmItPmZvcm1hdC0+bnVtX3BsYW5lcykKPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIF5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl4KPiBU ZXN0ZWQgdG9vIGxhdGUuCj4KPiAxYjUwMDUzNWM1MTNhYyBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMgVmlsbGUgU3lyasOkbMOkIDIwMTctMDMtMDcgIDM5MzUgIAkJcmV0dXJu IDA7Cj4gMWI1MDA1MzVjNTEzYWMgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j IFZpbGxlIFN5cmrDpGzDpCAyMDE3LTAzLTA3ICAzOTM2ICAKPiBiM2NmNWMwNmNhNTAwMSBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgVmlsbGUgU3lyasOkbMOkIDIwMTgtMDkt MjUgIDM5MzcgIAlyZXR1cm4gc3RyaWRlIC8gc2tsX3BsYW5lX3N0cmlkZV9tdWx0KGZiLCBjb2xv cl9wbGFuZSwgcm90YXRpb24pOwo+IGQyMTk2Nzc0MGY0YjdkIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYyBWaWxsZSBTeXJqw6Rsw6QgMjAxNi0wMS0yOCAgMzkzOCAgfQo+IGQy MTk2Nzc0MGY0YjdkIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBWaWxsZSBT eXJqw6Rsw6QgMjAxNi0wMS0yOCAgMzkzOSAgCj4KPiAtLS0KPiAwLURBWSBrZXJuZWwgdGVzdCBp bmZyYXN0cnVjdHVyZSAgICAgICAgICAgICAgICBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRl cgo+IGh0dHBzOi8vbGlzdHMuMDEub3JnL3BpcGVybWFpbC9rYnVpbGQtYWxsICAgICAgICAgICAg ICAgICAgIEludGVsIENvcnBvcmF0aW9uCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291 cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D2FC49ED7 for ; Mon, 16 Sep 2019 07:30:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04031217D7 for ; Mon, 16 Sep 2019 07:30:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727118AbfIPHaT convert rfc822-to-8bit (ORCPT ); Mon, 16 Sep 2019 03:30:19 -0400 Received: from mga04.intel.com ([192.55.52.120]:31550 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726084AbfIPHaT (ORCPT ); Mon, 16 Sep 2019 03:30:19 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Sep 2019 00:30:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,510,1559545200"; d="scan'208";a="201545238" Received: from lfgiles-mobl.ger.corp.intel.com (HELO localhost) ([10.252.40.121]) by fmsmga001.fm.intel.com with ESMTP; 16 Sep 2019 00:30:12 -0700 From: Jani Nikula To: Dan Carpenter , kbuild@01.org Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, Chris Wilson , intel-gfx@lists.freedesktop.org, Ville =?utf-8?B?U3lyasOkbMOk?= Subject: Re: drivers/gpu/drm/i915/display/intel_display.c:3934 skl_plane_stride() error: testing array offset 'color_plane' after use. In-Reply-To: <20190914040858.GT20699@kadam> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20190914040858.GT20699@kadam> Date: Mon, 16 Sep 2019 10:31:35 +0300 Message-ID: <87lfuou27c.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 14 Sep 2019, Dan Carpenter wrote: > tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git master > head: a7f89616b7376495424f682b6086e0c391a89a1d > commit: df0566a641f959108c152be748a0a58794280e0e drm/i915: move modesetting core code under display/ > date: 3 months ago > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > Reported-by: Dan Carpenter > > New smatch warnings: > drivers/gpu/drm/i915/display/intel_display.c:3934 skl_plane_stride() error: testing array offset 'color_plane' after use. > drivers/gpu/drm/i915/display/intel_display.c:16328 intel_sanitize_encoder() error: we previously assumed 'crtc' could be null (see line 16318) Odd, what changed to provoke the warnings now? Or is the smatch test new? Anyway, Cc: Ville & intel-gfx. BR, Jani. > > git remote add linus https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git > git remote update linus > git checkout df0566a641f959108c152be748a0a58794280e0e > vim +/color_plane +3934 drivers/gpu/drm/i915/display/intel_display.c > > b3cf5c06ca5001 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-25 3926 > df79cf44191029 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-11 3927 u32 skl_plane_stride(const struct intel_plane_state *plane_state, > 5d2a19507cb665 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-07 3928 int color_plane) > d21967740f4b7d drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2016-01-28 3929 { > df79cf44191029 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-11 3930 const struct drm_framebuffer *fb = plane_state->base.fb; > df79cf44191029 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-11 3931 unsigned int rotation = plane_state->base.rotation; > 5d2a19507cb665 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-07 3932 u32 stride = plane_state->color_plane[color_plane].stride; > ^^^^^^^^^^^ > Out of bounds read? > > 1b500535c513ac drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-07 3933 > 5d2a19507cb665 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-07 @3934 if (color_plane >= fb->format->num_planes) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > Tested too late. > > 1b500535c513ac drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-07 3935 return 0; > 1b500535c513ac drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-07 3936 > b3cf5c06ca5001 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-25 3937 return stride / skl_plane_stride_mult(fb, color_plane, rotation); > d21967740f4b7d drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2016-01-28 3938 } > d21967740f4b7d drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2016-01-28 3939 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation -- Jani Nikula, Intel Open Source Graphics Center