All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergio Lopez <slp@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: peter.maydell@linaro.org, cohuck@redhat.com,
	qemu-devel@nongnu.org, abologna@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] virtio-mmio: implement modern (v2) personality (virtio-1)
Date: Tue, 03 Sep 2019 12:23:14 +0200	[thread overview]
Message-ID: <87lfv5isq5.fsf@redhat.com> (raw)
In-Reply-To: <20190902093548.GD9069@stefanha-x1.localdomain>

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]


Stefan Hajnoczi <stefanha@gmail.com> writes:

> On Thu, Aug 29, 2019 at 06:50:27PM +0200, Sergio Lopez wrote:
>>      case VIRTIO_MMIO_QUEUE_PFN:
>> +        if (!proxy->legacy) {
>> +            qemu_log_mask(LOG_GUEST_ERROR,
>> +                "%s: read from legacy register (0x%lx) in non-legacy mode\n",
>> +                __func__, offset);
>
> Please use HWADDR_PRIx since offset has type hwaddr.  On ILP32 and LLP64
> hosts %lx is only 32-bit.

Ack.

Thanks!
Sergio.

> Otherwise:
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2019-09-03 10:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29 16:50 [Qemu-devel] [PATCH v2] virtio-mmio: implement modern (v2) personality (virtio-1) Sergio Lopez
2019-09-02  9:35 ` Stefan Hajnoczi
2019-09-03 10:23   ` Sergio Lopez [this message]
2019-09-02 13:41 ` Cornelia Huck
2019-09-03 10:22   ` Sergio Lopez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfv5isq5.fsf@redhat.com \
    --to=slp@redhat.com \
    --cc=abologna@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.