From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60DDDC04AAF for ; Tue, 21 May 2019 15:33:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38FF121743 for ; Tue, 21 May 2019 15:33:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38FF121743 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:55657 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT6lA-00029A-IL for qemu-devel@archiver.kernel.org; Tue, 21 May 2019 11:33:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT6gr-0007Oy-KZ for qemu-devel@nongnu.org; Tue, 21 May 2019 11:28:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hT6gq-0001Lo-ME for qemu-devel@nongnu.org; Tue, 21 May 2019 11:28:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38242) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hT6gq-0001L7-Fd for qemu-devel@nongnu.org; Tue, 21 May 2019 11:28:32 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9D63E13A6A; Tue, 21 May 2019 15:28:31 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-28.ams2.redhat.com [10.36.116.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D9FA608C2; Tue, 21 May 2019 15:28:29 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D4EDE1138648; Tue, 21 May 2019 17:28:27 +0200 (CEST) From: Markus Armbruster To: Eric Blake References: <20190521081227.30799-1-richardw.yang@linux.intel.com> Date: Tue, 21 May 2019 17:28:27 +0200 In-Reply-To: (Eric Blake's message of "Tue, 21 May 2019 07:00:12 -0500") Message-ID: <87lfyzrfms.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 21 May 2019 15:28:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, alex.bennee@linaro.org, qemu-devel@nongnu.org, kraxel@redhat.com, philmd@redhat.com, Wei Yang Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eric Blake writes: > On 5/21/19 3:12 AM, Wei Yang wrote: >> All the python script in scripts/qapi is used to generate qapi code. Use >> wildcard to simplify it. >> >> Signed-off-by: Wei Yang >> --- >> Makefile | 8 +------- >> 1 file changed, 1 insertion(+), 7 deletions(-) > > I'm not a fan of $(wildcard). It makes your tarball creation > non-deterministic - if there is a leftover file from development that is > no longer part of the build, wildcard will still pick it up. Explicit Actually, in this case can "only" adds spurious prerequisites. > lists are better. I'm inclined to NACK this, but Markus has final say > since he maintains the qapi generator. I consider use of $(wildcard) for the purpose of collecting sources a lazy mistake.