diff for duplicates of <87lfz9npan.fsf@vitty.brq.redhat.com> diff --git a/a/1.txt b/N1/1.txt index 8081f26..bc85663 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,9 @@ -Dan Carpenter <dan.carpenter@oracle.com> writes: +Dan Carpenter <dan.carpenter at oracle.com> writes: > The code is trying to check that all the padding is zeroed out and it > does this: > -> entry->padding[0] = entry->padding[1] = entry->padding[2] = 0 +> entry->padding[0] == entry->padding[1] == entry->padding[2] == 0 > > Assume everything is zeroed correctly, then the first comparison is > true, the next comparison is false and false is equal to zero so the @@ -15,7 +15,7 @@ Dan Carpenter <dan.carpenter@oracle.com> writes: > wasn't correct. > > Fixes: 7edcb7343327 ("KVM: selftests: Add hyperv_cpuid test") -> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> +> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > --- > tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) @@ -27,13 +27,13 @@ Dan Carpenter <dan.carpenter@oracle.com> writes: > @@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2 > *hv_cpuid_entries, -we also seem to check for 'entry->index = 0' twice here. +we also seem to check for 'entry->index == 0' twice here. -> TEST_ASSERT(entry->flags = 0, +> TEST_ASSERT(entry->flags == 0, > ".flags field should be zero"); > -> - TEST_ASSERT(entry->padding[0] = entry->padding[1] -> - = entry->padding[2] = 0, +> - TEST_ASSERT(entry->padding[0] == entry->padding[1] +> - == entry->padding[2] == 0, > - ".index field should be zero"); > + TEST_ASSERT(!entry->padding[0] && !entry->padding[1] && > + !entry->padding[2], "padding should be zero"); @@ -41,7 +41,7 @@ we also seem to check for 'entry->index = 0' twice here. > /* > * If needed for debug: -Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com> +Reviewed-by: Vitaly Kuznetsov <vkuznets at redhat.com> -- Vitaly diff --git a/a/content_digest b/N1/content_digest index 69ba12f..373ca89 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,22 +1,15 @@ "ref\020190514103451.GA1694@mwanda\0" - "From\0Vitaly Kuznetsov <vkuznets@redhat.com>\0" - "Subject\0Re: [PATCH] KVM: selftests: Fix a condition in test_hv_cpuid()\0" - "Date\0Tue, 14 May 2019 13:22:56 +0000\0" - "To\0Dan Carpenter <dan.carpenter@oracle.com>" - " Paolo Bonzini <pbonzini@redhat.com>\0" - "Cc\0Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" - Shuah Khan <shuah@kernel.org> - kvm@vger.kernel.org - linux-kselftest@vger.kernel.org - " kernel-janitors@vger.kernel.org\0" + "From\0vkuznets at redhat.com (Vitaly Kuznetsov)\0" + "Subject\0[PATCH] KVM: selftests: Fix a condition in test_hv_cpuid()\0" + "Date\0Tue, 14 May 2019 09:22:56 -0400\0" "\00:1\0" "b\0" - "Dan Carpenter <dan.carpenter@oracle.com> writes:\n" + "Dan Carpenter <dan.carpenter at oracle.com> writes:\n" "\n" "> The code is trying to check that all the padding is zeroed out and it\n" "> does this:\n" ">\n" - "> entry->padding[0] = entry->padding[1] = entry->padding[2] = 0\n" + "> entry->padding[0] == entry->padding[1] == entry->padding[2] == 0\n" ">\n" "> Assume everything is zeroed correctly, then the first comparison is\n" "> true, the next comparison is false and false is equal to zero so the\n" @@ -28,7 +21,7 @@ "> wasn't correct.\n" ">\n" "> Fixes: 7edcb7343327 (\"KVM: selftests: Add hyperv_cpuid test\")\n" - "> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" + "> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>\n" "> ---\n" "> tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 5 ++---\n" "> 1 file changed, 2 insertions(+), 3 deletions(-)\n" @@ -40,13 +33,13 @@ "> @@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2\n" "> *hv_cpuid_entries,\n" "\n" - "we also seem to check for 'entry->index = 0' twice here.\n" + "we also seem to check for 'entry->index == 0' twice here.\n" "\n" - "> \t\tTEST_ASSERT(entry->flags = 0,\n" + "> \t\tTEST_ASSERT(entry->flags == 0,\n" "> \t\t\t \".flags field should be zero\");\n" "> \n" - "> -\t\tTEST_ASSERT(entry->padding[0] = entry->padding[1]\n" - "> -\t\t\t = entry->padding[2] = 0,\n" + "> -\t\tTEST_ASSERT(entry->padding[0] == entry->padding[1]\n" + "> -\t\t\t == entry->padding[2] == 0,\n" "> -\t\t\t \".index field should be zero\");\n" "> +\t\tTEST_ASSERT(!entry->padding[0] && !entry->padding[1] &&\n" "> +\t\t\t !entry->padding[2], \"padding should be zero\");\n" @@ -54,9 +47,9 @@ "> \t\t/*\n" "> \t\t * If needed for debug:\n" "\n" - "Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>\n" + "Reviewed-by: Vitaly Kuznetsov <vkuznets at redhat.com>\n" "\n" "-- \n" Vitaly -b3844e312408e0caeb6f3f77a005468245dfc6c85f995123d5334423eddafed1 +770e6f133761c18bf712c91e9532b12adbe3610be56405b7236a45c178561069
diff --git a/a/1.txt b/N2/1.txt index 8081f26..bc85663 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,9 +1,9 @@ -Dan Carpenter <dan.carpenter@oracle.com> writes: +Dan Carpenter <dan.carpenter at oracle.com> writes: > The code is trying to check that all the padding is zeroed out and it > does this: > -> entry->padding[0] = entry->padding[1] = entry->padding[2] = 0 +> entry->padding[0] == entry->padding[1] == entry->padding[2] == 0 > > Assume everything is zeroed correctly, then the first comparison is > true, the next comparison is false and false is equal to zero so the @@ -15,7 +15,7 @@ Dan Carpenter <dan.carpenter@oracle.com> writes: > wasn't correct. > > Fixes: 7edcb7343327 ("KVM: selftests: Add hyperv_cpuid test") -> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> +> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > --- > tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) @@ -27,13 +27,13 @@ Dan Carpenter <dan.carpenter@oracle.com> writes: > @@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2 > *hv_cpuid_entries, -we also seem to check for 'entry->index = 0' twice here. +we also seem to check for 'entry->index == 0' twice here. -> TEST_ASSERT(entry->flags = 0, +> TEST_ASSERT(entry->flags == 0, > ".flags field should be zero"); > -> - TEST_ASSERT(entry->padding[0] = entry->padding[1] -> - = entry->padding[2] = 0, +> - TEST_ASSERT(entry->padding[0] == entry->padding[1] +> - == entry->padding[2] == 0, > - ".index field should be zero"); > + TEST_ASSERT(!entry->padding[0] && !entry->padding[1] && > + !entry->padding[2], "padding should be zero"); @@ -41,7 +41,7 @@ we also seem to check for 'entry->index = 0' twice here. > /* > * If needed for debug: -Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com> +Reviewed-by: Vitaly Kuznetsov <vkuznets at redhat.com> -- Vitaly diff --git a/a/content_digest b/N2/content_digest index 69ba12f..ef65018 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,22 +1,15 @@ "ref\020190514103451.GA1694@mwanda\0" - "From\0Vitaly Kuznetsov <vkuznets@redhat.com>\0" - "Subject\0Re: [PATCH] KVM: selftests: Fix a condition in test_hv_cpuid()\0" - "Date\0Tue, 14 May 2019 13:22:56 +0000\0" - "To\0Dan Carpenter <dan.carpenter@oracle.com>" - " Paolo Bonzini <pbonzini@redhat.com>\0" - "Cc\0Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" - Shuah Khan <shuah@kernel.org> - kvm@vger.kernel.org - linux-kselftest@vger.kernel.org - " kernel-janitors@vger.kernel.org\0" + "From\0vkuznets@redhat.com (Vitaly Kuznetsov)\0" + "Subject\0[PATCH] KVM: selftests: Fix a condition in test_hv_cpuid()\0" + "Date\0Tue, 14 May 2019 09:22:56 -0400\0" "\00:1\0" "b\0" - "Dan Carpenter <dan.carpenter@oracle.com> writes:\n" + "Dan Carpenter <dan.carpenter at oracle.com> writes:\n" "\n" "> The code is trying to check that all the padding is zeroed out and it\n" "> does this:\n" ">\n" - "> entry->padding[0] = entry->padding[1] = entry->padding[2] = 0\n" + "> entry->padding[0] == entry->padding[1] == entry->padding[2] == 0\n" ">\n" "> Assume everything is zeroed correctly, then the first comparison is\n" "> true, the next comparison is false and false is equal to zero so the\n" @@ -28,7 +21,7 @@ "> wasn't correct.\n" ">\n" "> Fixes: 7edcb7343327 (\"KVM: selftests: Add hyperv_cpuid test\")\n" - "> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" + "> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>\n" "> ---\n" "> tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 5 ++---\n" "> 1 file changed, 2 insertions(+), 3 deletions(-)\n" @@ -40,13 +33,13 @@ "> @@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2\n" "> *hv_cpuid_entries,\n" "\n" - "we also seem to check for 'entry->index = 0' twice here.\n" + "we also seem to check for 'entry->index == 0' twice here.\n" "\n" - "> \t\tTEST_ASSERT(entry->flags = 0,\n" + "> \t\tTEST_ASSERT(entry->flags == 0,\n" "> \t\t\t \".flags field should be zero\");\n" "> \n" - "> -\t\tTEST_ASSERT(entry->padding[0] = entry->padding[1]\n" - "> -\t\t\t = entry->padding[2] = 0,\n" + "> -\t\tTEST_ASSERT(entry->padding[0] == entry->padding[1]\n" + "> -\t\t\t == entry->padding[2] == 0,\n" "> -\t\t\t \".index field should be zero\");\n" "> +\t\tTEST_ASSERT(!entry->padding[0] && !entry->padding[1] &&\n" "> +\t\t\t !entry->padding[2], \"padding should be zero\");\n" @@ -54,9 +47,9 @@ "> \t\t/*\n" "> \t\t * If needed for debug:\n" "\n" - "Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>\n" + "Reviewed-by: Vitaly Kuznetsov <vkuznets at redhat.com>\n" "\n" "-- \n" Vitaly -b3844e312408e0caeb6f3f77a005468245dfc6c85f995123d5334423eddafed1 +bcf62241dde6a7dcf3a6041df84a8cc3fba6470848313bb09326f7b2b9262556
diff --git a/a/1.txt b/N3/1.txt index 8081f26..d80dfc1 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -3,7 +3,7 @@ Dan Carpenter <dan.carpenter@oracle.com> writes: > The code is trying to check that all the padding is zeroed out and it > does this: > -> entry->padding[0] = entry->padding[1] = entry->padding[2] = 0 +> entry->padding[0] == entry->padding[1] == entry->padding[2] == 0 > > Assume everything is zeroed correctly, then the first comparison is > true, the next comparison is false and false is equal to zero so the @@ -27,13 +27,13 @@ Dan Carpenter <dan.carpenter@oracle.com> writes: > @@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2 > *hv_cpuid_entries, -we also seem to check for 'entry->index = 0' twice here. +we also seem to check for 'entry->index == 0' twice here. -> TEST_ASSERT(entry->flags = 0, +> TEST_ASSERT(entry->flags == 0, > ".flags field should be zero"); > -> - TEST_ASSERT(entry->padding[0] = entry->padding[1] -> - = entry->padding[2] = 0, +> - TEST_ASSERT(entry->padding[0] == entry->padding[1] +> - == entry->padding[2] == 0, > - ".index field should be zero"); > + TEST_ASSERT(!entry->padding[0] && !entry->padding[1] && > + !entry->padding[2], "padding should be zero"); diff --git a/a/content_digest b/N3/content_digest index 69ba12f..ec1a765 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,7 +1,7 @@ "ref\020190514103451.GA1694@mwanda\0" "From\0Vitaly Kuznetsov <vkuznets@redhat.com>\0" "Subject\0Re: [PATCH] KVM: selftests: Fix a condition in test_hv_cpuid()\0" - "Date\0Tue, 14 May 2019 13:22:56 +0000\0" + "Date\0Tue, 14 May 2019 09:22:56 -0400\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>" " Paolo Bonzini <pbonzini@redhat.com>\0" "Cc\0Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" @@ -16,7 +16,7 @@ "> The code is trying to check that all the padding is zeroed out and it\n" "> does this:\n" ">\n" - "> entry->padding[0] = entry->padding[1] = entry->padding[2] = 0\n" + "> entry->padding[0] == entry->padding[1] == entry->padding[2] == 0\n" ">\n" "> Assume everything is zeroed correctly, then the first comparison is\n" "> true, the next comparison is false and false is equal to zero so the\n" @@ -40,13 +40,13 @@ "> @@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2\n" "> *hv_cpuid_entries,\n" "\n" - "we also seem to check for 'entry->index = 0' twice here.\n" + "we also seem to check for 'entry->index == 0' twice here.\n" "\n" - "> \t\tTEST_ASSERT(entry->flags = 0,\n" + "> \t\tTEST_ASSERT(entry->flags == 0,\n" "> \t\t\t \".flags field should be zero\");\n" "> \n" - "> -\t\tTEST_ASSERT(entry->padding[0] = entry->padding[1]\n" - "> -\t\t\t = entry->padding[2] = 0,\n" + "> -\t\tTEST_ASSERT(entry->padding[0] == entry->padding[1]\n" + "> -\t\t\t == entry->padding[2] == 0,\n" "> -\t\t\t \".index field should be zero\");\n" "> +\t\tTEST_ASSERT(!entry->padding[0] && !entry->padding[1] &&\n" "> +\t\t\t !entry->padding[2], \"padding should be zero\");\n" @@ -59,4 +59,4 @@ "-- \n" Vitaly -b3844e312408e0caeb6f3f77a005468245dfc6c85f995123d5334423eddafed1 +dfb253a0c1d178477382fa52dabb78827f426ba89ca383d4aba003cc3b96fe48
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.