From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Date: Tue, 26 Mar 2019 09:30:57 +0000 Subject: Re: [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check Message-Id: <87lg12yoby.fsf@gaia.fi.intel.com> List-Id: References: <20190326050843.GA20038@kadam> In-Reply-To: <20190326050843.GA20038@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Jani Nikula , Chris Wilson Cc: David Airlie , kernel-janitors@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann Dan Carpenter writes: > The live_context() function returns error pointers. It never returns > NULL. > > Fixes: 9c1477e83e62 ("drm/i915/selftests: Exercise adding requests to a full GGTT") > Signed-off-by: Dan Carpenter Reviewed-by: Mika Kuoppala i915_request.c has another :) -Mika > --- > drivers/gpu/drm/i915/selftests/i915_gem_evict.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_evict.c b/drivers/gpu/drm/i915/selftests/i915_gem_evict.c > index 9a9451846b33..89766688e420 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem_evict.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_evict.c > @@ -455,7 +455,7 @@ static int igt_evict_contexts(void *arg) > struct i915_gem_context *ctx; > > ctx = live_context(i915, file); > - if (!ctx) > + if (IS_ERR(ctx)) > break; > > /* We will need some GGTT space for the rq's context */ > -- > 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check Date: Tue, 26 Mar 2019 11:30:57 +0200 Message-ID: <87lg12yoby.fsf@gaia.fi.intel.com> References: <20190326050843.GA20038@kadam> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190326050843.GA20038@kadam> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dan Carpenter , Jani Nikula , Chris Wilson Cc: David Airlie , kernel-janitors@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann List-Id: dri-devel@lists.freedesktop.org RGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPiB3cml0ZXM6Cgo+IFRoZSBs aXZlX2NvbnRleHQoKSBmdW5jdGlvbiByZXR1cm5zIGVycm9yIHBvaW50ZXJzLiAgSXQgbmV2ZXIg cmV0dXJucwo+IE5VTEwuCj4KPiBGaXhlczogOWMxNDc3ZTgzZTYyICgiZHJtL2k5MTUvc2VsZnRl c3RzOiBFeGVyY2lzZSBhZGRpbmcgcmVxdWVzdHMgdG8gYSBmdWxsIEdHVFQiKQo+IFNpZ25lZC1v ZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KClJldmlld2Vk LWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KCmk5MTVf cmVxdWVzdC5jIGhhcyBhbm90aGVyIDopCgotTWlrYQoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvc2VsZnRlc3RzL2k5MTVfZ2VtX2V2aWN0LmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pOTE1X2dlbV9ldmljdC5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvc2VsZnRlc3RzL2k5MTVfZ2VtX2V2aWN0LmMKPiBpbmRleCA5YTk0NTE4NDZiMzMuLjg5 NzY2Njg4ZTQyMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMv aTkxNV9nZW1fZXZpY3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9p OTE1X2dlbV9ldmljdC5jCj4gQEAgLTQ1NSw3ICs0NTUsNyBAQCBzdGF0aWMgaW50IGlndF9ldmlj dF9jb250ZXh0cyh2b2lkICphcmcpCj4gIAkJCXN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHg7 Cj4gIAo+ICAJCQljdHggPSBsaXZlX2NvbnRleHQoaTkxNSwgZmlsZSk7Cj4gLQkJCWlmICghY3R4 KQo+ICsJCQlpZiAoSVNfRVJSKGN0eCkpCj4gIAkJCQlicmVhazsKPiAgCj4gIAkJCS8qIFdlIHdp bGwgbmVlZCBzb21lIEdHVFQgc3BhY2UgZm9yIHRoZSBycSdzIGNvbnRleHQgKi8KPiAtLSAKPiAy LjE3LjEKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4