From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v3 1/3] drm/i915: introduce REG_BIT() and REG_GENMASK() to define register contents Date: Thu, 28 Feb 2019 12:07:06 +0200 Message-ID: <87lg20ns51.fsf@intel.com> References: <5bd0d22ae0a0a3d7500e63ec80073c2f476faecb.1551286447.git.jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 61DBA89AA7 for ; Thu, 28 Feb 2019 10:05:07 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyOCBGZWIgMjAxOSwgTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0Bp bnRlbC5jb20+IHdyb3RlOgo+IE9uIFdlZCwgMjcgRmViIDIwMTkgMTg6MDI6MzYgKzAxMDAsIEph bmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+ICAKPiB3cm90ZToKPgo+PiBAQCAtMTE2 LDYgKzExNiwzNCBAQAo+PiAgICogICNkZWZpbmUgR0VOOF9CQVIgICAgICAgICAgICAgICAgICAg IF9NTUlPKDB4Yjg4OCkKPj4gICAqLwo+PiArLyoqCj4+ICsgKiBSRUdfQklUKCkgLSBQcmVwYXJl IGEgdTMyIGJpdCB2YWx1ZQo+PiArICogQF9fbjogMC1iYXNlZCBiaXQgbnVtYmVyCj4+ICsgKgo+ PiArICogTG9jYWwgd3JhcHBlciBmb3IgQklUKCkgdG8gZm9yY2UgdTMyLCB3aXRoIGNvbXBpbGUg dGltZSBjaGVja3MuCj4+ICsgKgo+PiArICogQHJldHVybjogVmFsdWUgd2l0aCBiaXQgQF9fbiBz ZXQuCj4+ICsgKi8KPj4gKyNkZWZpbmUgUkVHX0JJVChfX24pCQkJCQkJCVwKPj4gKwkoKHUzMiko QklUKF9fbikgKwkJCQkJCVwKPj4gKwkgICAgICAgQlVJTERfQlVHX09OX1pFUk8oX19idWlsdGlu X2NvbnN0YW50X3AoX19uKSAmJgkJXAo+PiArCQkJCSAoKF9fbikgPCAwIHx8IChfX24pID4gMzEp KSkpCj4KPiBNYXliZSB0byBzaW1wbGlmeSB0aGUgY29kZSB3ZSBjYW4gZGVmaW5lIHRoaXMgbWFj cm8gdXNpbmcgbWFjcm8gYmVsb3c6Cj4KPiAjZGVmaW5lIFJFR19CSVQoX19uKSBSRUdfR0VOTUFT SyhfX24sIF9fbikKCkkgZG9uJ3Qgd2FudCB0byBsaW1pdCB0aGUgbWFjcm8gdG8gY29uc3RhbnQg ZXhwcmVzc2lvbnMgKGV2ZW4gaWYgdGhhdCdzCnRoZSBtb3N0IGNvbW1vbiB1c2UgZm9yIHVzKSwg YW5kIGluIG5vbi1jb25zdGFudCBleHByZXNzaW9ucyB0aGUgc2ltcGxlCnNoaWZ0IGJlY29tZXMg dW5uZWNlc3NhcmlseSBjb21wbGljYXRlZCB3aXRoIEdFTk1BU0suIFBsdXMgdGhlcmUncyB0aGUK ZG91YmxlIGV2YWx1YXRpb24gb2YgX19uLgoKPgo+PiArCj4+ICsvKioKPj4gKyAqIFJFR19HRU5N QVNLKCkgLSBQcmVwYXJlIGEgY29udGludW91cyB1MzIgYml0bWFzawo+PiArICogQF9faGlnaDog MC1iYXNlZCBoaWdoIGJpdAo+PiArICogQF9fbG93OiAwLWJhc2VkIGxvdyBiaXQKPj4gKyAqCj4+ ICsgKiBMb2NhbCB3cmFwcGVyIGZvciBHRU5NQVNLKCkgdG8gZm9yY2UgdTMyLCB3aXRoIGNvbXBp bGUgdGltZSBjaGVja3MuCj4+ICsgKgo+PiArICogQHJldHVybjogQ29udGludW91cyBiaXRtYXNr IGZyb20gQF9faGlnaCB0byBAX19sb3csIGluY2x1c2l2ZS4KPj4gKyAqLwo+PiArI2RlZmluZSBS RUdfR0VOTUFTSyhfX2hpZ2gsIF9fbG93KQkJCQkJXAo+PiArCSgodTMyKShHRU5NQVNLKF9faGln aCwgX19sb3cpICsJCQkJCVwKPj4gKwkgICAgICAgQlVJTERfQlVHX09OX1pFUk8oX19idWlsdGlu X2NvbnN0YW50X3AoX19oaWdoKSAmJglcCj4+ICsJCQkJIF9fYnVpbHRpbl9jb25zdGFudF9wKF9f bG93KSAmJgkJXAo+PiArCQkJCSAoKF9fbG93KSA8IDAgfHwgKF9faGlnaCkgPiAzMSB8fCAoX19s b3cpID4gKF9faGlnaCkpKSkpCj4+ICsKPgo+IG5pdDogU2luY2Ugd2UgYXJlIGRlZmluaW5nIG5l dyBzZXQgb2YgbWFjcm9zLCBkbyB3ZSByZWFsbHkgaGF2ZSB0byBmb2xsb3cKPiBuYW1pbmcgb2Yg dGhlIHVuZGVybHlpbmcgbWFjcm9zPyBtYXliZSB3ZSBjYW4gY2FuIGhhdmUgY2xlYXIgbmV3IG5h bWVzOgo+Cj4gCVJFR19CSVQobikKPiAJUkVHX0JJVFMoaGksbG93KQoKV2UndmUgcHJldHR5IG11 Y2ggYmVlbiBoYXZpbmcgdGhpcyBjb252ZXJzYXRpb24gZXZlciBzaW5jZSB0aGUgZmlyc3QgUkZD CndhcyBwb3N0ZWQuIEl0IGNvdWxkIGJlIEJJVFMsIE1BU0ssIEdFTk1BU0ssIEZJRUxEIChleGNl cHQgdGhhdCBjbGFzaGVzCndpdGggUkVHX0ZJRUxEIGZyb20gcmVnbWFwLmgpLCBCSVRGSUVMRCwg d2hhdG5vdC4gQW5kIG5leHQgdGhpbmcgeW91Cmtub3csIHdlIGxvb2sgYXQgUkVHX0ZJRUxEX1BS RVAgYW5kIFJFR19GSUVMRF9HRVQgYW5kIHdvbmRlciBpZiB3ZQpzaG91bGQgaGF2ZSBvdXIgb3du IG5hbWVzIGZvciB0aGVtIHRvby4gUkVHX0JJVFNfUFJFUD8gUkVHX0JJVFNfVkFMVUU/ClJFR19C SVRTX0dFVD8KCldlICptaWdodCogYmUgYWJsZSB0byBjb21lIHVwIHdpdGggaW50ZXJuYWxseSBj b25zaXN0ZW50IG5hbWluZwpldmVyeW9uZSdzIGhhcHB5IHdpdGgsIGFuZCBoYXZlIHRob3NlIG5h bWVzIGdyb3cgb24gcGVvcGxlLCBidXQgYmFzZWQgb24KdGhlIGRpc2N1c3Npb24gc28gZmFyIEkn bSBub3Qgb3B0aW1pc3RpYy4KClNvIGJhc2ljYWxseSBJIGdhdmUgdXAgb24gdGhhdCwgYW5kIHdp dGggdGhlIGN1cnJlbnQgcHJvcG9zYWwsIHRoZSBuYW1lcwphcmUgdGhlIHNhbWUgYXMgdGhlIHdp ZGVseSB1c2VkIGtlcm5lbCBtYWNyb3MsIHdpdGggUkVHXyBwcmVmaXgKYWRkZWQuIElmIHlvdSBr bm93IHdoYXQgdGhleSBkbywgeW91IGtub3cgd2hhdCB0aGVzZSBkby4gSXQncyBzdGlsbApjb25z aXN0ZW50LCBqdXN0IGluIGEgZGlmZmVyZW50IHdheS4KCkFsc28sIEkgcHJldHR5IG11Y2ggZXhw ZWN0IG91ciBjb2RlIG91dHNpZGUgb2YgaTkxNV9yZWcuaCB0byB1c2UgYSBtaXgKb2Ygb3VyIHZl cnNpb25zIGFuZCB0aGUgdW5kZXJseWluZyBvbmVzLiBBbmQgSSdtIG5vdCBzdXJlIEkgd2FudCB0 bwpzdGFydCBwb2xpY2luZyBwZW9wbGUgdG8gdXNlIG91ciB2ZXJzaW9ucyBleGNsdXNpdmVseS4g SWYgdGhlIG5hbWVzCmRpZmZlciBvbmx5IHdpdGggdGhlIFJFR18gcGFydCwgSSB0aGluayB0aGUg bWl4IHdpbGwgYmUgbXVjaCBlYXNpZXIgdG8KbGl2ZSB3aXRoLgoKQlIsCkphbmkuCgoKCj4KPiBU aGFua3MsCj4gTWljaGFsCj4KCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3Jh cGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eA==