From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([52.28.52.200]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gxAXH-0007YI-5a for ath10k@lists.infradead.org; Fri, 22 Feb 2019 13:06:41 +0000 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH] mac80211: Change default tx_sk_pacing_shift to 7 In-Reply-To: References: <20190221172936.21816-1-toke@redhat.com> Date: Fri, 22 Feb 2019 14:06:35 +0100 Message-ID: <87lg28vup0.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: Kan Yan , wgong@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Grant Grundler , wgong@codeaurora.org, Ben Greear , Kalle Valo Sm9oYW5uZXMgQmVyZyA8am9oYW5uZXNAc2lwc29sdXRpb25zLm5ldD4gd3JpdGVzOgoKPiBUb2tl IEjDuGlsYW5kLUrDuHJnZW5zZW4gd3JvdGU6Cj4KPj4gV2hlbiB3ZSBkaWQgdGhlIG9yaWdpbmFs IHRlc3RzIGZvciB0aGUgb3B0aW1hbCB2YWx1ZSBvZiBza19wYWNpbmdfc2hpZnQsIHdlCj4+IGNh bWUgdXAgd2l0aCA2IG1zIG9mIGJ1ZmZlcmluZyBhcyB0aGUgZGVmYXVsdC4gU2FkbHksIDYgaXMg bm90IGEgcG93ZXIgb2YKPj4gdHdvLCBzbyB3aGVuIHBpY2tpbmcgdGhlIHNoaWZ0IHZhbHVlIEkg ZXJyZWQgb24gdGhlIHNpemUgb2YgbGVzcyBidWZmZXJpbmcKPj4gYW5kIHBpY2tlZCA0IG1zIGlu c3RlYWQgb2YgOC4gVGhpcyB3YXMgcHJvYmFibHkgd3Jvbmc7IHRob3NlIDIgbXMgb2YgZXh0cmEK Pj4gYnVmZmVyaW5nIG1ha2VzIGEgbGFyZ2VyIGRpZmZlcmVuY2UgdGhhbiBJIHRob3VnaHQuCj4+ IAo+PiBTbywgY2hhbmdlIHRoZSBkZWZhdWx0IHBhY2luZyBzaGlmdCB0byA3LCB3aGljaCBjb3Jy ZXNwb25kcyB0byA4IG1zIG9mCj4+IGJ1ZmZlcmluZy4gVGhlIHBvaW50IG9mIGRpbWluaXNoaW5n IHJldHVybnMgcmVhbGx5IGtpY2tzIGluIGFmdGVyIDggbXMsIGFuZAo+PiBzbyBoYXZpbmcgdGhp cyBhcyBhIGRlZmF1bHQgc2hvdWxkIGN1dCBkb3duIG9uIHRoZSBuZWVkIGZvciBleHRlbnNpdmUK Pj4gcGVyLWRldmljZSB0ZXN0aW5nIGFuZCBvdmVycmlkZXMgbmVlZGVkIGluIHRoZSBkcml2ZXJz Lgo+PiAKPj4gU2lnbmVkLW9mZi1ieTogVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJl ZGhhdC5jb20+Cj4KPiBQYXRjaCBhcHBsaWVkIHRvIHdpcmVsZXNzLmdpdCwgdGhhbmtzLgo+Cj4g YTQxZjU2YjlhMTdhIChIRUFEIC0+IG1hYzgwMjExKSBtYWM4MDIxMTogQ2hhbmdlIGRlZmF1bHQK PiB0eF9za19wYWNpbmdfc2hpZnQgdG8gNwoKQ29vbCwgdGhhbmtzISBXaGF0J3MgdGhlIGVhc2ll c3Qgd2F5IHRvIGJhY2twb3J0IHRoaXM/IEkgZmlndXJlIGl0J3MKZWFzaWVyIHRvIGp1c3QgdXBk YXRlIHNrX3BhY2luZ19zaGlmdF91cGRhdGUoKSBpbiB0eC5jIGZvciA0LjE5ICh3aGljaApwcmVk YXRlcyB0aGUgYWRkaXRpb24gb2YgdGhlIGRyaXZlciBvdmVycmlkZSBob29rKTsgc2hhbGwgSSBq dXN0IHNlbmQgYQpzZXBhcmF0ZSBwYXRjaCB0byBzdGFibGUgZm9yIHRoYXQ/IE9yIGRvIHdlIG5l ZWQgdG8gYmFja3BvcnQgdGhlIGRyaXZlcgpvdmVycmlkZSBob29rIGFzIHdlbGw/CgotVG9rZQoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1h aWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E73D0C43381 for ; Fri, 22 Feb 2019 13:06:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8EA4207E0 for ; Fri, 22 Feb 2019 13:06:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b="MmJo2rWN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726199AbfBVNGi (ORCPT ); Fri, 22 Feb 2019 08:06:38 -0500 Received: from mail.toke.dk ([52.28.52.200]:45589 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbfBVNGh (ORCPT ); Fri, 22 Feb 2019 08:06:37 -0500 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1550840796; bh=f24yHwngh8o++0Ca0Cw6BVw00eFHMY+e3ydp+UyOWLU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MmJo2rWNsGJVLAxoZAftELR/YRvDuiBR3samsP+sjjVG1S0zObWxBqDBPSulvAUmR kP/7rHUPc40G3q+gBwcmSLRVpB/C4xfrpq3dmILU2wi3g2e0/fbf012DZjCKPJaG3r aV1aMZHMpfeUDAQPpR3DKg/FGkrhcTyfaMIGxQXm8EauFfDtm+UBbUHlGT31tg6TZL nc5tc4zPIwSWvNl7jCYlVCOuOJtE3+PJjfZlTyiciwimDcJNsZ847cEtkHGLUw+X3K Q44v606QdHvNZktrFVskBGjveT2nuMX++edUTyV4rjao9d5cDb47M3zdRVWYarLEPs G+5X6/ZeooHCA== To: Johannes Berg Cc: linux-wireless@vger.kernel.org, Ben Greear , Grant Grundler , Kalle Valo , wgong@qti.qualcomm.com, ath10k@lists.infradead.org, wgong@codeaurora.org, Kan Yan Subject: Re: [PATCH] mac80211: Change default tx_sk_pacing_shift to 7 In-Reply-To: References: <20190221172936.21816-1-toke@redhat.com> Date: Fri, 22 Feb 2019 14:06:35 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87lg28vup0.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johannes Berg writes: > Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >> When we did the original tests for the optimal value of sk_pacing_shift,= we >> came up with 6 ms of buffering as the default. Sadly, 6 is not a power of >> two, so when picking the shift value I erred on the size of less bufferi= ng >> and picked 4 ms instead of 8. This was probably wrong; those 2 ms of ext= ra >> buffering makes a larger difference than I thought. >>=20 >> So, change the default pacing shift to 7, which corresponds to 8 ms of >> buffering. The point of diminishing returns really kicks in after 8 ms, = and >> so having this as a default should cut down on the need for extensive >> per-device testing and overrides needed in the drivers. >>=20 >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > > Patch applied to wireless.git, thanks. > > a41f56b9a17a (HEAD -> mac80211) mac80211: Change default > tx_sk_pacing_shift to 7 Cool, thanks! What's the easiest way to backport this? I figure it's easier to just update sk_pacing_shift_update() in tx.c for 4.19 (which predates the addition of the driver override hook); shall I just send a separate patch to stable for that? Or do we need to backport the driver override hook as well? -Toke